this was caught by the recent __ARRAY_CHECK stuff.
Signed-off-by: YAMAMOTO Takashi
---
lib/signals.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/signals.c b/lib/signals.c
index f11ed05..27da5d6 100644
--- a/lib/signals.c
+++ b/lib/signals.c
@@ -110,7 +110,7 @@ const c
On Wed, Oct 02, 2013 at 04:46:15PM -0700, Ben Pfaff wrote:
> On Wed, Oct 02, 2013 at 06:44:44PM -0300, Flavio Leitner wrote:
> > On Wed, Oct 02, 2013 at 12:34:53PM -0700, Ben Pfaff wrote:
> > > On Wed, Oct 02, 2013 at 02:40:09AM -0300, Flavio Leitner wrote:
> > > > GCC provides two useful builtin f
On Wed, Oct 02, 2013 at 11:03:57AM -0700, Pravin Shelar wrote:
> On Mon, Sep 30, 2013 at 11:47 PM, Simon Horman wrote:
> > Allow datapath to recognize and extract MPLS labels into flow keys
> > and execute actions which push, pop, and set labels on packets.
> >
> > Based heavily on work by Leo Alt
On Wed, Oct 02, 2013 at 06:44:44PM -0300, Flavio Leitner wrote:
> On Wed, Oct 02, 2013 at 12:34:53PM -0700, Ben Pfaff wrote:
> > On Wed, Oct 02, 2013 at 02:40:09AM -0300, Flavio Leitner wrote:
> > > GCC provides two useful builtin functions that can help
> > > to improve array size checking during
This commit moves the ofproto-dpif-monitor module into a
dedicated thread. This helps eliminate the burden of main
thread having to wake up very frequently for periodic
interface monitoring (bfd, cfm). Also, this commit greatly
increases the number of bfd/cfm sessions that can be supported
by ovs
On Wed, Oct 02, 2013 at 12:34:53PM -0700, Ben Pfaff wrote:
> On Wed, Oct 02, 2013 at 02:40:09AM -0300, Flavio Leitner wrote:
> > GCC provides two useful builtin functions that can help
> > to improve array size checking during compilation.
> >
> > This patch contains no functional changes, but it
As Ethan suggested, I add an optimization with this V2 patch.
I use stub in monitor_run() to eliminate the need to resize ofpbuf in
bfd_put_packet() and cfm_compose_packet().
>From perf result, the improvement is very small. It is possible that the
big cpu consumption of "libc-2.15.so" is caused
This commit adds a new module ofproto-dpif-monitor in ofproto
directory. This module is in charge of executing the periodic
functions of monitoring code (e.g. bfd and cfm).
Signed-off-by: Alex Wang
---
v1 -> v2:
- refine the comments.
- prevent resizing ofpbuf in monitor_run() by using stub.
-
On Wed, Oct 02, 2013 at 02:40:09AM -0300, Flavio Leitner wrote:
> GCC provides two useful builtin functions that can help
> to improve array size checking during compilation.
>
> This patch contains no functional changes, but it makes
> it easier to detect mistakes.
>
> Signed-off-by: Flavio Leit
Thanks, applied.
On Wed, Oct 02, 2013 at 11:30:08AM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
>
> On Wed, Oct 2, 2013 at 11:16 AM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > ofproto/ofproto-dpif-upcall.c |4
> > 1 file changed, 4 deletions(-)
> >
> > dif
Acked-by: Ethan Jackson
On Wed, Oct 2, 2013 at 11:16 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-dpif-upcall.c |4
> 1 file changed, 4 deletions(-)
>
> diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
> index 07c302f..9ec081a 1006
This commit makes the main thread wake up all other threads when time is
warped.
Signed-off-by: Alex Wang
---
v2 -> v3:
- make timewarp_wait() no-op when timeval_dummy_register() is not called.
v1 -> v2:
- change the code to make main thread wake up all other threads when time
is warped.
- ch
On Wed, Oct 2, 2013 at 10:08 AM, Ben Pfaff wrote:
> On Wed, Oct 02, 2013 at 09:32:25AM -0700, Gurucharan Shetty wrote:
>> From: Duffie Cooley
>>
>> commit 46528f78e5c(debian, rhel, xenserver: Ability to collect ovs-ctl logs)
>> made changes in the startup scripts such that the o/p of ovs-ctl is l
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif-upcall.c |4
1 file changed, 4 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 07c302f..9ec081a 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b/ofproto/ofproto-dpif-upcall.c
@@ -488,7 +488,6
On Wed, Oct 02, 2013 at 10:15:36AM +0300, Dmitry Fleytman wrote:
>
> On Sep 19, 2013, at 23:06 PM, Ben Pfaff wrote:
>
> > On Thu, Sep 19, 2013 at 12:48:05PM -0700, Ben Pfaff wrote:
> >> On Thu, Sep 19, 2013 at 12:48:19PM -0700, Jarno Rajahalme wrote:
> >>> Small typo on the first line of the new
On Wed, Sep 25, 2013 at 08:55:21AM -0700, Ben Pfaff wrote:
> On Wed, Sep 25, 2013 at 01:38:58PM +0900, YAMAMOTO Takashi wrote:
> > if a queue length is long (ie. non-0), the consumer thread should
> > already be busy working on the queue. there's no need to wake it
> > up repeatedly.
> >
> > Sign
On Mon, Sep 30, 2013 at 11:47 PM, Simon Horman wrote:
> Allow datapath to recognize and extract MPLS labels into flow keys
> and execute actions which push, pop, and set labels on packets.
>
> Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe
> Stringer.
>
> Cc: Ravi K
> Cc:
sure, I should do that, thanks
On Wed, Oct 2, 2013 at 10:20 AM, Ben Pfaff wrote:
> On Wed, Oct 02, 2013 at 07:31:49AM -0700, Alex Wang wrote:
> > This commit makes the main thread wake up all other threads when time is
> > warped.
> >
> > Signed-off-by: Alex Wang
>
> I am a little nervous abou
On Wed, Oct 02, 2013 at 07:31:49AM -0700, Alex Wang wrote:
> This commit makes the main thread wake up all other threads when time is
> warped.
>
> Signed-off-by: Alex Wang
I am a little nervous about adding overhead to the common case to
serve only the rare case of a time-warp. I suggest that
From: Duffie Cooley
commit 46528f78e5c(debian, rhel, xenserver: Ability to collect ovs-ctl logs)
made changes in the startup scripts such that the o/p of ovs-ctl is logged
into ovs-ctl.log. But it had an unintended consequence that the exit status
of ovs-ctl was no longer returned. We would alway
On Wed, Oct 02, 2013 at 07:17:18AM -0700, Alex Wang wrote:
> This commit moves the main logic of send_packet() function into
> the ofproto-dpif-xlate module. Also, modification is made to
> guarantee the thread safety of ofproto-dpif-xlate module.
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaf
On Wed, Oct 02, 2013 at 09:32:25AM -0700, Gurucharan Shetty wrote:
> From: Duffie Cooley
>
> commit 46528f78e5c(debian, rhel, xenserver: Ability to collect ovs-ctl logs)
> made changes in the startup scripts such that the o/p of ovs-ctl is logged
> into ovs-ctl.log. But it had an unintended conse
On Wed, Oct 2, 2013 at 9:54 AM, Ben Pfaff wrote:
> On Wed, Oct 02, 2013 at 07:20:11AM -0700, Gurucharan Shetty wrote:
>> commit 46528f78e5c(debian, rhel, xenserver: Ability to collect ovs-ctl logs)
>> made changes in the startup scripts such that the o/p of ovs-ctl is logged
>> into ovs-ctl.log. B
From: Duffie Cooley
commit 46528f78e5c(debian, rhel, xenserver: Ability to collect ovs-ctl logs)
made changes in the startup scripts such that the o/p of ovs-ctl is logged
into ovs-ctl.log. But it had an unintended consequence that the exit status
of ovs-ctl was no longer returned. We would alway
On Wed, Oct 02, 2013 at 07:20:11AM -0700, Gurucharan Shetty wrote:
> commit 46528f78e5c(debian, rhel, xenserver: Ability to collect ovs-ctl logs)
> made changes in the startup scripts such that the o/p of ovs-ctl is logged
> into ovs-ctl.log. But it had an unintended consequence that the exit statu
On Wed, Oct 2, 2013 at 7:55 AM, Gurucharan Shetty wrote:
> Duffie,
> I will need a Signed-off-by by you.
> (I do not see a Authored-by convention used anywhere. So I put you as
> Co-authored-by. If there is such a thing, I will change it.)
You can use --author to set the author in the commit and
Signed-off-by: Duffie Cooley
Thanks!
Duffie
On Oct 2, 2013 7:56 AM, "Gurucharan Shetty" wrote:
> Duffie,
> I will need a Signed-off-by by you.
> (I do not see a Authored-by convention used anywhere. So I put you as
> Co-authored-by. If there is such a thing, I will change it.)
>
> On Wed, Oct
Duffie,
I will need a Signed-off-by by you.
(I do not see a Authored-by convention used anywhere. So I put you as
Co-authored-by. If there is such a thing, I will change it.)
On Wed, Oct 2, 2013 at 7:20 AM, Gurucharan Shetty wrote:
> commit 46528f78e5c(debian, rhel, xenserver: Ability to collect
commit 46528f78e5c(debian, rhel, xenserver: Ability to collect ovs-ctl logs)
made changes in the startup scripts such that the o/p of ovs-ctl is logged
into ovs-ctl.log. But it had an unintended consequence that the exit status
of ovs-ctl was no longer returned. We would always return success(the e
This commit makes the main thread wake up all other threads when time is
warped.
Signed-off-by: Alex Wang
---
v1 -> v2:
- change the code to make main thread wake up all other threads when time
is warped.
- change the commit log.
---
lib/poll-loop.c |5 +
lib/timeval.c | 21
This commit makes the update of 'stats' member in ofproto_dpif
struct thread safe.
Signed-off-by: Alex Wang
---
v1 -> v2:
- add thread-safety tag OVS_GUARDED.
---
ofproto/ofproto-dpif.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/o
As Paul mentioned, there is a missing descriptor 4 in the code. I will
fix it up, test it and send a patch.
On Tue, Oct 1, 2013 at 4:17 PM, Paul Ingram wrote:
> OK, but I don't see the redirect to descriptor 4 in the real code (it's
> obviously there in the example).
>
> :: psi
>
> On Oct 1, 2013
This commit moves the main logic of send_packet() function into
the ofproto-dpif-xlate module. Also, modification is made to
guarantee the thread safety of ofproto-dpif-xlate module.
Signed-off-by: Alex Wang
---
v1 -> v2:
- move dpif_execute inside critical section.
- add a blank line before #e
On Sep 19, 2013, at 23:06 PM, Ben Pfaff wrote:
> On Thu, Sep 19, 2013 at 12:48:05PM -0700, Ben Pfaff wrote:
>> On Thu, Sep 19, 2013 at 12:48:19PM -0700, Jarno Rajahalme wrote:
>>> Small typo on the first line of the new comment.
>>
>> Oops, fixed.
>>
>>> Acked-by: Jarno Rajahalme
>>
>> Thank
34 matches
Mail list logo
