On Wed, Oct 2, 2013 at 9:54 AM, Ben Pfaff <[email protected]> wrote: > On Wed, Oct 02, 2013 at 07:20:11AM -0700, Gurucharan Shetty wrote: >> commit 46528f78e5c(debian, rhel, xenserver: Ability to collect ovs-ctl logs) >> made changes in the startup scripts such that the o/p of ovs-ctl is logged >> into ovs-ctl.log. But it had an unintended consequence that the exit status >> of ovs-ctl was no longer returned. We would always return success(the exit >> status of tee). >> >> With this commit, we return the exit status of ovs-ctl instead of tee. >> Code referenced from: (line wrapped). >> http://unix.stackexchange.com/questions/14270/\ >> get-exit-status-of-process-thats-piped-to-another/70675#70675) >> >> Signed-off-by: Gurucharan Shetty <[email protected]> >> Co-authored-by: Duffie Cooley <[email protected]> > > I'd like to see a reference to that URL in a comment in the shell > script itself, as well as a sentence or so explaining WTF the code > does. Maybe: > > # Tee ovs-ctl output to ovs-ctl.log and yield ovs-ctl's exit status. > # See > http://unix.stackexchange.com/questions/14270/get-exit-status-of-process-thats-piped-to-another/70675#70675) > > Then coming across this is less of a "WTF!" moment.
Okay. I will send a V3. > > Thanks, > > Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
