Re: [ovs-dev] [PATCH v2 1/4] datapath: Restructure datapath.c and flow.c

2013-09-27 Thread Jesse Gross
On Fri, Sep 27, 2013 at 5:36 PM, Pravin Shelar wrote: > On Fri, Sep 27, 2013 at 3:21 PM, Jesse Gross wrote: >> On Fri, Sep 27, 2013 at 3:06 PM, Jesse Gross wrote: >>> On Thu, Sep 26, 2013 at 9:01 AM, Pravin B Shelar wrote: Over the time datapath.c and flow.c has became pretty large files.

Re: [ovs-dev] [PATCH v2 1/4] datapath: Restructure datapath.c and flow.c

2013-09-27 Thread Pravin Shelar
On Fri, Sep 27, 2013 at 3:21 PM, Jesse Gross wrote: > On Fri, Sep 27, 2013 at 3:06 PM, Jesse Gross wrote: >> On Thu, Sep 26, 2013 at 9:01 AM, Pravin B Shelar wrote: >>> Over the time datapath.c and flow.c has became pretty large files. >>> Following patch restructures functionality of component

Re: [ovs-dev] [PATCH 2/2] Suppress warnings about unused variables and functions.

2013-09-27 Thread Ben Pfaff
Thanks, I applied these. On Fri, Sep 27, 2013 at 04:21:34PM -0700, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > > > On Thu, Sep 26, 2013 at 11:23 AM, Ben Pfaff wrote: > > From: Jarno Rajahalme > > > > These variables and functions are unused but we don't want to remove > > their defini

Re: [ovs-dev] [PATCH 2/2] Suppress warnings about unused variables and functions.

2013-09-27 Thread Ethan Jackson
Acked-by: Ethan Jackson On Thu, Sep 26, 2013 at 11:23 AM, Ben Pfaff wrote: > From: Jarno Rajahalme > > These variables and functions are unused but we don't want to remove > their definitions. > > Found by Clang. > > Signed-off-by: Jarno Rajahalme > Signed-off-by: Ben Pfaff > --- > lib/ofp

Re: [ovs-dev] [PATCH 1/2] Remove unused variables and functions.

2013-09-27 Thread Ethan Jackson
Acked-by: Ethan Jackson On Thu, Sep 26, 2013 at 11:23 AM, Ben Pfaff wrote: > From: Jarno Rajahalme > > Found by Clang. > > Signed-off-by: Jarno Rajahalme > Signed-off-by: Ben Pfaff > --- > lib/aes128.c | 335 > > lib/dpif.c

[ovs-dev] [PATCH V2 3/3] ofproto-dpif-monitor: Move ofproto-dpif-monitor to a single thread.

2013-09-27 Thread Alex Wang
This commit moves the ofproto-dpif-monitor module into a dedicated thread. Signed-off-by: Alex Wang --- v1 -> v2: - re-adjust the code base on changes made to previous patches. --- lib/bfd.c |4 +- lib/timeval.c | 20 ++ lib/timeval.h

[ovs-dev] [PATCH V2 2/3] ofproto-dpif-monitor: Add ofproto-dpif-monitor module.

2013-09-27 Thread Alex Wang
This commit adds a new module ofproto-dpif-monitor in ofproto directory. This module is in charge of executing the periodic functions of monitoring code (e.g. bfd and cfm). Signed-off-by: Alex Wang --- v1 -> v2: - ditch the monitor struct in the monitor module. - add monitor_rwlock in the monit

[ovs-dev] [PATCH V2 1/3] ofproto-dpif: Move send_packet() to ofproto-dpif-xlate module.

2013-09-27 Thread Alex Wang
This commit moves the main logic of send_packet() function into the ofproto-dpif-xlate module. Also, the xlate_actions() function in ofproto-dpif-xlate module is adjusted to guarantee thread safety. Signed-off-by: Alex Wang --- v1 -> v2: - change xlate_actions to a thread safe version and threa

Re: [ovs-dev] [PATCH v2 1/4] datapath: Restructure datapath.c and flow.c

2013-09-27 Thread Jesse Gross
On Fri, Sep 27, 2013 at 3:06 PM, Jesse Gross wrote: > On Thu, Sep 26, 2013 at 9:01 AM, Pravin B Shelar wrote: >> Over the time datapath.c and flow.c has became pretty large files. >> Following patch restructures functionality of component into three >> different components: >> >> flow.c: contains

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif: Move send_packet() to ofproto-dpif-xlate module.

2013-09-27 Thread Alex Wang
Yes, I'll add mutex. Will send out V2 soon, On Thu, Sep 26, 2013 at 1:16 PM, Ethan Jackson wrote: > Yeah it's trivial, I just think the feature is a bit odd/confusing. > But if you think it's useful we'll keep it. Alex could you just slap > a mutex around it? > > Ethan > > On Thu, Sep 26, 2013

Re: [ovs-dev] [PATCH v2 1/4] datapath: Restructure datapath.c and flow.c

2013-09-27 Thread Jesse Gross
On Thu, Sep 26, 2013 at 9:01 AM, Pravin B Shelar wrote: > Over the time datapath.c and flow.c has became pretty large files. > Following patch restructures functionality of component into three > different components: > > flow.c: contains flow extract. > flow_netlink.c: netlink flow api. > flow_ta

Re: [ovs-dev] [PATCH v2 1/2] Widen TCP flags handling.

2013-09-27 Thread Ben Pfaff
On Wed, Sep 25, 2013 at 09:42:28AM -0700, Jarno Rajahalme wrote: > Widen TCP flags handling from 7 bits (uint8_t) to 12 bits (uint16_t). > The kernel interface remains at 8 bits, which makes no functional > difference now, as none of the higher bits is currently of interest > to the userspace. > >

Re: [ovs-dev] [PATCH v2.40 6/7] datapath: Break out deacceleration portion of vlan_push

2013-09-27 Thread Jesse Gross
On Fri, Sep 27, 2013 at 12:48 PM, Ben Pfaff wrote: > On Fri, Sep 27, 2013 at 09:18:35AM +0900, Simon Horman wrote: >> Break out deacceleration portion of vlan_push into vlan_put >> so that it may be re-used by mpls_push. >> >> For both vlan_push and mpls_push if there is an accelerated VLAN tag >>

Re: [ovs-dev] [PATCH] ovs-bugtool: Change log-days parameter based on file last_mod_time

2013-09-27 Thread Gurucharan Shetty
On Fri, Sep 27, 2013 at 1:15 PM, Shih-Hao Li wrote: > From: Shih-Hao Li > > Previously the log-days parameter can only support rotated logs > based on their numbered filename extension. Thus it can not be > used for other types of log filenames. This patch changes it to > be based on file last mo

[ovs-dev] [PATCH] ovs-bugtool: Change log-days parameter based on file last_mod_time

2013-09-27 Thread Shih-Hao Li
From: Shih-Hao Li Previously the log-days parameter can only support rotated logs based on their numbered filename extension. Thus it can not be used for other types of log filenames. This patch changes it to be based on file last modification time. Issue: #19671 Signed-off-by: Shih-Hao Li ---

Re: [ovs-dev] [PATCH] ovs-bugtool: Change log-days parameter based on file last_mod_time

2013-09-27 Thread Gurucharan Shetty
On Fri, Sep 27, 2013 at 11:41 AM, Shih-Hao Li wrote: > From: Shih-Hao Li > > Previously the log-days parameter can only support rotated logs > based on their numbered filename extension. Thus it can not be > used for other types of log filenames. This patch changes it to > be based on file last m

Re: [ovs-dev] [PATCH v2.40 6/7] datapath: Break out deacceleration portion of vlan_push

2013-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2013 at 09:18:35AM +0900, Simon Horman wrote: > Break out deacceleration portion of vlan_push into vlan_put > so that it may be re-used by mpls_push. > > For both vlan_push and mpls_push if there is an accelerated VLAN tag > present then it should be deaccelerated, adding it to the

Re: [ovs-dev] [PATCH v2.40 5/7] lib: Push MPLS tags in the OpenFlow 1.3 ordering

2013-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2013 at 09:18:34AM +0900, Simon Horman wrote: > From: Joe Stringer > > This patch modifies the push_mpls behaviour to follow the OpenFlow 1.3 > specification in the presence of VLAN tagged packets. From the spec: > > "Newly pushed tags should always be inserted as the outermost t

Re: [ovs-dev] [PATCH v2.40 4/7] ofp-actions: Add separate OpenFlow 1.3 action parser

2013-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2013 at 09:18:33AM +0900, Simon Horman wrote: > From: Joe Stringer > > This patch adds new ofpact_from_openflow13() and > ofpacts_from_openflow13() functions parallel to the existing ofpact > handling code. In the OpenFlow 1.3 version, push_mpls is handled > differently, but all o

Re: [ovs-dev] [PATCH v2.40 3/7] ofp-actions: Add OFPUTIL_OFPAT13_PUSH_MPLS

2013-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2013 at 09:18:32AM +0900, Simon Horman wrote: > From: Joe Stringer > > This patch adds a new compatibility enum for use with MPLS, so that the > differing behaviour between OpenFlow 1.2 and 1.3 can be implemented in > ofproto-dpif-xlate. It seems a little awkward to me to do this

Re: [ovs-dev] [PATCH v2.40 2/7] odp: Allow VLAN actions after MPLS actions

2013-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2013 at 09:18:31AM +0900, Simon Horman wrote: > From: Joe Stringer > > OpenFlow 1.2 and 1.3 differ on their handling of MPLS actions in the > presence of VLAN tags. To allow correct behaviour to be committed in > each situation, this patch adds a second round of VLAN tag action >

[ovs-dev] [PATCH] ovs-bugtool: Change log-days parameter based on file last_mod_time

2013-09-27 Thread Shih-Hao Li
From: Shih-Hao Li Previously the log-days parameter can only support rotated logs based on their numbered filename extension. Thus it can not be used for other types of log filenames. This patch changes it to be based on file last modification time. Issue: #19671 Signed-off-by: Shih-Hao Li ---

Re: [ovs-dev] [PATCH] ovs-bugtool: Change log-days parameter based on file last_mod_time

2013-09-27 Thread Shih-Hao Li
Thanks for the review. Please see inlines. Shih-Hao - Original Message - > From: "Gurucharan Shetty" > To: "Shih-Hao Li" > Cc: "dev" , "Shih-Hao Li" > Sent: Friday, September 27, 2013 10:15:36 AM > Subject: Re: [ovs-dev] [PATCH] ovs-bugtool: Change log-days parameter based > on file

Re: [ovs-dev] [PATCH] ovs-bugtool: Change log-days parameter based on file last_mod_time

2013-09-27 Thread Gurucharan Shetty
On Thu, Sep 26, 2013 at 1:25 PM, Shih-Hao Li wrote: > From: Shih-Hao Li > > Previously the log-days parameter can only support rotated logs > based on their numbered filename extension. Thus it can not be > used for other types of log filenames. This patch changes it to > be based on file last mo

Re: [ovs-dev] [PATCH v2.40 1/7] odp: Only pass vlan_tci to commit_vlan_action()

2013-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2013 at 09:18:30AM +0900, Simon Horman wrote: > From: Joe Stringer > > This allows for future patches to pass different tci values to > commit_vlan_action() without passing an entire flow structure. > > Signed-off-by: Joe Stringer > Signed-off-by: Simon Horman Applied, thanks.

Re: [ovs-dev] [PATCH v3] Remove mpls_depth field from flow

2013-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2013 at 06:55:19AM +0900, Simon Horman wrote: > Rather than tracking the MPLS depth as a field in the > flow, which is an entirely poor place for it, just track > the delta to the MPLS depth during translation. > > This logic was developed while implementing recirculation > and int

[ovs-dev] GPS tracker with multi discrete shared an album with you.

2013-09-27 Thread GPS tracker with multi discrete
Tips: GPS tracker with multi discrete input and output /Attn: purchase manager Dear Sir This is Anna,the sales manager of Redview GPS in China. VT310 is a GPS tracker with 5 discrete inputs ,5 discrete outputs and 2 analog ports . With VT310,you can get vehicle windows status