On Fri, Sep 27, 2013 at 5:36 PM, Pravin Shelar <[email protected]> wrote: > On Fri, Sep 27, 2013 at 3:21 PM, Jesse Gross <[email protected]> wrote: >> On Fri, Sep 27, 2013 at 3:06 PM, Jesse Gross <[email protected]> wrote: >>> On Thu, Sep 26, 2013 at 9:01 AM, Pravin B Shelar <[email protected]> wrote: >>>> Over the time datapath.c and flow.c has became pretty large files. >>>> Following patch restructures functionality of component into three >>>> different components: >>>> >>>> flow.c: contains flow extract. >>>> flow_netlink.c: netlink flow api. >>>> flow_table.c: flow table api. >>>> >>>> Diffstat is showing wrong count. This patch does not change code. >>>> >>>> Signed-off-by: Pravin B Shelar <[email protected]> >>> >>> This looks like a good reorganization to me. One thing that surprised >>> me was that there is no flow_netlink.h - it seems like we could >>> further break some of that out of flow.h. >> >> I would probably also keep ovs_flow_used() and ovs_flow_used_time() in >> flow.c since it doesn't really seem related to the flow table itself. >> > ok. > >> I wonder if we should also break the names down by module and make >> them more consistent. > I guess you are referring to function names.
Yes, that's what I meant. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
