This is a first step towards implementing the dpif side of groups.
In order to be useful the action translation code needs
to be taught about groups.
Compile tested only.
Signed-off-by: Simon Horman
---
ofproto/ofproto-dpif.c | 111 ++---
ofproto/ofp
struct ofputil_group_stats has an arbitrary limit
of 16 buckets for which it can record statistics.
However the code does not appear to enforce this
limit and it seems to me that the code could overflow.
This patch aims to remove the arbitrary limit by
removing the 'bucket_stats' field from struct
Adjust formatting in ovs-ofctl so that apply_actions, clear_actions
write_metadata and goto_table appear at the same level
of indentation as actions rather being indented as if
they are arguments to the learn action.
Signed-off-by: Simon Horman
---
utilities/ovs-ofctl.8.in | 2 +-
1 file changed
On Fri, Aug 30, 2013 at 01:40:18PM -0700, Jarno Rajahalme wrote:
> The "groups" container is protected with a rwlock, and each group is
> protected with their own rwlock. Whenever groups are looked up, the
> container's lock is taken. If a group is found, the group is locked
> before the containe
On Sun, Sep 01, 2013 at 06:24:39PM -0700, Ben Pfaff wrote:
> On Sat, Aug 31, 2013 at 02:11:39PM +0900, Simon Horman wrote:
> > On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote:
> > > Also, since all kinds of groups can refer to other groups, there is no
> > > reason to delete indirec
On Sat, Aug 31, 2013 at 02:11:39PM +0900, Simon Horman wrote:
> On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote:
> > Also, since all kinds of groups can refer to other groups, there is no
> > reason to delete indirect groups first.
>
> This seems reasonable to me, but its not clear
On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote:
> Also, since all kinds of groups can refer to other groups, there is no
> reason to delete indirect groups first.
>
> Signed-off-by: Jarno Rajahalme
I folded this in, thanks.
I've now added you as a co-author, also.
_
On Fri, Aug 30, 2013 at 01:40:16PM -0700, Jarno Rajahalme wrote:
> Indirect groups can have at most one bucket.
>
> Signed-off-by: Jarno Rajahalme
Good catch, thank you.
I chose to just add this instead, though:
+if (gm->type == OFPGT11_INDIRECT && !list_is_short(&gm->buckets)) {
+
On Sun, Sep 01, 2013 at 10:22:41PM +0900, Simon Horman wrote:
> > * Implement Write-Actions instruction.
>
> It seems to me that the logic required to martial write-actions
> in such a way that actions act like an action set is also
> needed by the actions of buckets of groups.
>
> As such, I
On Sun, Sep 01, 2013 at 12:33:20PM +0300, Alexandru Copot wrote:
> On Fri, Aug 30, 2013 at 7:10 PM, Ben Pfaff wrote:
> > [redirecting to ovs-dev]
> >> > * OFPT_FLOW_MOD ability to delete flows in all tables.
> >> I would like to do this.
> >
> > Thanks!
>
> I would like to work on event filteri
[ Reply to post to ovs-announce ]
On Thu, Aug 29, 2013 at 09:57:05PM -0700, Ben Pfaff wrote:
> This email is an update for the initial hackathon plan that I sent out
> earlier this month. Everything in that email is still accurate. You
> can read the earlier email at:
> http://openvswitch.or
On Fri, Aug 30, 2013 at 7:10 PM, Ben Pfaff wrote:
> [redirecting to ovs-dev]
>> > * OFPT_FLOW_MOD ability to delete flows in all tables.
>> I would like to do this.
>
> Thanks!
I would like to work on event filtering (OFPT_SET_ASYNC). However, it seems that
OFPT_SET_ASYNC is already implemented
12 matches
Mail list logo
