[ovs-dev] [groups v2 1/2] list: New function list_move().

2013-08-28 Thread Ben Pfaff
An upcoming commit will add more users. Signed-off-by: Ben Pfaff --- lib/list.c | 14 ++ lib/list.h |3 ++- ofproto/ofproto-dpif.c | 22 ++ 3 files changed, 22 insertions(+), 17 deletions(-) diff --git a/lib/list.c b/lib/list.c ind

[ovs-dev] [groups v2 0/2] Revised "groups" proposal

2013-08-28 Thread Ben Pfaff
Here's a second version of the "groups" patch originally posted at the end of June. I've gone over most of it pretty carefully and reworked some parts to my liking. It needs a manpage update and some more comments before it is totally ready. Ben Pfaff (1): list: New function list_move(). Neil

Re: [ovs-dev] OF1.1+ Groups

2013-08-28 Thread Ben Pfaff
I'm catching up, stay tuned to this channel for breaking developments. On Aug 28, 2013 5:51 PM, "Simon Horman" wrote: > On Tue, Aug 20, 2013 at 01:57:50PM -0700, Ben Pfaff wrote: > > On Sun, Aug 18, 2013 at 02:35:05PM +1000, Simon Horman wrote: > > > On Sun, Aug 04, 2013 at 07:45:38PM -0700, Ben

Re: [ovs-dev] OF1.1+ Groups

2013-08-28 Thread Simon Horman
On Tue, Aug 20, 2013 at 01:57:50PM -0700, Ben Pfaff wrote: > On Sun, Aug 18, 2013 at 02:35:05PM +1000, Simon Horman wrote: > > On Sun, Aug 04, 2013 at 07:45:38PM -0700, Ben Pfaff wrote: > > > On Mon, Aug 05, 2013 at 11:38:57AM +0900, Simon Horman wrote: > > > > Hi, > > > > > > > > I would like to

Re: [ovs-dev] [PATCH 2/2] Prepare for post-2.0.0 (2.0.90).

2013-08-28 Thread Justin Pettit
Thanks for the reviews. Ethan or Ben, it's probably worth mentioning multi-threading in NEWS. It's kind of a big deal. :-) --Justin On Aug 28, 2013, at 4:22 PM, Ben Pfaff wrote: > Both look good to me, thanks. > > On Aug 28, 2013 4:20 PM, "Justin Pettit" wrote: > Signed-off-by: Justin Pe

Re: [ovs-dev] [PATCH 2/2] Prepare for post-2.0.0 (2.0.90).

2013-08-28 Thread Ben Pfaff
Both look good to me, thanks. On Aug 28, 2013 4:20 PM, "Justin Pettit" wrote: > Signed-off-by: Justin Pettit > --- > NEWS |4 > configure.ac |2 +- > debian/changelog |8 > 3 files changed, 13 insertions(+), 1 deletions(-) > > diff --git a/NEWS b/NEWS >

[ovs-dev] [PATCH 2/2] Prepare for post-2.0.0 (2.0.90).

2013-08-28 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS |4 configure.ac |2 +- debian/changelog |8 3 files changed, 13 insertions(+), 1 deletions(-) diff --git a/NEWS b/NEWS index db99be2..7c1b480 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +Post-v2.0.0 +--

[ovs-dev] [PATCH 1/2] Prepare for 2.0.0.

2013-08-28 Thread Justin Pettit
We decided to call the next release 2.0 instead of 1.12. Signed-off-by: Justin Pettit --- NEWS |9 ++--- configure.ac |2 +- debian/changelog | 20 ++-- 3 files changed, 13 insertions(+), 18 deletions(-) diff --git a/NEWS b/NEWS index e509456..db99b

Re: [ovs-dev] [risc 4/4] packets, pktbuf: Align L3 headers on 32-bit boundary.

2013-08-28 Thread Ben Pfaff
Cool, that gives me greater confidence in the fix. On Aug 28, 2013 4:11 PM, "Alex Wang" wrote: > Hey Ben, > > I experimented using Justin's Sparky.~ It is pretty slow. But it makes me > feel pretty cool! > > The previously failed unit tests all passed. ;D > > Thanks, > > > > On Tue, Aug 27, 2013

Re: [ovs-dev] [risc 4/4] packets, pktbuf: Align L3 headers on 32-bit boundary.

2013-08-28 Thread Alex Wang
Hey Ben, I experimented using Justin's Sparky.~ It is pretty slow. But it makes me feel pretty cool! The previously failed unit tests all passed. ;D Thanks, On Tue, Aug 27, 2013 at 10:09 PM, Ben Pfaff wrote: > On Tue, Aug 27, 2013 at 04:01:44PM -0700, Alex Wang wrote: > > Thanks for the exp

Re: [ovs-dev] [PATCH] tunnel: Make tnl_find() easier to understand.

2013-08-28 Thread Jarno Rajahalme
On Aug 27, 2013, at 10:43 PM, Ben Pfaff wrote: > On Tue, Aug 27, 2013 at 04:03:18PM -0700, Jarno Rajahalme wrote: >> >> On Aug 27, 2013, at 11:12 AM, Ben Pfaff wrote: >> >>> Suggested-by: pritesh >>> Signed-off-by: Ben Pfaff >>> --- >>> ofproto/tunnel.c | 100 >>> +

Re: [ovs-dev] [PATCH] Set release date for 1.11.0.

2013-08-28 Thread Ben Pfaff
On Wed, Aug 28, 2013 at 02:33:07PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Yay, a release, let's do it. Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Set release date for 1.11.0.

2013-08-28 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS |2 +- debian/changelog |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ef97b04..e509456 100644 --- a/NEWS +++ b/NEWS @@ -30,7 +30,7 @@ v1.12.0 - xx xxx - Added configurable flow caching su

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Batch upcalls.

2013-08-28 Thread Ben Pfaff
On Wed, Aug 28, 2013 at 12:06:07PM -0700, Jarno Rajahalme wrote: > Batching reduces overheads and enables upto 4 times the upcall processing > performance in a specialized test case. > > Signed-off-by: Jarno Rajahalme > --- > v2: Do not wake consumer threads if they are already keeping the queue

Re: [ovs-dev] [PATCH] don't bother to ask dpif class delete ODPP_NONE.

2013-08-28 Thread Ben Pfaff
On Wed, Aug 28, 2013 at 02:58:02PM +0900, YAMAMOTO Takashi wrote: > > On Wed, Aug 28, 2013 at 10:38:06AM +0900, YAMAMOTO Takashi wrote: > >> > On Tue, Aug 27, 2013 at 04:10:03PM +0900, YAMAMOTO Takashi wrote: > >> >> this fixes ofp_port_status delivery on a patch port removal. > >> > > >> > Can yo

Re: [ovs-dev] [PATCH] stop overriding patch vport type with dummy

2013-08-28 Thread Ben Pfaff
On Wed, Aug 28, 2013 at 04:33:07PM +0900, YAMAMOTO Takashi wrote: > there's little point to override patch ports, which is implmeneted > purely in our userlang process these days, with a dummy implementation. > > this allows testing patch ports in "make sandbox" environment. > > Signed-off-by: YA

Re: [ovs-dev] [PATCH 1/1] Option to toggle "Require successful LACP negotiation when configured"

2013-08-28 Thread Ravi Kondamuru
Hi Ethan, Did you get a chance to review this patch? Thanks, Ravi. On 7/16/13 2:51 PM, "Ethan Jackson" wrote: >> Does that make sense? > >Yep this is pretty much what I was looking for -- a reasonable >explanation of why we should include the feature. In the patch you've >submitted, would you p

[ovs-dev] [PATCH v2] ofproto-dpif-upcall: Batch upcalls.

2013-08-28 Thread Jarno Rajahalme
Batching reduces overheads and enables upto 4 times the upcall processing performance in a specialized test case. Signed-off-by: Jarno Rajahalme --- v2: Do not wake consumer threads if they are already keeping the queue level low enough. Be more conservative about locking while cond_signa

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Batch upcalls.

2013-08-28 Thread Ben Pfaff
On Aug 28, 2013 11:54 AM, "Jarno Rajahalme" wrote: > > > On Aug 28, 2013, at 9:39 AM, Jarno Rajahalme wrote: > >> One specific race that I was concerned about is: > >> > >> 1. This code in udpif_miss_handler() checks n_upcalls and sees that it > >> is zero. > >> > >> if (!handler->n_upcall

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Batch upcalls.

2013-08-28 Thread Jarno Rajahalme
On Aug 28, 2013, at 9:39 AM, Jarno Rajahalme wrote: >> One specific race that I was concerned about is: >> >> 1. This code in udpif_miss_handler() checks n_upcalls and sees that it >> is zero. >> >> if (!handler->n_upcalls) { >> >> 2. This code in recv_upcalls() signals wake_cond: >> >

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Batch upcalls.

2013-08-28 Thread Jarno Rajahalme
On Aug 27, 2013, at 11:02 PM, Ben Pfaff wrote: > On Tue, Aug 27, 2013 at 03:50:06PM -0700, Jarno Rajahalme wrote: >> >> On Aug 27, 2013, at 3:13 PM, Ben Pfaff wrote: >> >>> On Tue, Aug 27, 2013 at 03:04:54PM -0700, Jarno Rajahalme wrote: Batching reduces overheads and enables upto 4 time

[ovs-dev] [RFC PATCH net-next 3/4] tunnels: harmonize cleanup done on skb on xmit path

2013-08-28 Thread Nicolas Dichtel
The goal of this patch is to harmonize cleanup done on a skbuff on xmit path. Before this patch, behaviors were different depending of the tunnel type. Signed-off-by: Nicolas Dichtel --- drivers/net/vxlan.c | 3 ++- include/net/ip6_tunnel.h| 1 - include/net/ip_tunnels.h| 2 +- n

[ovs-dev] [RFC PATCH net-next 4/4] tunnels: harmonize cleanup done on skb on rx path

2013-08-28 Thread Nicolas Dichtel
The goal of this patch is to harmonize cleanup done on a skbuff on rx path. Before this patch, behaviors were different depending of the tunnel type. Signed-off-by: Nicolas Dichtel --- include/net/dst.h | 12 +++- net/ipv4/ip_tunnel.c | 3 +-- net/ipv4/ipmr.c | 3 +-- net/ip

[ovs-dev] [RFC PATCH net-next 0/4] tunnels: harmonize skb scrubbing during encapsulation/decapsulation

2013-08-28 Thread Nicolas Dichtel
We talk recently about harmonizing tunnels so they behave consistently wrt. SKB orphaning, cleaning netfilter state, etc. The goal of this serie is to achieve this. Note that I only made some basic tests with ipip, sit and ip6_tunnels modules. drivers/net/vxlan.c | 4 ++-- include/linux

[ovs-dev] [RFC PATCH net-next 2/4] skb: allow skb_scrub_packet() to be used by tunnels

2013-08-28 Thread Nicolas Dichtel
This function was only used when a packet was sent to another netns. Now, it can also be used after tunnel encapsulation or decapsulation. Only skb_orphan() should not be done when a packet is not crossing netns. Signed-off-by: Nicolas Dichtel --- include/linux/skbuff.h | 2 +- net/core/dev.c

[ovs-dev] [RFC PATCH net-next 1/4] iptunnels: remove net arg from iptunnel_xmit()

2013-08-28 Thread Nicolas Dichtel
This argument is not used, let's remove it. Signed-off-by: Nicolas Dichtel --- drivers/net/vxlan.c | 3 +-- include/net/ip_tunnels.h| 3 +-- net/ipv4/ip_tunnel.c| 3 +-- net/ipv4/ip_tunnel_core.c | 3 +-- net/ipv6/sit.c | 4 ++-- net/openvswitch/vport-gre.c | 2

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Batch upcalls.

2013-08-28 Thread Ben Pfaff
Which race? The one that I described as maybe not possible (do you see how?) Or some other race? On Aug 27, 2013 11:48 PM, "Ethan Jackson" wrote: > I'm happy with it as long as we fix the race. > > Ethan > > On Tue, Aug 27, 2013 at 11:02 PM, Ben Pfaff wrote: > > On Tue, Aug 27, 2013 at 03:50:06P

Re: [ovs-dev] [LNG] Re: [ovs-discuss] OVS Support for RT Kernel

2013-08-28 Thread Viresh Kumar
On 28 August 2013 05:48, Jesse Gross wrote: > The implementation is actually pretty much exactly the same as before. > The only reason why there are no longer separate process/interrupt > counters is because we started disabling bottom halves when processing > packets for userspace. However, with

Re: [ovs-dev] [LNG] Re: datapath: remove HAVE_MAC_RAW

2013-08-28 Thread Viresh Kumar
On 28 August 2013 05:37, Jesse Gross wrote: > On Tue, Aug 27, 2013 at 3:51 AM, Viresh Kumar wrote: >> On 26 August 2013 21:59, Jesse Gross wrote: >> >>> This is compatibility code for older kernels so by definition it >>> doesn't exist in current kernels. You can't just remove it. >> >> My mista

Re: [ovs-dev] Recirculation with milti-threaded miss handling

2013-08-28 Thread Simon Horman
Hi Ethan, On Wed, Aug 28, 2013 at 12:25:31AM -0700, Ethan Jackson wrote: > > In short, it would make my life much easier if facets could be looked up > > execute_flow_miss(). And I am interested to know if you have any plans in > > that regards. > > This actually is in the exact opposite of the d

[ovs-dev] [PATCH] stop overriding patch vport type with dummy

2013-08-28 Thread YAMAMOTO Takashi
there's little point to override patch ports, which is implmeneted purely in our userlang process these days, with a dummy implementation. this allows testing patch ports in "make sandbox" environment. Signed-off-by: YAMAMOTO Takashi --- lib/netdev-dummy.c | 3 +++ 1 file changed, 3 insertions(

Re: [ovs-dev] Recirculation with milti-threaded miss handling

2013-08-28 Thread Ethan Jackson
> In short, it would make my life much easier if facets could be looked up > execute_flow_miss(). And I am interested to know if you have any plans in > that regards. This actually is in the exact opposite of the direction I'm planning to move. Facets don't scale to tens of thousands of datapath

Re: [ovs-dev] [PATCH v2.38 0/6] MPLS actions and matches

2013-08-28 Thread Simon Horman
On Fri, Aug 23, 2013 at 01:16:50PM +1000, Simon Horman wrote: > Hi, > > This series implements MPLS actions and matches based on work by > Ravi K, Leo Alterman, Yamahata-san and Joe Stringer. > > This series provides two changes > > * Provide user-space support for the VLAN/MPLS tag insertion or

[ovs-dev] Recirculation with milti-threaded miss handling

2013-08-28 Thread Simon Horman
Hi Ethan, I am having a bit of difficulty re-implementing portions of my recirculation patchset in order to work in conjunction with your recent change, e1ec7dd ("ofproto-dpif: Implement multi-threaded miss handling.") In short, it would make my life much easier if facets could be looked up execu