Hey Ben, I experimented using Justin's Sparky.~ It is pretty slow. But it makes me feel pretty cool!
The previously failed unit tests all passed. ;D Thanks, On Tue, Aug 27, 2013 at 10:09 PM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Aug 27, 2013 at 04:01:44PM -0700, Alex Wang wrote: > > Thanks for the explanation, that what I need. > > > > Also, one last note: > > > > Should we also do the same thing to the "compose_rarp()" function, in > > lib/packets.c? > > Yes, that is a good idea. I made that change. I'll apply these patches > soon. > > > On Tue, Aug 27, 2013 at 3:52 PM, Ben Pfaff <b...@nicira.com> wrote: > > > > > On Tue, Aug 27, 2013 at 03:48:47PM -0700, Alex Wang wrote: > > > > Both 3/4 and 4/4 look good to me, > > > > > > Thank you for the reviews. > > > > > > > Do we need to strip off the 2 bytes added to the ofpbuf (when > sending the > > > > packets)? > > > > > > No, because the bytes that ofpbuf_reserve() adds aren't part of the > > > data in the ofpbuf. packet->data points past them, not to them, so > > > they won't get sent by anything that looks at the packet data. > > > >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
