Great catch. Also, very cool with sleuthing with your malloc histogram (as
discussed off-list).
Do you think it's worth mentioning in the comment describing xlate_actions()?
Acked-by: Justin Pettit
--Justin
On Aug 19, 2013, at 10:46 PM, Ben Pfaff wrote:
> Every xlate_actions() needs a cor
Every xlate_actions() needs a corresponding xlate_out_uninit(), but the
call in handle_flow_miss() lacked one. struct xlate_out has a built-in
256-byte actions stub, so the bug only showed up for lots of actions.
Bug #19198.
Reported-by: Ronald Lee
Signed-off-by: Ben Pfaff
---
This probably nee
From: Joe Stringer
This patch adds a new compatibility enum for use with MPLS, so that the
differing behaviour between OpenFlow 1.2 and 1.3 can be implemented in
ofproto-dpif-xlate.
Signed-off-by: Joe Stringer
Signed-off-by: Simon Horman
---
v2.36 - v2.37
* No change
v2.35
* First post
---
From: Joe Stringer
This patch adds new ofpact_from_openflow13() and
ofpacts_from_openflow13() functions parallel to the existing ofpact
handling code. In the OpenFlow 1.3 version, push_mpls is handled
differently, but all other actions are handled by the existing code.
For push_mpls, ofpact_push
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Sim
From: Joe Stringer
This patch modifies the push_mpls behaviour to follow the OpenFlow 1.3
specification in the presence of VLAN tagged packets. From the spec:
"Newly pushed tags should always be inserted as the outermost tag in the
outermost valid location for that tag. When a new VLAN tag is pu
From: Joe Stringer
This allows for future patches to pass different tci values to
commit_vlan_action() without passing an entire flow structure.
Signed-off-by: Joe Stringer
Signed-off-by: Simon Horman
---
v2.36 - v2.37
* No change
v2.35
* First post
---
lib/odp-util.c | 12 ++--
From: Joe Stringer
OpenFlow 1.2 and 1.3 differ on their handling of MPLS actions in the
presence of VLAN tags. To allow correct behaviour to be committed in
each situation, this patch adds a second round of VLAN tag action
handling to commit_odp_actions(), which occurs after MPLS actions. This
is
Hi,
This series implements MPLS actions and matches based on work by
Ravi K, Leo Alterman, Yamahata-san and Joe Stringer.
This series provides two changes
* Provide user-space support for the VLAN/MPLS tag insertion order
up to and including OpenFlow 1.2, and the different ordering
specified
On Sat, Aug 03, 2013 at 06:42:06PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
> ---
> ofproto/ofproto-dpif.c | 69
> +++-
> 1 file changed, 51 insertions(+), 18 deletions(-)
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-d
On Aug 19, 2013, at 5:39 PM, Jesse Gross wrote:
> On Mon, Aug 19, 2013 at 5:28 PM, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Thanks, all of these look good to me.
>
> Acked-by: Jesse Gross
Thanks. I pushed them all and removed the line about skb->csum, as you
mentioned in
On Mon, Aug 19, 2013 at 12:00 PM, pritesh wrote:
> Signed-off-by: pritesh
Applied, thanks (I added some detail to the commit message).
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Aug 19, 2013 at 5:28 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Thanks, all of these look good to me.
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Aug 19, 2013 at 5:28 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> datapath/vport-lisp.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
> index 2f62d11..28d3e20 100644
> --- a/datapath/vport-l
Signed-off-by: Justin Pettit
---
datapath/vport.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/datapath/vport.c b/datapath/vport.c
index 03b775d..f26beaf 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -206,7 +206,7 @@ out:
* ovs_vport_set_options - mod
Signed-off-by: Justin Pettit
---
datapath/flow.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/datapath/flow.c b/datapath/flow.c
index 4075350..9a1e01c 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -799,7 +799,6 @@ invalid:
* Ethernet header
* @in_port: port
Signed-off-by: Justin Pettit
---
datapath/vport-lisp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
index 2f62d11..28d3e20 100644
--- a/datapath/vport-lisp.c
+++ b/datapath/vport-lisp.c
@@ -211,7 +211,7 @@ static void lisp
We currently do not recycle ofport numbers from interfaces that are recently
deleted by maintaining the maximum allocated ofport value and
allocating new ofport numbers greater than the previous maximum.
But after a restart of ovs-vswitchd, we start again from ofport value of '1'.
This means that a
It looks correct to me. Ben, would you please consider committing it?
Acked-by: Andy Zhou
git am reported a white space error: patch:28: trailing whitespace.
if (is_mask && ntohs(src_flow->dl_type) < 1536 &&
warning: 1 line adds whitespace errors.
I'd like to further improving the patc
Acked-by: Ethan Jackson
On Mon, Aug 19, 2013 at 10:26 AM, Ben Pfaff wrote:
> dpif_sflow_set_options() uses xcalloc() to allocate space for the SFLAgent
> structure, but nothing ever freed it. This fixes the problem.
>
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-
Hey Ben,
Just noticed, when compiling with sparse, it issues the warnings like:
"""
lib/netdev-linux.c:76:1: warning: symbol 'counter_netdev_set_policing' was
not declared. Should it be static?
lib/netdev-linux.c:77:1: warning: symbol 'counter_netdev_arp_lookup' was
not declared. Should it be sta
Signed-off-by: pritesh
---
datapath/flow.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath/flow.c b/datapath/flow.c
index 4075350..3b3e0aa 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -1202,7 +1202,7 @@ int ovs_ipv4_tun_from_nlattr(const struct nlattr
dpif_sflow_set_options() uses xcalloc() to allocate space for the SFLAgent
structure, but nothing ever freed it. This fixes the problem.
Found by valgrind.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif-sflow.c |1 +
1 file changed, 1 insertion(+)
diff --git a/ofproto/ofproto-dpif-sflo
On Mon, Aug 19, 2013 at 4:48 AM, James Page wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Hi Folks
>
> Ubuntu Saucy is going to ship the 3.11 kernel; I'd only just got
> caught up with backporting the 3.10 patch from the master branch to
> ovs 1.10 and everything broke again...
>
This looks good to me,
The only issue may be that some comments need to be changed:
-/* Sorts coverage counters in descending order by count, within equal
counts
- * alphabetically by name. */
+/* Sorts coverage counters in descending order by total count,
+ * within equal total counts alphabetic
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi Folks
Ubuntu Saucy is going to ship the 3.11 kernel; I'd only just got
caught up with backporting the 3.10 patch from the master branch to
ovs 1.10 and everything broke again...
Anyway - digging through the kernel source I noticed that it looks
Commit 1514b275 introduces the use of atomic_read_explicit for
once-only initializers. When using C11 atomics this becomes
atomic_load_explicit, and the first argument needs to be non-const --
with FreeBSD HEAD's in-tree clang 3.3 the build fails for me with:
In file included from lib/bfd.c:34:
./
27 matches
Mail list logo
