Acked-by: Ethan Jackson <et...@nicira.com>
On Mon, Aug 19, 2013 at 10:26 AM, Ben Pfaff <b...@nicira.com> wrote:
> dpif_sflow_set_options() uses xcalloc() to allocate space for the SFLAgent
> structure, but nothing ever freed it. This fixes the problem.
>
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> ofproto/ofproto-dpif-sflow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ofproto/ofproto-dpif-sflow.c b/ofproto/ofproto-dpif-sflow.c
> index b387b94..44ad927 100644
> --- a/ofproto/ofproto-dpif-sflow.c
> +++ b/ofproto/ofproto-dpif-sflow.c
> @@ -280,6 +280,7 @@ dpif_sflow_clear__(struct dpif_sflow *ds)
> OVS_REQUIRES(mutex)
> {
> if (ds->sflow_agent) {
> sfl_agent_release(ds->sflow_agent);
> + free(ds->sflow_agent);
> ds->sflow_agent = NULL;
> }
> collectors_destroy(ds->collectors);
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
