On Jul 2, 2013, at 7:11 PM, Ben Pfaff wrote:
> On Tue, Jul 02, 2013 at 06:27:18PM -0700, Justin Pettit wrote:
>> From: Jarno Rajahalme
>>
>> Do not clear tunnel metadata on tunnel input.
>>
>> This is a backport of 4110a57 (Keep all of tunnel metadata in
>> flow.) to branch-1.10. This fixes
On Tue, Jul 02, 2013 at 06:27:18PM -0700, Justin Pettit wrote:
> From: Jarno Rajahalme
>
> Do not clear tunnel metadata on tunnel input.
>
> This is a backport of 4110a57 (Keep all of tunnel metadata in
> flow.) to branch-1.10. This fixes an issue with received tunnel
> traffic and megaflows.
For non-Ethernet II packets, we don't set an EtherType netlink attribute
and set the Ethertype mask attribute to 0x. The code was encoding
whatever mask was passed in, which could lead to bugs if the caller
didn't know the userspace-kernel interface.
Found by inspection.
Signed-off-by: Justi
Signed-off-by: Justin Pettit
---
lib/odp-util.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index c05664c..b233cbe 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1058,7 +1058,7 @@ format_odp_key_attr(const struct nlattr *a, const
On Tue, Jul 02, 2013 at 02:59:51PM -0700, Jesse Gross wrote:
> On Mon, Jul 1, 2013 at 9:16 PM, Simon Horman wrote:
> > On Mon, Jul 01, 2013 at 04:42:46PM -0700, Jesse Gross wrote:
> >> On Wed, Jun 26, 2013 at 1:18 AM, Simon Horman wrote:
> >> > Allow datapath to recognize and extract MPLS labels
From: Jarno Rajahalme
Do not clear tunnel metadata on tunnel input.
This is a backport of 4110a57 (Keep all of tunnel metadata in
flow.) to branch-1.10. This fixes an issue with received tunnel
traffic and megaflows. xlate_actions() calls tnl_port_should_receive()
to determine whether it shoul
On Thu, Jun 27, 2013 at 5:10 PM, Ben Pfaff wrote:
>
> -while (!ds_get_preprocessed_line(&s, stream)) {
> +line_number = 0;
> +while (!ds_get_preprocessed_line(&s, stream, &line_number)) {
> +char *error;
> +
> if (*n_fms >= allocated_fms) {
> *fms = x2nrea
Thanks.
On Tue, Jul 2, 2013 at 5:08 PM, Jesse Gross wrote:
> No, I can fix it. I just wanted to make sure.
>
> On Tue, Jul 2, 2013 at 4:31 PM, Andy Zhou wrote:
> > Sorry, I misread the jhash2 prototype. Do you need v2 patch?
> >
> >
> > On Tue, Jul 2, 2013 at 4:05 PM, Jesse Gross wrote:
> >>
No, I can fix it. I just wanted to make sure.
On Tue, Jul 2, 2013 at 4:31 PM, Andy Zhou wrote:
> Sorry, I misread the jhash2 prototype. Do you need v2 patch?
>
>
> On Tue, Jul 2, 2013 at 4:05 PM, Jesse Gross wrote:
>>
>> On Tue, Jul 2, 2013 at 3:58 PM, Andy Zhou wrote:
>> > diff --git a/datapat
Thanks Neil. I'm on vacation this week but I'll look at this when I get
back next week.
On Jul 2, 2013 5:55 PM, "Neil Mckee" wrote:
> OK, here's how it looks now (against latest master). I wasn't sure where
> to add the NEWS item so I just guessed.
>
> Signed-off-by: Neil McKee
>
> ---
> NEWS
Hey Ben,
Have comments inline,
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
> index 0677202..e66987c 100644
> --- a/lib/meta-flow.c
> +++ b/lib/meta-flow.c
> @@ -2699,21 +2699,22 @@ mf_parse_subfield__(struct mf_subfield *sf, const
> char **sp)
> /* Parses a subfield from the beginning of 's'
Sorry, I misread the jhash2 prototype. Do you need v2 patch?
On Tue, Jul 2, 2013 at 4:05 PM, Jesse Gross wrote:
> On Tue, Jul 2, 2013 at 3:58 PM, Andy Zhou wrote:
> > diff --git a/datapath/tunnel.c b/datapath/tunnel.c
> > index 9102786..18c3622 100644
> > --- a/datapath/tunnel.c
> > +++ b/data
On Tue, Jul 2, 2013 at 3:58 PM, Andy Zhou wrote:
> diff --git a/datapath/tunnel.c b/datapath/tunnel.c
> index 9102786..18c3622 100644
> --- a/datapath/tunnel.c
> +++ b/datapath/tunnel.c
> @@ -186,7 +186,9 @@ u16 ovs_tnl_get_src_port(struct sk_buff *skb)
> int low;
> int high;
>
From: Isaku Yamahata
Date: Tue, 2 Jul 2013 20:30:10 +0900
> The dev_forward_skb() assignment of pkt_type should be done
> after the call to eth_type_trans().
>
> ip-encapsulated packets can be handled by localhost. But skb->pkt_type
> can be PACKET_OTHERHOST when packet comes via veth into ip t
On Tue, Jul 2, 2013 at 3:44 PM, Pravin B Shelar wrote:
> Flow dump operation is read-only operation. There is no need to
> take ovs-lock. Following patch use rcu-lock for dumping flows.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
X-CudaMail-Whitelist-To: dev@openvswitch.org
_
Tunnel source port selection was based on hash value cached in the
flow. This no longer works with mega flow, since all flows matching
a mega flow will be transmitted with the same tunnel source port.
This patch computes the tunnel source port at run time based on each
incoming packet. Packets bel
On Tue, Jun 11, 2013 at 10:35 PM, Joe Stringer wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index 0dac658..d4fdd65 100644
> --- a/datapath/actions.c
> +++ b/datapath/actions.c
> +static int set_sctp(struct sk_buff *skb,
> +const struct ovs_key_sctp *sctp_port
Flow dump operation is read-only operation. There is no need to
take ovs-lock. Following patch use rcu-lock for dumping flows.
Signed-off-by: Pravin B Shelar
---
v1-v2:
- Fix rcu annotations.
---
datapath/datapath.c | 22 --
1 files changed, 12 insertions(+), 10 deletion
Accepted:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Format: 1.8
Date: Sat, 29 Jun 2013 17:34:59 +
Source: openvswitch
Binary: openvswitch-datapath-source openvswitch-datapath-dkms
openvswitch-common openvswitch-switch openvswitch-ipsec openvswitch-pki
openvswitch-controller openvswitc
On Mon, Jul 1, 2013 at 9:16 PM, Simon Horman wrote:
> On Mon, Jul 01, 2013 at 04:42:46PM -0700, Jesse Gross wrote:
>> On Wed, Jun 26, 2013 at 1:18 AM, Simon Horman wrote:
>> > Allow datapath to recognize and extract MPLS labels into flow keys
>> > and execute actions which push, pop, and set labe
OK, here's how it looks now (against latest master). I wasn't sure where to
add the NEWS item so I just guessed.
Signed-off-by: Neil McKee
---
NEWS | 2 ++
vswitchd/bridge.c | 11 +++
vswitchd/vswitch.ovsschema | 7 +--
vswitchd/vswitch.xml
On Sun, 2013-06-30 at 01:43 +0800, Thomas Goirand wrote:
> On 06/30/2013 01:11 AM, Adam D. Barratt wrote:
> > Yes, but please either adjust the version to be -9+deb7u1 or include the
> > -9.1 changelog and make the stable stanza a "rebuild for wheezy" or
> > something similar.
>
> Done and uploade
On Tue, Jul 2, 2013 at 12:57 PM, Jesse Gross wrote:
> On Tue, Jul 2, 2013 at 11:24 AM, Pravin B Shelar wrote:
>> Flow dump operation is read-only operation. There is no need to
>> take ovs-lock. Following patch use rcu-lock for dumping flows.
>>
>> Signed-off-by: Pravin B Shelar
>
> This doesn
On Mon, Jul 1, 2013 at 7:29 PM, Andy Zhou wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 3680391..0ac46d0 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -1353,12 +1353,14 @@ static int ovs_flow_cmd_new_or_set(struct sk_buff
> *skb, struct genl_info *i
On Tue, Jul 2, 2013 at 11:24 AM, Pravin B Shelar wrote:
> Flow dump operation is read-only operation. There is no need to
> take ovs-lock. Following patch use rcu-lock for dumping flows.
>
> Signed-off-by: Pravin B Shelar
This doesn't show up in the diff but we use ovsl_dereference() both in
t
On Tue, Jul 2, 2013 at 12:13 AM, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Jul 2, 2013, at 1:28 , ext Pravin B Shelar wrote:
>
>> diff --git a/datapath/linux/compat/include/net/vxlan.h
>> b/datapath/linux/compat/include/net/vxlan.h
>> new file mode 100644
>> index 000..76e0ddb
>> --- /d
Flow dump operation is read-only operation. There is no need to
take ovs-lock. Following patch use rcu-lock for dumping flows.
Signed-off-by: Pravin B Shelar
---
datapath/datapath.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/datapath/datapath.c b/datapath/dat
Thanks for the patch. I'll apply this next week when I get back from
vacation.
On Jul 1, 2013 9:32 AM, "Jarno Rajahalme" wrote:
> Ben noticed that I had forgot to free meters when ofproto is freed.
> This should do it.
>
> Signed-off-by: Jarno Rajahalme
> ---
> ofproto/ofproto.c | 33
Hi Linda. Thanks for the patch! I'm on vacation this week but I'll take a
serious look at this patch when I get back next week.
On Jul 1, 2013 1:41 PM, "Linda Sun" wrote:
> to allow it to work on non-gnu compiler.
>
> Signed-off-by: Linda Sun
>
> diff --git a/lib/cfm.c b/lib/cfm.c
> index 1c98ed
The dev_forward_skb() assignment of pkt_type should be done
after the call to eth_type_trans().
ip-encapsulated packets can be handled by localhost. But skb->pkt_type
can be PACKET_OTHERHOST when packet comes via veth into ip tunnel device.
In that case, the packet is dropped by ip_rcv().
Although
Hi,
How does openvswitch handle router functionality??? I see whenever we do
dump-flows its shows all the flows belong to same subnet if it is with one
interface. Can we ping to machines connected to 2 different subnets via
openvswitch ?? I mean does it store routing entries and acts as a L3 switc
On Jul 2, 2013, at 1:28 , ext Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/net/vxlan.h
> b/datapath/linux/compat/include/net/vxlan.h
> new file mode 100644
> index 000..76e0ddb
> --- /dev/null
> +++ b/datapath/linux/compat/include/net/vxlan.h
> @@ -0,0 +1,43 @@
> +#ifn
32 matches
Mail list logo
