On Tue, Jul 2, 2013 at 12:57 PM, Jesse Gross <je...@nicira.com> wrote: > On Tue, Jul 2, 2013 at 11:24 AM, Pravin B Shelar <pshe...@nicira.com> wrote: >> Flow dump operation is read-only operation. There is no need to >> take ovs-lock. Following patch use rcu-lock for dumping flows. >> >> Signed-off-by: Pravin B Shelar <pshe...@nicira.com> > > This doesn't show up in the diff but we use ovsl_dereference() both in > this function and in ovs_flow_cmd_fill_info(), which I think will > cause lockdep to complain since we're no longer holding the OVS mutex. > > It might make sense to make all of the dump and get operations behave > the same, mostly for the sake of consistency. After this we have: > - DP get: OVS mutex > - DP dump: OVS mutex > - port get: RCU > - port dump: RCU > - flow get: OVS mutex > - flow dump: RCU > ok.
> I think the main disadvantage to using RCU is that during gets we have > to either use GFP_ATOMIC or restructure the way we allocate memory > somewhat. Maybe we should just make the dump operations use RCU and > the gets use OVS mutex. ok. I will send separate patches for each operation changed. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
