[ovs-dev] about controller configuration

2013-06-04 Thread Yong sheng Gong
Hi, Why do we need ptcp: and tcp:? ptcp: the bridge is listening, tcp: the bridge is trying to connect. why isn't one of them enough? Thanks yong sheng gong set−controller bridge target... Sets the configured controller target or targets. Each target may use any of the following forms: ss

[ovs-dev] setting Openflow Protocol version in opevswitch

2013-06-04 Thread Nikhil
Hi, I am not able to set the version of ovs to be compatible with of1.2 & of 1.3 using *sudo ovs-vsctl set Bridge A1 protocols=OpenFlow12,OpenFlow13,OpenFlow10* * * "The error i am getting is that there is no row called protocols in Bridge table" vm:~/ryu/bin$ ovs-vsctl --version ovs-vsctl (Open

[ovs-dev] [PATCH 2/2] ofproto: Track subfacet stats in the backer.

2013-06-04 Thread Ethan Jackson
Subfacets being per-datapath entities, their statistics are really only interesting at per-datapath granularity. This patch moves them to the dpif_backer and makes some related simplifications. Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif-unixctl.man |6 +- ofproto/ofproto-dpif.c

[ovs-dev] [PATCH 1/1] Fix misspellings in comments and docs.

2013-06-04 Thread Andy Hill
Flagged with: https://github.com/lyda/misspell-check Run with: git ls-files | misspellings -f - Signed-off-by: Andy Hill --- 0001-Fix-misspellings-in-comments-and-docs.patch Description: Binary data ___ dev mailing list dev@openvswitch.org http://ope

Re: [ovs-dev] [PATCH v2]: ofp-actions: check table_id in goto_table instruction is larger than the current table_id

2013-06-04 Thread Jing Ai
Sorry for the inconvenience on patch formatting. I just created a repo at github based on your suggestion. You can find my patch at https://github.com/jingairpi/openvswitch/commit/646a35a763b73709cbc7ffdb99450fb94e124ff1 . Best, Jing On Tue, Jun 4, 2013 at 1:33 PM, Ben Pfaff wrote: > On Tue,

Re: [ovs-dev] Support for LISP Control Plane

2013-06-04 Thread Vina Ermagan (vermagan)
Hi All, I am collaborating with Kyle and Lori on the LISP implementation in OVS. We are planing to start work on the LISP control plane in OVS, and it would be great if we can get some early feedback on the approach. There are a few options that I described below. Please let us know if you have

Re: [ovs-dev] [PATCH V4] ofproto-dpif.c: Modify vsp_realdev_to_vlandev() function

2013-06-04 Thread Alex Wang
Hey Ben, I found in that the "send_packet()" function in branch-1.10 also invokes the "realdev_to_vlandev()" function. @@ -5743,8 +5744,10 @@ send_packet(const struct ofport_dpif *ofport, struct ofpbuf *packet) odp_put_tunnel_action(&flow.tunnel, &odp_actions); odp_put_skb_mark_

[ovs-dev] [PATCH v4] gre: Restructure tunneling.

2013-06-04 Thread Pravin B Shelar
Following patch restructures ovs tunneling and gre vport implementation to make ovs tunneling more in sync with upstream kernel tunneling. Doing this tunneling code is simplified as most of protocol processing on send and recv is pushed to kernel tunneling. For external ovs module the code is mov

Re: [ovs-dev] [PATCH v2]: ofp-actions: check table_id in goto_table instruction is larger than the current table_id

2013-06-04 Thread Jing Ai
No problem. I just pinged the thread to get attention. Thanks for your review. Here I attached the patch regenerated by "git format-patch". Signed-off-by: Jing Ai --- AUTHORS | 3 ++- lib/ofp-actions.c | 5 + lib/ofp-actions.h | 1 + lib/ofp-util.c| 8 +-

Re: [ovs-dev] [PATCH V1] bridge.c: Change variable "ofport" type in "struct if_cfg" and "struct iface"

2013-06-04 Thread Alex Wang
Thanks for this useful tip! On Tue, Jun 4, 2013 at 11:01 AM, Ben Pfaff wrote: > On Tue, Jun 04, 2013 at 10:35:03AM -0700, Alex Wang wrote: > > On Tue, Jun 4, 2013 at 10:17 AM, Ben Pfaff wrote: > > > Second, iface_configure_qos() tests ->ofp_port for >= 0, which no > > > longer makes sense. I

Re: [ovs-dev] [PATCH V1] bridge.c: Change variable "ofport" type in "struct if_cfg" and "struct iface"

2013-06-04 Thread Alex Wang
Thanks Ben, This patch is more for making my ofp/odp naming project easier. I'll post a V2 of it. On Tue, Jun 4, 2013 at 10:17 AM, Ben Pfaff wrote: > On Fri, May 31, 2013 at 04:04:45PM -0700, Alex Wang wrote: > > This patch changes the variable type of "ofport" in "struct if_cfg" and > > "struc

Re: [ovs-dev] [PATCH v2]: ofp-actions: check table_id in goto_table instruction is larger than the current table_id

2013-06-04 Thread Jing Ai
Anyone reviewing it? Thanks! Best, Jing On Fri, May 31, 2013 at 5:46 PM, Jing Ai wrote: > --- Resent the patch since the last one was messed up in format > --- Added and changed AUTHOR information > > Found a bug that OVS does not return any error message when the > goto_table_id is smaller th

Re: [ovs-dev] [PATCH] cfm: Update netdev when changed.

2013-06-04 Thread Ben Pfaff
On Mon, Jun 03, 2013 at 01:51:58PM -0700, Ethan Jackson wrote: > If ofproto decided to change the netdev of a particular ofport, > cfm_demand mode would improperly continue using the old netdev to > collect stats. > > Bug #17583. > Signed-off-by: Ethan Jackson The refcounting saved us here. Wit

Re: [ovs-dev] [PATCH] testsuite: make a sed command more portable

2013-06-04 Thread Ben Pfaff
On Tue, Jun 04, 2013 at 09:17:34AM +0900, YAMAMOTO Takashi wrote: > avoid using some GNU sed extensions, which are not available > eg. on NetBSD's /usr/bin/sed. > > while there are other places these extenstions are used in the testsuite, > this instance is new and seems the only one currently bei

Re: [ovs-dev] [PATCH 2/2] signals: Make signal_name() thread-safe.

2013-06-04 Thread Alex Wang
Looks good to me. Thanks On Wed, May 1, 2013 at 11:25 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/fatal-signal.c |4 +++- > lib/process.c | 10 -- > lib/signals.c | 29 +++-- > lib/signals.h |4 +++- > 4 files changed,

Re: [ovs-dev] [PATCH 1/2] signals: Use sys_siglist[] instead of strsignal() for thread-safety.

2013-06-04 Thread Alex Wang
Looks good to me. Thanks On Wed, May 1, 2013 at 11:25 AM, Ben Pfaff wrote: > strsignal() isn't thread-safety but sys_siglist[] is. Also, according to > the glibc manual, BSD has sys_siglist[] but not strsignal(). > > Signed-off-by: Ben Pfaff > --- > configure.ac |3 ++- > lib/signals.c