Re: [ovs-dev] [PATCH 00/13] NetBSD support

On Wed, May 22, 2013 at 09:05:27PM -0700, Ben Pfaff wrote: > On Tue, May 21, 2013 at 08:08:18AM -0700, Ben Pfaff wrote: > > On Tue, May 21, 2013 at 05:49:52PM +0900, y...@mwd.biglobe.ne.jp wrote: > > > From: YAMAMOTO Takashi > > > > > > NetBSD support patch set rebased today > > > > Thanks. If

[ovs-dev] [includes 04/11] vlog: Remove unneeded #includes.

Signed-off-by: Ben Pfaff --- lib/entropy.c |4 +++- lib/leak-checker.c|3 ++- lib/stream-provider.h |1 + lib/vlog.c|2 -- lib/vlog.h|2 -- vswitchd/xenserver.c |3 ++- 6 files changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/

[ovs-dev] [includes 03/11] ofp-print: Remove unneeded #includes.

Signed-off-by: Ben Pfaff --- lib/ofp-print.c |8 lib/ofp-print.h |4 +--- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/lib/ofp-print.c b/lib/ofp-print.c index e899df3..e3a70ab 100644 --- a/lib/ofp-print.c +++ b/lib/ofp-print.c @@ -17,23 +17,17 @@ #include #in

[ovs-dev] [includes 02/11] ofp-parse: Remove unneeded #includes.

Signed-off-by: Ben Pfaff --- lib/ofp-parse.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c index 1c5c761..f07cce6 100644 --- a/lib/ofp-parse.c +++ b/lib/ofp-parse.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2010, 2011, 2012 Nicira, Inc. +

[ovs-dev] [includes 01/11] ofp-util: Remove unneeded #includes.

Signed-off-by: Ben Pfaff --- lib/learn.c|4 +++- lib/ofp-util.c | 14 ++ lib/ofp-util.h |5 + 3 files changed, 6 insertions(+), 17 deletions(-) diff --git a/lib/learn.c b/lib/learn.c index ab403be..1ccdfb3 100644 --- a/lib/learn.c +++ b/lib/learn.c @@ -1,5 +1,5 @@

[ovs-dev] [includes 00/11] Remove unneeded #includes.

I did a partial audit of #include directives in headers and source files. This series removes some unnecessary #includes. (Sometimes, when header A #includes header B, but A does not use anything from B, there still can be some source file C that includes A and expects everything frmo B to be ava

[ovs-dev] [includes 10/11] Remove unneeded inclusions of classifier.h.

Signed-off-by: Ben Pfaff --- lib/learning-switch.c |3 +-- ofproto/connmgr.h |1 - ofproto/fail-open.c |3 +-- ofproto/in-band.c |3 +-- tests/test-flows.c|3 +-- 5 files changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/learning-switch.c b/lib/learning-

[ovs-dev] [includes 11/11] Remove unneeded inclusions of util.h.

--- lib/dynamic-string.c |1 - lib/hash.c |1 + lib/hash.h |1 - lib/ofp-msgs.h |1 - lib/ofp-print.c |1 - lib/ofpbuf.c |1 - lib/unaligned.h |3 +-- 7 files changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/dynamic-

[ovs-dev] [includes 06/11] ofpbuf: Remove unneeded #includes.

Signed-off-by: Ben Pfaff --- lib/ofpbuf.h |2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h index 8b03c7e..91e4c85 100644 --- a/lib/ofpbuf.h +++ b/lib/ofpbuf.h @@ -18,9 +18,7 @@ #define OFPBUF_H 1 #include -#include #include "list.h" -#include "util.h"

[ovs-dev] [includes 05/11] ofp-parse: Remove unneeded #include.

Signed-off-by: Ben Pfaff --- lib/ofp-parse.c |1 - 1 file changed, 1 deletion(-) diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c index f07cce6..cc4db78 100644 --- a/lib/ofp-parse.c +++ b/lib/ofp-parse.c @@ -33,7 +33,6 @@ #include "ofp-util.h" #include "ofpbuf.h" #include "openflow/openflow

[ovs-dev] [includes 07/11] meta-flow: Remove unneeded #includes.

Signed-off-by: Ben Pfaff --- lib/meta-flow.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 54bc4c2..dcc5c85 100644 --- a/lib/meta-flow.c +++ b/lib/meta-flow.c @@ -23,15 +23,13 @@ #include #include -#include "classifier.h" +

[ovs-dev] [includes 08/11] bundle: Remove unneeded #include.

Signed-off-by: Ben Pfaff --- lib/bundle.c |1 - 1 file changed, 1 deletion(-) diff --git a/lib/bundle.c b/lib/bundle.c index 92ac1e1..ba5c2c2 100644 --- a/lib/bundle.c +++ b/lib/bundle.c @@ -21,7 +21,6 @@ #include #include "dynamic-string.h" -#include "multipath.h" #include "meta-flow.

[ovs-dev] [includes 09/11] nx-match: Remove unneeded #includes.

Signed-off-by: Ben Pfaff --- lib/nx-match.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/nx-match.c b/lib/nx-match.c index a91d56b..916d00d 100644 --- a/lib/nx-match.c +++ b/lib/nx-match.c @@ -20,7 +20,7 @@ #include -#include "classifier.h" +#include "byte-

[ovs-dev] [PATCH] ofp-errors: Add missing copyright and license notice.

Signed-off-by: Ben Pfaff --- lib/ofp-errors.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/ofp-errors.c b/lib/ofp-errors.c index f2a9e8c..74a3358 100644 --- a/lib/ofp-errors.c +++ b/lib/ofp-errors.c @@ -1,3 +1,19 @@ +/* + * Copyright (c) 2012, 2013 Nicira, Inc. + *

Re: [ovs-dev] [PATCH] lib/dpif-netdev.c: Fix the flow in_port bound checking

On Wed, May 22, 2013 at 09:27:29PM -0700, Alex Wang wrote: > This commit fixes the flow in_port bound checking in the function > "dpif_netdev_flow_from_nlattrs()". > > Signed-off-by: Alex Wang Justin, will you review this? My impression is that it is a leftover from the single datapath changes

Re: [ovs-dev] [PATCH v2] gre: Restructure tunneling.

On Wed, May 22, 2013 at 8:16 PM, Jesse Gross wrote: > On Wed, May 22, 2013 at 1:20 PM, Pravin Shelar wrote: >> On Tue, May 21, 2013 at 4:39 PM, Jesse Gross wrote: >>> On Mon, May 20, 2013 at 2:33 PM, Pravin B Shelar wrote: Following patch restructures ovs tunneling and gre vport imple

[ovs-dev] [PATCH] lib/dpif-netdev.c: Fix the flow in_port bound checking

This commit fixes the flow in_port bound checking in the function "dpif_netdev_flow_from_nlattrs()". Signed-off-by: Alex Wang --- lib/dpif-netdev.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 4ad2823..4893833 100644 --- a/

Re: [ovs-dev] [PATCH 00/13] NetBSD support

On Tue, May 21, 2013 at 08:08:18AM -0700, Ben Pfaff wrote: > On Tue, May 21, 2013 at 05:49:52PM +0900, y...@mwd.biglobe.ne.jp wrote: > > From: YAMAMOTO Takashi > > > > NetBSD support patch set rebased today > > Thanks. If you'll take a look at my proposal for patch 2, then I'll > take a look at

Re: [ovs-dev] [PATCH 02/13] add minimal NetBSD support

On Tue, May 21, 2013 at 04:34:32PM -0400, Ed Maste wrote: > On 21 May 2013 10:59, Ben Pfaff wrote: > > On Tue, May 21, 2013 at 05:49:54PM +0900, y...@mwd.biglobe.ne.jp wrote: > >> From: YAMAMOTO Takashi > >> > >> mostly ride on the existing FreeBSD support. > >> > >> Signed-off-by: YAMAMOTO Takas

Re: [ovs-dev] [PATCH v2] gre: Restructure tunneling.

On Wed, May 22, 2013 at 1:20 PM, Pravin Shelar wrote: > On Tue, May 21, 2013 at 4:39 PM, Jesse Gross wrote: >> On Mon, May 20, 2013 at 2:33 PM, Pravin B Shelar wrote: >>> Following patch restructures ovs tunneling and gre vport >>> implementation to make ovs tunneling more in sync with >>> upstr

Re: [ovs-dev] [ext-260 v2 3/5] extract-ofp-errors: Remove support for hexadecimal error types.

On Wed, May 22, 2013 at 05:50:24PM -0700, Reid Price wrote: > On Wed, May 22, 2013 at 4:48 PM, Ben Pfaff wrote: > > if not m: > > fatal("%s: syntax error in destination" % dst) > > > Usually I find %r easier to debug with, so you can see funny characters > clea

Re: [ovs-dev] [PATCH v2.29] datapath: Add basic MPLS support to kernel

On Tue, May 21, 2013 at 09:07:06AM -0700, Jesse Gross wrote: > On Mon, May 20, 2013 at 5:55 PM, Simon Horman wrote: > > On Fri, May 17, 2013 at 04:14:56PM -0700, Jesse Gross wrote: > >> On Fri, May 17, 2013 at 12:06 AM, Simon Horman wrote: > >> > +static int push_mpls(struct sk_buff *skb, > >> >

Re: [ovs-dev] [PATCH v2] Always update ethertype on mpls_pop

On Wed, May 15, 2013 at 05:51:15PM +0900, Simon Horman wrote: > On Fri, May 03, 2013 at 08:31:58AM +0900, Simon Horman wrote: > > On Thu, May 02, 2013 at 12:56:37PM -0700, Ben Pfaff wrote: > > > I made the following comment on v1, did you do anything about it? > > > > > > > Also, the action parser

Re: [ovs-dev] [ext-260 v2 3/5] extract-ofp-errors: Remove support for hexadecimal error types.

Couple notes inline On Wed, May 22, 2013 at 4:48 PM, Ben Pfaff wrote: > This feature wasn't used and removing it slightly simplifies the code. > > Signed-off-by: Ben Pfaff > --- > build-aux/extract-ofp-errors | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a

Re: [ovs-dev] [ext-260 v2 0/5] add support for OF1.2+ experimenter error codes

On Wed, May 22, 2013 at 04:48:28PM -0700, Ben Pfaff wrote: > This series adds support for OF1.2+ experimenter error codes. Compared > to v1 of the patch series, it makes it much easier to add new experimenter > IDs and updates the error code used to the one used in the latest version > of the EXT-

[ovs-dev] [ext-260 v2 5/5] ofp-errors: New error code ONFBIC_DUP_INSTRUCTION.

This is a prototype of OpenFlow enhancement proposal EXT-260 "Add error code for duplicate instruction." It uses the error code proposed there. Signed-off-by: Ben Pfaff --- lib/ofp-actions.c|4 +--- lib/ofp-errors.h |3 +++ tests/ofp-actions.at |4 ++-- 3 files changed, 6 in

[ovs-dev] [ext-260 v2 0/5] add support for OF1.2+ experimenter error codes

This series adds support for OF1.2+ experimenter error codes. Compared to v1 of the patch series, it makes it much easier to add new experimenter IDs and updates the error code used to the one used in the latest version of the EXT-260 proposal, using an ONF experimenter ID. This is also available

[ovs-dev] [ext-260 v2 3/5] extract-ofp-errors: Remove support for hexadecimal error types.

This feature wasn't used and removing it slightly simplifies the code. Signed-off-by: Ben Pfaff --- build-aux/extract-ofp-errors | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors index 965e322..32d0913 100

[ovs-dev] [ext-260 v2 4/5] ofp-errors: Implement OpenFlow 1.2+ experimenter error codes.

OpenFlow 1.2 standardized experimenter error codes in a way different from the Nicira extension. This commit implements the OpenFlow 1.2+ version. This commit also makes it easy to add error codes for new experimenter IDs by adding new *_VENDOR_ID definitions to openflow-common.h. Signed-off-by:

[ovs-dev] [ext-260 v2 2/5] ofp-errors: Make ofperr_decode() static.

It had no users outside of ofp-errors.c. Signed-off-by: Ben Pfaff --- lib/ofp-errors.c |2 +- lib/ofp-errors.h |1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ofp-errors.c b/lib/ofp-errors.c index f2a9e8c..e2449b3 100644 --- a/lib/ofp-errors.c +++ b/lib/ofp-errors

[ovs-dev] [ext-260 v2 1/5] ofp-errors: Fix typos in comment.

Signed-off-by: Ben Pfaff --- lib/ofp-errors.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h index 593241d..aa3ba50 100644 --- a/lib/ofp-errors.h +++ b/lib/ofp-errors.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010, 2011,

Re: [ovs-dev] [PATCH net-next v3] net: Loosen constraints for recalculating checksum in skb_segment()

From: Simon Horman Date: Mon, 20 May 2013 10:46:49 +0900 > This is a generic solution to resolve a specific problem that I have observed. > > If the encapsulation of an skb changes then ability to offload checksums > may also change. In particular it may be necessary to perform checksumming > in

Re: [ovs-dev] [PATCH] cfm: Implement "demand mode".

Oops, thanks I've folded that in and will merge shortly. Ethan On Wed, May 22, 2013 at 1:52 PM, Ben Pfaff wrote: > On Wed, May 22, 2013 at 01:35:39PM -0700, Ethan Jackson wrote: >> Here's an incremental. Note that I put the news entry under 1.11 as I intend >> to backport this. > > If you're do

Re: [ovs-dev] [PATCH] cfm: Implement "demand mode".

On Wed, May 22, 2013 at 01:35:39PM -0700, Ethan Jackson wrote: > Here's an incremental. Note that I put the news entry under 1.11 as I intend > to backport this. If you're doing a netdev_ref() then you also need to eventually do a netdev_close(). Otherwise this is fine, thanks. _

Re: [ovs-dev] dev Digest, Vol 46, Issue 129

> On Mon, May 20, 2013 at 06:53:14AM +, Gurucharan Shetty wrote: > > This commit provides an option to enable or disable packet processing > > coming from the datapath. > > > > This option is useful during Open vSwitch upgrades. Typically we want > > to restart openvswitch, add the openflow

Re: [ovs-dev] [PATCH] cfm: Implement "demand mode".

Here's an incremental. Note that I put the news entry under 1.11 as I intend to backport this. --- NEWS |3 ++- lib/cfm.c |6 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 4cb4499..2fd7cb3 100644 --- a/NEWS +++ b/NEWS @@ -5,7 +5,6 @@ post-v1

Re: [ovs-dev] [PATCH v2] gre: Restructure tunneling.

On Tue, May 21, 2013 at 4:39 PM, Jesse Gross wrote: > On Mon, May 20, 2013 at 2:33 PM, Pravin B Shelar wrote: >> Following patch restructures ovs tunneling and gre vport >> implementation to make ovs tunneling more in sync with >> upstream kernel tunneling. Doing this tunneling code is >> simpli

Re: [ovs-dev] [PATCH] netdev: New function netdev_ref().

Applied to master, thanks. On Wed, May 22, 2013 at 10:42:32AM -0700, Ethan Jackson wrote: > LGTM as well. I plan to use this in the CFM patch so please go ahead > and push it. > > Ethan > > On Wed, May 22, 2013 at 8:50 AM, Ben Pfaff wrote: > > Thanks for taking a look. I won't push this unles

Re: [ovs-dev] [PATCH] netdev: New function netdev_ref().

LGTM as well. I plan to use this in the CFM patch so please go ahead and push it. Ethan On Wed, May 22, 2013 at 8:50 AM, Ben Pfaff wrote: > Thanks for taking a look. I won't push this unless Ethan says that he > thinks it is useful for his recent cfm patch. > > I have two perspectives on your

Re: [ovs-dev] [PATCH] netdev: New function netdev_ref().

Thanks for taking a look. I won't push this unless Ethan says that he thinks it is useful for his recent cfm patch. I have two perspectives on your question. The first one is that this situation is analogous to strchr(), which takes a const char * and returns a char *. Its parameter is const be

Re: [ovs-dev] [PATCH next-next v4 1/2] net: Use 16bits for inner_*_headers fields of struct skbuff

On Wed, 2013-05-22 at 09:25 +0200, Pekka Riikonen wrote: > On Wed, 22 May 2013, Simon Horman wrote: > > > include/linux/skbuff.h | 63 > > +++--- > > 1 file changed, 8 insertions(+), 55 deletions(-) > > > > diff --git a/include/linux/skbuff.h b/include/l

Re: [ovs-dev] [PATCH next-next v4 1/2] net: Use 16bits for inner_*_headers fields of struct skbuff

On Wed, 22 May 2013, Simon Horman wrote: include/linux/skbuff.h | 63 +++--- 1 file changed, 8 insertions(+), 55 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 2e0ced1..3791615 100644 --- a/include/linux/skbuff.h +++ b/

[ovs-dev] [PATCH v9 1/6] dpif-netdev: Constify key parameter of dp_netdev_action_userspace()

Signed-off-by: Simon Horman --- v9 * First post --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 78bdedb..86207e9 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -1198,7 +1198,7 @@ dp_netdev_sample(st

[ovs-dev] [PATCH v9 0/6] Add packet recirculation

Recirculation is a technique to allow a frame to re-enter frame processing. This is intended to be used after actions have been applied to the frame with modify the frame in some way that makes it possible for richer processing to occur. An example is and indeed targeted use case is MPLS. If an MP

[ovs-dev] [PATCH v9 6/6] ofproto-dpif: Use execute_actions to execute controller actions

Now that execute_actions() is available it can be used as a generic replacement for special-case action execution in execute_controller_action(). As suggested by Jesse Gross. Signed-off-by: Simon Horman --- v9 * First post --- lib/execute-actions.c | 3 ++- ofproto/ofproto-dpif.c | 46 +

[ovs-dev] [PATCH v9 4/6] Add set skb_mark, set_priority and tunnel support to execute_set_action

Add set skb_mark support to execute_set_action. This also adds support for the user-space datapath to honour such actions if they occur before recirculation, which will be added by a subsequent patch. This is in preparation for using execute_set_action() to handle recirculation. Signed-off-by: Si

[ovs-dev] [PATCH v9 2/6] dpif-netdev: Move decoding of data out of dp_netdev_output_userspace()

This is in preparation for making dp_netdev_action_userspace() more generic and passing dp_netdev_output_userspace() as a callback. In this case it makes sense to decode userdata in generic code. Signed-off-by: Simon Horman --- v9 * First post --- lib/dpif-netdev.c | 13 +++-- 1 file c

[ovs-dev] [PATCH v9 3/6] Add execute_actions

This moves generic action execution code out of lib/dpif-netedev.c and into a new file, lib/execute-actions.c. This is in preparation for using execute_set_action() in lib/odp-util.c to handle recirculation/ Signed-off-by: Simon Horman --- v9 * As suggested by Jesse Gross - Follow the conventi