Couple notes inline
On Wed, May 22, 2013 at 4:48 PM, Ben Pfaff <b...@nicira.com> wrote:
> This feature wasn't used and removing it slightly simplifies the code.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> build-aux/extract-ofp-errors | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors
> <snip>
if not m:
> fatal("%s: syntax error in destination" % dst)
>
Usually I find %r easier to debug with, so you can see funny characters
clearly.
"%r" % (dst, )
is equivalent to
"%s" % (repr(dst), )
> if m.group(3):
> code = int(m.group(3))
> else:
> code = None
>
The current form is fine. You could make it shorter, but I don't like that
the user
would have to know that m.group(X) returns None
code = m.group(4) and int(m.group(4))
-Reid
>
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
