In order to reduce the size of struct skbuff use 16 bit integer
offsets rather than pointers for inner_*_headers.
The implication of this is that the behaviour of
is that of other _headers when NET_SKBUFF_DATA_USES_OFFSET is set.
This appears to reduce the size of struct skbuff from 0xd0 to 0xc8
In the case where a non-MPLS packet is received and an MPLS stack is
added it may well be the case that the original skb is GSO but the
NIC used for transmit does not support GSO of MPLS packets.
The aim of this short series is to provide GSO in software for MPLS packets
whose skbs are GSO.
Simon
In the case where a non-MPLS packet is received and an MPLS stack is
added it may well be the case that the original skb is GSO but the
NIC used for transmit does not support GSO of MPLS packets.
The aim of this code is to provide GSO in software for MPLS packets
whose skbs are GSO.
SKB Usage:
W
Looks good to me. Want to ask what is the tradeoff between using "const
struct netdev" and "struct netdev" as input argument.
Thanks,
On Tue, May 21, 2013 at 3:42 PM, Ben Pfaff wrote:
> I suspect that this makes it easier to make sure that a netdev stays open
> as long as needed in some cases w
On Fri, May 17, 2013 at 01:40:10PM -0700, Jesse Gross wrote:
> On Wed, May 15, 2013 at 1:31 AM, Simon Horman wrote:
> > This moves generic action execution code out of lib/dpif-netedev.c
> > and into a new file, lib/execute-actions.c.
> >
> > This is in preparation for using execute_set_action()
>
On Mon, May 20, 2013 at 2:33 PM, Pravin B Shelar wrote:
> Following patch restructures ovs tunneling and gre vport
> implementation to make ovs tunneling more in sync with
> upstream kernel tunneling. Doing this tunneling code is
> simplified as most of protocol processing on send and
> recv is p
On Mon, May 20, 2013 at 03:57:56PM -0700, Ethan Jackson wrote:
> The new CFM "demand mode" (named after BFD's demand mode) uses
> data traffic to indicate interface liveness. It's helpful on
> heavily congested networks where CCMs may be dropped.
>
> Signed-off-by: Ethan Jackson
Ugh, another CF
I suspect that this makes it easier to make sure that a netdev stays open
as long as needed in some cases where a module needs access to a netdev
opened by some higher-level module.
CC: Ethan Jackson
Signed-off-by: Ben Pfaff
---
lib/netdev.c | 11 +++
lib/netdev.h |1 +
2 files ch
On Mon, May 20, 2013 at 11:17:51AM -0700, Alex Wang wrote:
> Two testcases are added to the testsuite, which test the new
> command syntax and the corresponding corner cases.
>
> Signed-off-by: Alex Wang
Applied to master, thanks.
___
dev mailing list
On Mon, May 20, 2013 at 11:36:05AM -0700, Alex Wang wrote:
> Since the use of single datapath, all bridges belonging to the same type of
> datapath will use the same (single) datapath. This causes confusion in the
> current 'ofproto/trace' command. Especially, when given the unrelated
> 'bridge' an
On 21 May 2013 10:59, Ben Pfaff wrote:
> On Tue, May 21, 2013 at 05:49:54PM +0900, y...@mwd.biglobe.ne.jp wrote:
>> From: YAMAMOTO Takashi
>>
>> mostly ride on the existing FreeBSD support.
>>
>> Signed-off-by: YAMAMOTO Takashi
>
> I'd like to refine this patch a little in the following way (whi
On 21/05/13 18:58, Gurucharan Shetty wrote:
Thank you. I pushed this to master, 1.11, 1.10 and 1.9 branches.
Can you please push it into 1.4 branch as well? That's the branch
shipped in stock XenServer 6.1.
Regards,
Zoltan Kiss
___
dev mailing lis
This commit removes the redundant call to flow_extract in dpif_netdev_execute,
since in the next line, the call to dpif_netdev_flow_from_nlattrs will reset
the flow variable.
Signed-off-by: Alex Wang
---
lib/dpif-netdev.c |1 -
1 file changed, 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/
On Mon, May 20, 2013 at 10:12 AM, Ben Pfaff wrote:
> On Mon, May 20, 2013 at 07:56:16AM -0700, Gurucharan Shetty wrote:
> > For xenservers with version less than 6.1, interface reconfiguration
> > happened through interface-reconfigure scripts in this repo. In cases
> > where there were multiple
On Tue, May 21, 2013 at 05:09:04PM +, Kyle Mestery (kmestery) wrote:
> On May 21, 2013, at 11:58 AM, Ben Pfaff wrote:
> > Is there another tool that you have used and found to be valuable?
>
> Email still works best, but I'm intrigued to try out your repository
> approach as well.
For what i
On Tue, May 21, 2013 at 10:23:06AM -0700, Romain Lenglet wrote:
> - Original Message -
> > From: "Ben Pfaff"
> > To: "Kyle Mestery (kmestery)"
> > Cc: ""
> > Sent: Tuesday, May 21, 2013 9:58:26 AM
> > Subject: Re: [ovs-dev] my code for review is now available from github
> >
> > On Tue,
- Original Message -
> From: "Ben Pfaff"
> To: "Kyle Mestery (kmestery)"
> Cc: ""
> Sent: Tuesday, May 21, 2013 9:58:26 AM
> Subject: Re: [ovs-dev] my code for review is now available from github
>
> On Tue, May 21, 2013 at 04:05:50PM +, Kyle Mestery (kmestery) wrote:
> > On May 21,
On May 21, 2013, at 11:58 AM, Ben Pfaff wrote:
> On Tue, May 21, 2013 at 04:05:50PM +, Kyle Mestery (kmestery) wrote:
>> On May 21, 2013, at 10:44 AM, Ben Pfaff wrote:
>>> As an organizational tool for developers who might be interested in
>>> reviewing my code, I've now posted all my outstan
On Mon, May 20, 2013 at 07:10:02PM -0700, Ethan Jackson wrote:
> This was causing ovs-vswitchd to core occasionally, even when BFD
> wasn't turned on.
>
> Bug #17162.
> Signed-off-by: Ethan Jackson
Looks good, thanks.
___
dev mailing list
dev@openvswit
On Tue, May 21, 2013 at 04:05:50PM +, Kyle Mestery (kmestery) wrote:
> On May 21, 2013, at 10:44 AM, Ben Pfaff wrote:
> > As an organizational tool for developers who might be interested in
> > reviewing my code, I've now posted all my outstanding unreviewed (or
> > review in progress) code as
On Mon, May 20, 2013 at 5:55 PM, Simon Horman wrote:
> On Fri, May 17, 2013 at 04:14:56PM -0700, Jesse Gross wrote:
>> On Fri, May 17, 2013 at 12:06 AM, Simon Horman wrote:
>> > +static int push_mpls(struct sk_buff *skb,
>> > +const struct ovs_action_push_mpls *mpls)
>> > +{
>
On May 21, 2013, at 10:44 AM, Ben Pfaff wrote:
> As an organizational tool for developers who might be interested in
> reviewing my code, I've now posted all my outstanding unreviewed (or
> review in progress) code as branches in the github repository visible on
> the web at:
>https://gith
On Tue, May 21, 2013 at 6:27 AM, Zoltan Kiss wrote:
> Hi,
>
> Can you explain a little bit what was the effect of this bug for you? What
> kind of problems you have seen?
>
For proper integration of Open vSwitch with controllers such that
controllers get the state of the Hypervisor in question is
As an organizational tool for developers who might be interested in
reviewing my code, I've now posted all my outstanding unreviewed (or
review in progress) code as branches in the github repository visible on
the web at:
https://github.com/blp/ovs-reviews/branches
This is an experiment to
On Tue, May 21, 2013 at 05:49:52PM +0900, y...@mwd.biglobe.ne.jp wrote:
> From: YAMAMOTO Takashi
>
> NetBSD support patch set rebased today
Thanks. If you'll take a look at my proposal for patch 2, then I'll
take a look at the remainder of the patches that I haven't already
applied.
___
I don't know where else to send this so I'll hope that Yamamoto-san
reads ovs-dev.
- Forwarded message from Mail Delivery Subsystem
-
Date: Tue, 21 May 2013 15:02:22 +
From: Mail Delivery Subsystem
To: b...@nicira.com
Subject: Delivery Status Notification (Failure)
Delivery to the
On Tue, May 21, 2013 at 05:50:04PM +0900, y...@mwd.biglobe.ne.jp wrote:
> From: YAMAMOTO Takashi
>
>
> Signed-off-by: YAMAMOTO Takashi
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 21, 2013 at 05:50:02PM +0900, y...@mwd.biglobe.ne.jp wrote:
> From: YAMAMOTO Takashi
>
>
> Signed-off-by: YAMAMOTO Takashi
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, May 21, 2013 at 05:49:54PM +0900, y...@mwd.biglobe.ne.jp wrote:
> From: YAMAMOTO Takashi
>
> mostly ride on the existing FreeBSD support.
>
> Signed-off-by: YAMAMOTO Takashi
I'd like to refine this patch a little in the following way (which is
followed by a full revised version). Ed a
On Tue, May 21, 2013 at 05:49:53PM +0900, y...@mwd.biglobe.ne.jp wrote:
> From: YAMAMOTO Takashi
>
>
> Signed-off-by: YAMAMOTO Takashi
Thanks, applied to master and branch-1.11.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/
Hi,
Can you explain a little bit what was the effect of this bug for you?
What kind of problems you have seen?
Regards,
Zoli
On 20/05/13 15:56, Gurucharan Shetty wrote:
For xenservers with version less than 6.1, interface reconfiguration
happened through interface-reconfigure scripts in thi
Hi,
Sorry, I've forgot to answer this question. There aren't any other ovs
messages in the log, just these. And they only appear if I register a
controller (DVSC in my case) and send every traffic to the controller
with this rule:
ovs-ofctl add-flow xenbr0 priority=65535,actions=controller
From: YAMAMOTO Takashi
suggested by Ed Maste.
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 80 ++--
1 file changed, 31 insertions(+), 49 deletions(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index d885424..c0b3547 100644
--
From: YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi
---
INSTALL.userspace | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/INSTALL.userspace b/INSTALL.userspace
index 296f077..d1f0b69 100644
--- a/INSTALL.userspace
+++ b/INSTALL.userspace
@@ -31,9 +3
From: YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 46 ++
1 file changed, 42 insertions(+), 4 deletions(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index f37eb10..377df36 100644
--- a/lib/netdev-bsd.c
+++ b/lib/net
From: YAMAMOTO Takashi
pointed out by Ed Maste
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 3e91261..a002a9c 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -186,6 +186,7 @@ netdev_b
From: YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 166b03e..b3823a3 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
@@ -1659,7 +1659,7 @@ if test -e /proc
From: YAMAMOTO Takashi
NetBSD support patch set rebased today
YAMAMOTO Takashi (13):
don't forget to define HAVE_BACKTRACE
add minimal NetBSD support
keep "kernel name" for each netdev
netdev-bsd: NetBSD: keep a AF_LINK socket open
missing ifdef netbsd guard for af_link_sock
implemen
From: YAMAMOTO Takashi
this will be used for get_stats and set_etheraddr
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index 06f5fdf..3e91261 100644
--- a/lib/netdev-b
From: YAMAMOTO Takashi
mostly ride on the existing FreeBSD support.
Signed-off-by: YAMAMOTO Takashi
---
lib/command-line.c| 4 ++--
lib/command-line.h| 2 +-
lib/netdev-bsd.c | 37 -
lib/netdev-provider.h | 2 +-
lib/netdev.c | 2 +-
From: YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi
---
m4/openvswitch.m4 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
index ac0c7d5..12c02c0 100644
--- a/m4/openvswitch.m4
+++ b/m4/openvswitch.m4
@@ -169,7 +169,9 @@ AC_DEFUN([
From: YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 60 +---
1 file changed, 53 insertions(+), 7 deletions(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index a002a9c..f37eb10 100644
--- a/lib/netdev-bsd.c
+++
From: YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi
---
acinclude.m4 | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/acinclude.m4 b/acinclude.m4
index cc45a3a..eadc9a7 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -308,7 +308,8 @@ AC_DEFUN([OVS_CHECK_IF_PACKET],
From: YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi
---
INSTALL | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/INSTALL b/INSTALL
index 18e8532..68805ee 100644
--- a/INSTALL
+++ b/INSTALL
@@ -1,9 +1,9 @@
- How to Install Open vSwitch on Linux
From: YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi
---
INSTALL.userspace | 6 +--
lib/netdev-bsd.c | 151 +-
2 files changed, 152 insertions(+), 5 deletions(-)
diff --git a/INSTALL.userspace b/INSTALL.userspace
index d1f0b69..f54b93e
From: YAMAMOTO Takashi
where interface renaming is not supported (NetBSD), remember both of
our netdev name and the correspoinding kernel name separately.
the latter is necessary to talk with kernel using interface names.
eg. ifioctls, bpf
XXX there should be a proper way to query kernel name.
B
46 matches
Mail list logo
