Hi all,
I am using Ubuntu 12.10. I am trying to launch VM on the bridge of
OVS.
Can I do that with virt-manager ? or Is there any other way??
Can I run the existing VM's to my openvswitch bridge ?
I tried to edit existing VM's XML file. I changed the interface type
a/c to my brid
I learned how to squash patches...
Change sFlow model to reflect per-bridge sampling. Before we were presenting a
separate
sFlow data-source (sampler) for each ifIndex-interface, and it was causing
problems with
samples that did not easily map to an ifIndex being aliased together and
breaking
On Tue, Apr 30, 2013 at 5:38 PM, Jesse Gross wrote:
> On Tue, Apr 30, 2013 at 4:21 PM, Pravin B Shelar wrote:
>> diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c
>> index 2db4934..59e22be 100644
>> --- a/datapath/vport-gre.c
>> +++ b/datapath/vport-gre.c
>> @@ -327,10 +325,17 @@ static st
On Tue, Apr 30, 2013 at 5:11 PM, Jesse Gross wrote:
> On Tue, Apr 30, 2013 at 4:20 PM, Pravin B Shelar wrote:
>> diff --git a/datapath/tunnel.c b/datapath/tunnel.c
>> index 057aaed..fb430f2 100644
>> --- a/datapath/tunnel.c
>> +++ b/datapath/tunnel.c
>> @@ -234,17 +221,32 @@ int ovs_tnl_send(stru
On Tue, Apr 30, 2013 at 4:21 PM, Pravin B Shelar wrote:
> diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c
> index 2db4934..59e22be 100644
> --- a/datapath/vport-gre.c
> +++ b/datapath/vport-gre.c
> @@ -327,10 +325,17 @@ static struct vport *gre_create(const struct
> vport_parms *parms)
>
On Tue, Apr 30, 2013 at 4:20 PM, Pravin B Shelar wrote:
> diff --git a/datapath/tunnel.c b/datapath/tunnel.c
> index 057aaed..fb430f2 100644
> --- a/datapath/tunnel.c
> +++ b/datapath/tunnel.c
> @@ -234,17 +221,32 @@ int ovs_tnl_send(struct vport *vport, struct sk_buff
> *skb)
> rt = find
vport->init and exit() functios are defined by gre and netdev vport
only and both can be moved to first port create.
Following patch does same, it moves vport init to respectve vport
create and get rid of vport->init() and vport->exit() fnctions.
Signed-off-by: Pravin B Shelar
---
v1-v2:
No Chan
After flow based tunneling, kernel tunneling is greatly simplified.
There is no need to have extra tunning layer between vport and
perticular protocol.
Following patch removes tunneling struct which make code easy to read.
Signed-off-by: Pravin B Shelar
---
v1-v2:
- Updated comments for vxlan-po
On Tue, Apr 30, 2013 at 04:01:41PM -0700, Jesse Gross wrote:
> On Tue, Apr 30, 2013 at 3:49 PM, Ben Pfaff wrote:
> > On Tue, Apr 30, 2013 at 12:04:44PM -0700, Neil Mckee wrote:
> >> diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
> >> index 8aa7fbe..8d29184 100644
> >> --- a/ofproto/tunnel.c
> >>
On Thu, Apr 25, 2013 at 12:28:46PM +, pengyi Peng(Yi) wrote:
> I find the reason why ovs commits so many transactions.
>
> In bridge_run, ovs-vswitchd would refresh interface statistic if
> necessary. If the number of ports is big enough such as 500, it will
> take a long time to check every p
On Tue, Apr 30, 2013 at 3:49 PM, Ben Pfaff wrote:
> On Tue, Apr 30, 2013 at 12:04:44PM -0700, Neil Mckee wrote:
>> diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
>> index 8aa7fbe..8d29184 100644
>> --- a/ofproto/tunnel.c
>> +++ b/ofproto/tunnel.c
>> @@ -32,7 +32,6 @@
>>
>> /* XXX:
>> *
>> - *
On Tue, Apr 30, 2013 at 03:53:46PM -0700, Ben Pfaff wrote:
> On Tue, Apr 30, 2013 at 12:04:40PM -0700, Neil Mckee wrote:
> > git seemed to want to make this a series of 2 patches, and I don't
> > know how to argue with git. Hope that's OK.
>
> This patch changes dpif_sflow_add_port() in kind of a
On Tue, Apr 30, 2013 at 12:04:40PM -0700, Neil Mckee wrote:
> git seemed to want to make this a series of 2 patches, and I don't
> know how to argue with git. Hope that's OK.
This patch changes dpif_sflow_add_port() in kind of an awkward way
relative to the 'ifindex' variable. This variable's va
On Tue, Apr 30, 2013 at 12:04:44PM -0700, Neil Mckee wrote:
> diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c
> index 8aa7fbe..8d29184 100644
> --- a/ofproto/tunnel.c
> +++ b/ofproto/tunnel.c
> @@ -32,7 +32,6 @@
>
> /* XXX:
> *
> - * Ability to generate metadata for packet-outs
> * Disallow
On Tue, Apr 30, 2013 at 12:04:40PM -0700, Neil Mckee wrote:
> git seemed to want to make this a series of 2 patches, and I don't
> know how to argue with git. Hope that's OK.
I am very good at arguing at Git on this end, so I can make it treat
them as a single patch.
Before I do that, can I have
Thanks, applied to master.
On Mon, Apr 29, 2013 at 06:04:01PM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Apr 29, 2013, at 5:49 PM, Ben Pfaff wrote:
>
> > Um, I mean, remove useless code.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/dpif-netdev.c |4
> > 1 fi
Commit fdd80c39b1822db6c8b5c (datapath: Check gso_type for correct
sk_buff in queue_gso_packets().) could be related, but I am not
certain. It's the mostly likely known-fixed problem I see in a quick
scan of branch-1.4 commits following cc8ccb5.
Could you provide a log excerpt that includes some
Thanks, I've merged this.
Ethan
On Mon, Apr 29, 2013 at 1:45 PM, Ben Pfaff wrote:
> On Mon, Apr 29, 2013 at 12:47:43PM -0700, Ethan Jackson wrote:
>> Signed-off-by: Ethan Jackson
>
> Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://
Sounds good, thanks.
Ethan
On Tue, Apr 30, 2013 at 12:29 PM, Ben Pfaff wrote:
> I don't remember for sure anymore, but looking at patch 3/3 I suspect
> that it's necessary once "ovs-ofctl monitor" starts responding to echo
> requests.
>
> On Tue, Apr 30, 2013 at 12:26:40PM -0700, Ethan Jackson w
I don't remember for sure anymore, but looking at patch 3/3 I suspect
that it's necessary once "ovs-ofctl monitor" starts responding to echo
requests.
On Tue, Apr 30, 2013 at 12:26:40PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> What prompted this?
>
> Ethan
>
> On Thu, Jan 31,
Acked-by: Ethan Jackson
What prompted this?
Ethan
On Thu, Jan 31, 2013 at 4:17 PM, Ben Pfaff wrote:
> Otherwise, if a monitor connection happens to be talking to a (misguided?)
> peer that sends it messages, such as replies to what the peer perceives as
> echo requests meant for it, then the p
Update comments to reflect per-bridge sFlow sampling.
---
ofproto/ofproto-dpif.c | 6 +-
ofproto/tunnel.c | 1 -
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 3ae3532..4306d40 100644
--- a/ofproto/ofproto-dpif.c
+++
git seemed to want to make this a series of 2 patches, and I don't know how to
argue with git. Hope that's OK.
Neil
Change sFlow packet sampling to better reflect the
per-bridge sampling that is really happening, rather than modeling it as
per-interface sampling. This fixes an aliasing pro
Thanks for the review. I applied this to master and branch-1.11.
On Tue, Apr 30, 2013 at 11:22:24AM -0700, Romain Lenglet wrote:
> LGTM. I introduced this bug. Thanks a lot for fixing it!
> --
> Romain Lenglet
>
> - Original Message -
> > From: "Ben Pfaff"
> > To: dev@openvswitch.org
>
LGTM. I introduced this bug. Thanks a lot for fixing it!
--
Romain Lenglet
- Original Message -
> From: "Ben Pfaff"
> To: dev@openvswitch.org
> Cc: "Ben Pfaff" , "Dhaval Badiani"
> Sent: Tuesday, April 30, 2013 11:07:11 AM
> Subject: [ovs-dev] [PATCH] ofproto-dpif: Fix 'size' argument to
The sflow action only uses 8 bytes of the total 16 for user_action_cookie,
but fix_sflow_action() was checking for the presence of all 8, so if the
sflow action wasn't followed by a few other actions then 'cookie' would
end up NULL and the assertion would segfault.
Bug #16659.
Reported-by: Dhaval
On Mon, Apr 29, 2013 at 8:21 PM, Simon Horman wrote:
> On Fri, Apr 26, 2013 at 04:03:21PM -0700, Jesse Gross wrote:
>> On Thu, Apr 25, 2013 at 12:36 AM, Simon Horman wrote:
>> > On Tue, Apr 23, 2013 at 02:00:19PM -0700, Joseph Gasparakis wrote:
>> >> Any particular reason to introduce skb->encaps
On Mon, Apr 29, 2013 at 10:21 PM, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote:
>
>> On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo)
>> wrote:
>>>
>>> Another thing that I came to think only when reading Ben's new tutorial:
>>>
Hi,
Just a reminder, in case this patch fell off the radar: please review it
sometime.
Regards,
Zoli
On 25/04/13 22:40, Justin Pettit wrote:
On Apr 25, 2013, at 11:23 AM, Ben Pfaff wrote:
I'd really like to get multiple reviews on this. Justin, are you
willing to spend some time looking
Hi,
The latest commit we included in XS 6.1 is cc8ccb5 (26 Jun 2012
14:43:54: lib: Do not assume sig_atomic_t is int)
Regards,
Zoli
On 25/04/13 19:25, Ben Pfaff wrote:
It's not "normal". It indicates a bug, although if they are only seen
occasionally it is not a big deal. What commit is t
30 matches
Mail list logo
