On Apr 3, 2013, at 8:24 , ext Simon Horman wrote:
> In the case where a non-MPLS packet is recieved and an MPLS stack is
> added it may well be the case that the original skb is GSO but the
> NIC used for transmit does not support GSO of MPLS packets.
>
...
> diff --git a/include/linux/netdev_fe
On Mar 30, 2013, at 18:20 , ext Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/include/linux/netdevice.h
> b/datapath/linux/compat/include/linux/netdevice.h
> index 71aad87..4ffdac4 100644
> --- a/datapath/linux/compat/include/linux/netdevice.h
> +++ b/datapath/linux/compat/include/
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman and Ravi K.
Cc: Ravi K
Cc: Leo Alterman
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
This is the remaining
In the case where a non-MPLS packet is recieved and an MPLS stack is
added it may well be the case that the original skb is GSO but the
NIC used for transmit does not support GSO of MPLS packets.
The aim of this code is to provide GSO in software for MPLS packets
whose skbs are GSO.
When an imple
Thanks for the review.
On Tue, Apr 02, 2013 at 09:27:12PM -0700, Andy Zhou wrote:
> Looks good.
>
> On Tuesday, April 2, 2013, Ben Pfaff wrote:
>
> > I spotted this in a case where I ran ovsdb-server, by hand, on an empty
> > database.
> >
> > Signed-off-by: Ben Pfaff >
> > ---
> > lib/memory.c
On Tue, Apr 02, 2013 at 09:33:46PM -0700, Justin Pettit wrote:
> On Apr 2, 2013, at 8:49 PM, Ben Pfaff wrote:
>
> > -if (want_report) {
> > +if (want_report && s.length > 0) {
>
> Isn't our style normally to do it like this?
>
> if (want_report && s.length) {
Is it? I'm OK with
On Apr 2, 2013, at 8:49 PM, Ben Pfaff wrote:
> -if (want_report) {
> +if (want_report && s.length > 0) {
Isn't our style normally to do it like this?
if (want_report && s.length) {
Otherwise, looks good.
--Justin
___
dev mailing li
Looks good.
On Tuesday, April 2, 2013, Ben Pfaff wrote:
> I spotted this in a case where I ran ovsdb-server, by hand, on an empty
> database.
>
> Signed-off-by: Ben Pfaff >
> ---
> lib/memory.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/memory.c b/lib/mem
I spotted this in a case where I ran ovsdb-server, by hand, on an empty
database.
Signed-off-by: Ben Pfaff
---
lib/memory.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/memory.c b/lib/memory.c
index 1babfe9..274f307 100644
--- a/lib/memory.c
+++ b/lib/memory.c
@
On Tue, Apr 02, 2013 at 02:09:16PM -0700, Romain Lenglet wrote:
> Prepend "ovs|" to syslog logs to make them easier to filter out of all
> LOG_DAEMON logs.
Seems reasonable.
It needs a Signed-off-by: and a NEWS entry.
Thanks,
Ben.
___
dev mailing list
On Tue, Apr 02, 2013 at 05:24:40PM -0700, Jesse Gross wrote:
> On Fri, Mar 22, 2013 at 6:44 AM, Simon Horman wrote:
> > On Tue, Mar 19, 2013 at 09:01:27AM -0700, Jesse Gross wrote:
> >> On Mon, Mar 18, 2013 at 6:34 PM, Simon Horman wrote:
> >> > On Mon, Mar 18, 2013 at 01:49:43PM -0700, Jesse Gro
On Fri, Mar 22, 2013 at 6:44 AM, Simon Horman wrote:
> On Tue, Mar 19, 2013 at 09:01:27AM -0700, Jesse Gross wrote:
>> On Mon, Mar 18, 2013 at 6:34 PM, Simon Horman wrote:
>> > On Mon, Mar 18, 2013 at 01:49:43PM -0700, Jesse Gross wrote:
>> >> However, do we actually want to tie this directly to
On Tue, Apr 2, 2013 at 3:30 PM, Thomas Graf wrote:
> The port specific options are currently unused resulting in an
> empty OVS_VPORT_ATTR_OPTIONS nested attribute being inserted
> into every OVS_VPORT_CMD_GET message.
>
> Don't insert OVS_VPORT_ATTR_OPTIONS if no options are present.
>
> Signed-o
On Tue, Apr 2, 2013 at 3:28 PM, Thomas Graf wrote:
> The upcall port configured when adding a new datapath is currently
> only provided to user space as part of the vport message. Therefore
> user space has to request two separate messages which is prone to
> race conditions.
>
> Provide the upcal
The port specific options are currently unused resulting in an
empty OVS_VPORT_ATTR_OPTIONS nested attribute being inserted
into every OVS_VPORT_CMD_GET message.
Don't insert OVS_VPORT_ATTR_OPTIONS if no options are present.
Signed-off-by: Thomas Graf
---
net/openvswitch/vport.c | 14 --
The upcall port configured when adding a new datapath is currently
only provided to user space as part of the vport message. Therefore
user space has to request two separate messages which is prone to
race conditions.
Provide the upcall port of the local port (0) of a data path in the
datapath mes
On Sat, Mar 30, 2013 at 9:20 AM, Pravin B Shelar wrote:
> Following patch restructure ovs tunneling to make use of kernel
> api. Doing this tunneling code is simplified as most of protocol
> processing on send and recv is pushed to kernel tunneling. This
> way we can share most protocol related co
FWIW, it looked fine to me.
--Justin
On Apr 2, 2013, at 2:22 PM, Ethan Jackson wrote:
> FYI, I accidentally merged this without review. Justin's looking at
> it now. If it gets anything other than a "looks good", I'll revert
> it. My bad, sorry.
>
> Ethan
>
> On Tue, Apr 2, 2013 at 12:36
FYI, I accidentally merged this without review. Justin's looking at
it now. If it gets anything other than a "looks good", I'll revert
it. My bad, sorry.
Ethan
On Tue, Apr 2, 2013 at 12:36 PM, Ethan Jackson wrote:
> In the standard case, rate limiting facet_learn() to once ever
> 500ms, makes
Prepend "ovs|" to syslog logs to make them easier to filter out of all
LOG_DAEMON logs.
---
lib/vlog.h | 2 +-
python/ovs/vlog.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/vlog.h b/lib/vlog.h
index ab746c8..c7ab206 100644
--- a/lib/vlog.h
+++ b/lib/vlog.h
@
In the standard case, rate limiting facet_learn() to once ever
500ms, makes sense. The worst that can happen is a learning entry
is expired half a second to early. However, when using
fin_timeouts, we really need react quickly to delete the newly
stale flow.
Bug #15915.
Signed-off-by: Ethan Jack
Fix residue from an earlier patch.
Signed-off-by: Jarno Rajahalme
---
tests/lacp.at |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lacp.at b/tests/lacp.at
index 0bcd4b3..ffc8996 100644
--- a/tests/lacp.at
+++ b/tests/lacp.at
@@ -292,7 +292,7 @@ AT_CHECK([grep 'activ
On Mar 30, 2013, at 18:20 , ext Pravin B Shelar wrote:
> Following patch restructure ovs tunneling to make use of kernel
> api. Doing this tunneling code is simplified as most of protocol
> processing on send and recv is pushed to kernel tunneling. This
> way we can share most protocol related co
23 matches
Mail list logo
