Re: [ovs-dev] datapath send and receive packet

2013-03-25 Thread 王国栋
could you explain it more specifically, what's the difference between internal device and other device? where dose it get the packet or when would the internal_dev_xmit procedure be called? 2013/3/26 Jesse Gross > On Mon, Mar 25, 2013 at 4:59 AM, 王国栋 wrote: > > Hello everyone, > > I've got con

[ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-25 Thread Andy Zhou
This is the full patch --- This patch adds more flow related stats to the output of "ovs-appctl dpif/show". Specifically, the follow information are added per ofproto: - Max flow table size - Average flow table size - Average flow table add rate - Average flow table delete rate - Average flow en

[ovs-dev] [PATCH 5/6] vswitchd: Add new configuration table for per-flow packet sampling.

2013-03-25 Thread Romain Lenglet
Add support for configuring multiple IPFIX collectors for per-flow packet sampling. Signed-off-by: Romain Lenglet --- ofproto/ofproto-dpif-ipfix.c | 238 +++ ofproto/ofproto-dpif-ipfix.h | 6 +- ofproto/ofproto-dpif.c | 10 +- ofproto/ofproto-prov

[ovs-dev] [PATCH 2/6] ofproto: Translate NXAST_SAMPLE actions into SAMPLE "flow_sample" dp actions

2013-03-25 Thread Romain Lenglet
The "flow_sample" upcall is is used to sample packets on a per-flow basis. Make the userspace action's userdata size variable depending on the union member used. Signed-off-by: Romain Lenglet --- lib/odp-util.c | 111 +++-- lib/odp-util.h | 1

[ovs-dev] IPFIX patches for per-bridge and per-flow statistical sampling

2013-03-25 Thread Romain Lenglet
Hi Ben, Jesse, Here is an updated series of patches for adding IPFIX support. Following your comments on my previous series of patches, I made the following changes: - Renamed the OpenFlow sampling action into "sample". - Extended the OpenFlow action to include the observation domain ID and ob

[ovs-dev] [PATCH 4/6] vswitchd: Add new configuration table for IPFIX collectors.

2013-03-25 Thread Romain Lenglet
Add IPFIX collector set configuration. Add support for per-bridge IPFIX sampling. Signed-off-by: Romain Lenglet --- ofproto/automake.mk | 2 + ofproto/ofproto-dpif-ipfix.c | 160 +++ ofproto/ofproto-dpif-ipfix.h | 29 ofproto/ofproto-

[ovs-dev] [PATCH 3/6] ofproto: Add "ipfix" upcall for SAMPLE dp action

2013-03-25 Thread Romain Lenglet
The "ipfix" upcall is used to per-bridge packet sampling to IPFIX collectors. Signed-off-by: Romain Lenglet --- lib/odp-util.c | 13 + lib/odp-util.h | 7 ++- ofproto/ofproto-dpif.c | 26 +- tests/odp.at | 1 + 4 files changed,

[ovs-dev] [PATCH 1/6] ofp-actions: Add the NXAST_SAMPLE vendor action

2013-03-25 Thread Romain Lenglet
Define NXAST_SAMPLE OpenFlow vendor action and the corresponding OFPACT_SAMPLE OVS action, to do per-flow packet sampling. Signed-off-by: Romain Lenglet --- FAQ | 13 ++-- NEWS | 1 + WHY-OVS | 17 ++--- debian/control

[ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-25 Thread Andy Zhou
This patch adds more flow related stats to the output of "ovs-appctl dpif/show". Specifically, the follow information are added per ofproto: - Max flow table size - Average flow table size - Average flow table add rate - Average flow table delete rate - Average flow entry life in milliseconds Fe

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-25 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 03:24:15PM -0700, Andy Zhou wrote: > This patch adds more flow related stats to the output of > "ovs-appctl dpif/show". Specifically, the follow information > are added per ofproto: > > - Max flow table size > - Average flow table size > - Average flow table add rate > - A

Re: [ovs-dev] [PATCH 2/3] ovs-bugtool: Add ovs-appctl dpif commands to debug bundle.

2013-03-25 Thread Gurucharan Shetty
On Mon, Mar 25, 2013 at 1:39 PM, Ansis Atteka wrote: > On Mon, Mar 25, 2013 at 10:56 AM, Gurucharan Shetty > wrote: >> With single datapath, 'ovs-dpctl dump-flows ' dumps datapath flows for >> all the userspace bridges in a system. It can get a little harder >> to figure out the datapath flows b

Re: [ovs-dev] [PATCH 2/3] ovs-bugtool: Add ovs-appctl dpif commands to debug bundle.

2013-03-25 Thread Ansis Atteka
On Mon, Mar 25, 2013 at 10:56 AM, Gurucharan Shetty wrote: > With single datapath, 'ovs-dpctl dump-flows ' dumps datapath flows for > all the userspace bridges in a system. It can get a little harder > to figure out the datapath flows belonging to a particular userspace > bridge. > > This patch ad

Re: [ovs-dev] [PATCH 3/3] xenserver: Add information about some bugtool scripts.

2013-03-25 Thread Ansis Atteka
On Mon, Mar 25, 2013 at 10:56 AM, Gurucharan Shetty wrote: > The README file in xenserver directory currently misses information > about a few bugtool scripts. Add them. > > Signed-off-by: Gurucharan Shetty > --- > xenserver/README | 18 +- > 1 file changed, 17 insertions(+), 1

Re: [ovs-dev] [PATCH] vswitchd: Document coverage/show command.

2013-03-25 Thread Ben Pfaff
On Mon, Mar 25, 2013 at 10:56:30AM -0700, Gurucharan Shetty wrote: > coverage/show command documentation is currently missing > from ovs-vswitchd's man page. > > Signed-off-by: Gurucharan Shetty Looks good, thanks. ___ dev mailing list dev@openvswitch.

Re: [ovs-dev] [PATCH 1/3] ovs-bugtool: Add iptables output for all tables.

2013-03-25 Thread Ben Pfaff
On Mon, Mar 25, 2013 at 10:56:27AM -0700, Gurucharan Shetty wrote: > Currently we list all the rules only from the 'filter' table. > Include the rules from all the other tables too. > > Signed-off-by: Gurucharan Shetty Looks good, thanks. ___ dev maili

Re: [ovs-dev] [PATCH 1/3] ovs-bugtool: Add iptables output for all tables.

2013-03-25 Thread Ansis Atteka
On Mon, Mar 25, 2013 at 10:56 AM, Gurucharan Shetty wrote: > Currently we list all the rules only from the 'filter' table. > Include the rules from all the other tables too. > > Signed-off-by: Gurucharan Shetty > --- > utilities/bugtool/ovs-bugtool.in |3 ++- > 1 file changed, 2 insertions(+

Re: [ovs-dev] [PATCH] datapath: Remove vport->linkname

2013-03-25 Thread Jesse Gross
On Mon, Mar 25, 2013 at 12:06 PM, Pravin B Shelar wrote: > This field is no longer used in datapath. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath: Preallocate reply skb in ovs_vport_cmd_set().

2013-03-25 Thread Pravin Shelar
On Mon, Mar 25, 2013 at 9:39 AM, Jesse Gross wrote: > On Thu, Mar 21, 2013 at 8:08 PM, Pravin Shelar wrote: >> On Wed, Mar 20, 2013 at 4:44 PM, Jesse Gross wrote: >>> Allocation of the Netlink notification skb can potentially fail >>> after changing vport configuration. In general, we try to av

[ovs-dev] [PATCH] datapath: Remove vport->linkname

2013-03-25 Thread Pravin B Shelar
This field is no longer used in datapath. Signed-off-by: Pravin B Shelar --- datapath/vport.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/datapath/vport.h b/datapath/vport.h index 074c6ee..885b84c 100644 --- a/datapath/vport.h +++ b/datapath/vport.h @@ -72,7 +72,6 @

[ovs-dev] [RFC PATCH 3/3] tunneling: Allow tunnel fragmentation by default.

2013-03-25 Thread Jarno Rajahalme
Changes the default tunnel dont_fragment from "true" (don't fragment) to "false" (allow fragmentation). Tunnel outer headers will not have the DF bit set by default, and if "df=true" option is given for a tunnel, also local fragmentation will be disabled. The name of the option is changed from "df

[ovs-dev] [PATCH 1/3] datapath: Factor out common code from *_build_header() to ovs_tnl_send().

2013-03-25 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- datapath/tunnel.c |9 + datapath/vport-gre.c | 10 -- datapath/vport-lisp.c |9 - datapath/vport-vxlan.c |9 - 4 files changed, 9 insertions(+), 28 deletions(-) diff --git a/datapath/tunnel.c b/datapath/tun

[ovs-dev] [PATCH 2/3] datapath: Fix IP ID setting.

2013-03-25 Thread Jarno Rajahalme
Eliminate the extra call to ip_select_ident(), and place the __ip_select_ident() call where the ip_select_ident() call was. This fixes two problems: Before, the call to ip_select_ident() did always zero out the value set earlier by __ip_select_ident(). Also, when __ip_select_ident() was called bef

[ovs-dev] [PATCH 0/3] Fix tunnel fragmentation

2013-03-25 Thread Jarno Rajahalme
The "Cleanup old tunnel infrastructure" commit (85c9de194b9f432f7b8a66bda980cbab52a55b72) changed the order in which ip_select_ident() and__ip_select_ident() were called and called __ip_delect_ident() before IP header initialization. This is apparent after the first patch, which refactors code but

[ovs-dev] [PATCH] tunnel: Restore OVS_CB(skb)->flow bfore sending packet to build_header.

2013-03-25 Thread Pravin B Shelar
While sending packet over tunnel it can get segmented or reallocated. In that case we loose OVS_CB(). But some tunneling protocol implementation needs OVS_CB(), e.g. vxlan needs OVS_CB()->flow which leads to kernel panic. Following patch set flow before calling tnl_ops->build_header() and fixes OVS

[ovs-dev] [PATCH] vswitchd: Document coverage/show command.

2013-03-25 Thread Gurucharan Shetty
coverage/show command documentation is currently missing from ovs-vswitchd's man page. Signed-off-by: Gurucharan Shetty --- manpages.mk|2 ++ vswitchd/ovs-vswitchd.8.in |1 + 2 files changed, 3 insertions(+) diff --git a/manpages.mk b/manpages.mk index f89fc17..a14f968 1

[ovs-dev] [PATCH 2/3] ovs-bugtool: Add ovs-appctl dpif commands to debug bundle.

2013-03-25 Thread Gurucharan Shetty
With single datapath, 'ovs-dpctl dump-flows ' dumps datapath flows for all the userspace bridges in a system. It can get a little harder to figure out the datapath flows belonging to a particular userspace bridge. This patch adds the 'ovs-appctl dpif/show' and 'ovs-appctl dpif/dump-flows' output f

[ovs-dev] [PATCH 3/3] xenserver: Add information about some bugtool scripts.

2013-03-25 Thread Gurucharan Shetty
The README file in xenserver directory currently misses information about a few bugtool scripts. Add them. Signed-off-by: Gurucharan Shetty --- xenserver/README | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/xenserver/README b/xenserver/README index 4674

[ovs-dev] [PATCH 1/3] ovs-bugtool: Add iptables output for all tables.

2013-03-25 Thread Gurucharan Shetty
Currently we list all the rules only from the 'filter' table. Include the rules from all the other tables too. Signed-off-by: Gurucharan Shetty --- utilities/bugtool/ovs-bugtool.in |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/utiliti

Re: [ovs-dev] [PATCH] datapath: Preallocate reply skb in ovs_vport_cmd_set().

2013-03-25 Thread Jesse Gross
On Thu, Mar 21, 2013 at 8:08 PM, Pravin Shelar wrote: > On Wed, Mar 20, 2013 at 4:44 PM, Jesse Gross wrote: >> Allocation of the Netlink notification skb can potentially fail >> after changing vport configuration. In general, we try to avoid >> this by undoing any change we made but that is diff

Re: [ovs-dev] datapath send and receive packet

2013-03-25 Thread Jesse Gross
On Mon, Mar 25, 2013 at 4:59 AM, 王国栋 wrote: > Hello everyone, > I've got confused about the datapath send and recv procudure. > In my opinion, the datapath should lookup table when receiving packets from > ports, but it looks up table in the "internal_dev_xmit", which i think > should be used for

[ovs-dev] datapath send and receive packet

2013-03-25 Thread 王国栋
Hello everyone, I've got confused about the datapath send and recv procudure. In my opinion, the datapath should lookup table when receiving packets from ports, but it looks up table in the "internal_dev_xmit", which i think should be used for sending a packet. And the internal_dev_recv is called w