The "Cleanup old tunnel infrastructure" commit (85c9de194b9f432f7b8a66bda980cbab52a55b72) changed the order in which ip_select_ident() and__ip_select_ident() were called and called __ip_delect_ident() before IP header initialization. This is apparent after the first patch, which refactors code but does not change functionality.
The second patch fixes the order of execution and eliminates an extra call to ip_select_ident(). The third patch is RFC, testing the possibility that also the local tunnel fragmentation would be controlled just by the tunnel dont_fragment flag. To facilitate keeping the current behavior w.r.t. local fragmentation, it changes the default from "true" (don't fragment) to "false" (allow fragmentation). Tunnel outer IP header, however, will not have the DF bit set by default, and if "df=true" option is given for a tunnel, also local fragmentation will be disabled. The name of the option is also changed from "df_default" to "df" to be in line with the rest of the tunneling code. Jarno Rajahalme (3): datapath: Factor out common code from *_build_header() to ovs_tnl_send(). datapath: Fix IP ID setting. tunneling: Change tunnel configuration to allow fragmentation by default. datapath/tunnel.c | 2 +- datapath/vport-gre.c | 10 ---------- datapath/vport-lisp.c | 9 --------- datapath/vport-vxlan.c | 9 --------- lib/netdev-vport.c | 12 ++++++------ ofproto/tunnel.c | 4 ++-- tests/tunnel.at | 50 ++++++++++++++++++++++++------------------------ 7 files changed, 34 insertions(+), 62 deletions(-) -- 1.7.10.4 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev