Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Jesse Gross
On Wed, Mar 20, 2013 at 5:33 PM, Simon Horman wrote: > On Wed, Mar 20, 2013 at 03:43:38PM -0700, Jesse Gross wrote: >> On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: >> > Allow datapath to recognize and extract MPLS labels into flow keys >> > and execute actions which push, pop, and set lab

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Simon Horman
On Wed, Mar 20, 2013 at 03:43:38PM -0700, Jesse Gross wrote: > On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > > Allow datapath to recognize and extract MPLS labels into flow keys > > and execute actions which push, pop, and set labels on packets. > > > > Based heavily on work by Leo Alterm

Re: [ovs-dev] [PATCH -next] openvswitch: fix error return code in ovs_vport_cmd_set()

2013-03-20 Thread Jesse Gross
On Wed, Mar 20, 2013 at 9:22 AM, David Miller wrote: > From: Jesse Gross > Date: Wed, 20 Mar 2013 08:57:53 -0700 > >> On Wed, Mar 20, 2013 at 5:14 AM, Wei Yongjun wrote: >>> From: Wei Yongjun >>> >>> Fix to return a negative error code from the error handling >>> case instead of 0, as returned

[ovs-dev] [PATCH] datapath: Preallocate reply skb in ovs_vport_cmd_set().

2013-03-20 Thread Jesse Gross
Allocation of the Netlink notification skb can potentially fail after changing vport configuration. In general, we try to avoid this by undoing any change we made but that is difficult for existing objects. This avoids the problem by preallocating the buffer (which is fixed size). Signed-off-by:

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Jesse Gross
On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > Allow datapath to recognize and extract MPLS labels into flow keys > and execute actions which push, pop, and set labels on packets. > > Based heavily on work by Leo Alterman and Ravi K. > > Cc: Ravi K > Cc: Leo Alterman > Reviewed-by: Isaku

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-20 Thread Jesse Gross
On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > * Update the order in which actions are committed and thus > appear in the datapath such that MPLS actions appear after > l3 and l4 (nw and port) actions. > > In the case where an mpls_push action is present it should ensure > that l3

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-20 Thread Ben Pfaff
On Wed, Mar 20, 2013 at 09:19:06PM +0100, Damien Millescamps wrote: > On 03/20/2013 08:29 PM, Ben Pfaff wrote: > > On Tue, Mar 19, 2013 at 12:22:31PM -0700, Ben Pfaff wrote: > >> > From: Damien Millescamps > >> > > >> > This patch fixes a build error when OVS is built from a > >> > read-only repo

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-20 Thread Ben Pfaff
On Tue, Mar 19, 2013 at 12:22:31PM -0700, Ben Pfaff wrote: > From: Damien Millescamps > > This patch fixes a build error when OVS is built from a > read-only repository. lib/ofp-errors.inc is a distributed file, so it has to be in the source directory rather than the build directory. If you use

Re: [ovs-dev] [PATCH] configure: Only link against libpcap on FreeBSD.

2013-03-20 Thread Ben Pfaff
On Wed, Mar 20, 2013 at 01:00:49PM +, Kyle Mestery (kmestery) wrote: > On Mar 14, 2013, at 5:21 PM, Ben Pfaff wrote: > > On other platforms there is no benefit to linking against libpcap, because > > it is not used. > > > > Signed-off-by: Ben Pfaff > > CC: Ed Maste > > > Looks fine to me.

Re: [ovs-dev] [PATCH] bridge: Rate-limit updates to "instant stats".

2013-03-20 Thread Ben Pfaff
Applied to branch-1.10. On Tue, Mar 19, 2013 at 04:32:32PM -0700, Ben Pfaff wrote: > Thanks, applied to master, I'll apply to branch-1.10 tomorrow if no > problems show up right away. > > On Tue, Mar 19, 2013 at 04:23:27PM -0700, Ethan Jackson wrote: > > Actually you're right, I had confused myse

Re: [ovs-dev] [PATCH -next] openvswitch: fix error return code in ovs_vport_cmd_set()

2013-03-20 Thread David Miller
From: Jesse Gross Date: Wed, 20 Mar 2013 08:57:53 -0700 > On Wed, Mar 20, 2013 at 5:14 AM, Wei Yongjun wrote: >> From: Wei Yongjun >> >> Fix to return a negative error code from the error handling >> case instead of 0, as returned elsewhere in this function. >> >> Signed-off-by: Wei Yongjun >

Re: [ovs-dev] [PATCH -next] openvswitch: fix error return code in ovs_vport_cmd_set()

2013-03-20 Thread Jesse Gross
On Wed, Mar 20, 2013 at 5:14 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as returned elsewhere in this function. > > Signed-off-by: Wei Yongjun This isn't right because at this point in the function the change h

[ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- TODO: * Enhance core k

[ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-20 Thread Simon Horman
* Update the order in which actions are committed and thus appear in the datapath such that MPLS actions appear after l3 and l4 (nw and port) actions. In the case where an mpls_push action is present it should ensure that l3 and l4 actions occur first, which seems logical as once a mpls_

[ovs-dev] [PATCH 0/2 v2.22] MPLS actions and matches

2013-03-20 Thread Simon Horman
Hi, This series implements MPLS actions and matches based on work by Ravi K, Leo Alterman and Yamahata-san. This series provides two changes: * Tweaks to the generation of odp actions when MPLS actions are present and; * Adding basic MPLS action and match support to the kernel datapath Future

Re: [ovs-dev] [PATCH] configure: Only link against libpcap on FreeBSD.

2013-03-20 Thread Kyle Mestery (kmestery)
On Mar 14, 2013, at 5:21 PM, Ben Pfaff wrote: > On other platforms there is no benefit to linking against libpcap, because > it is not used. > > Signed-off-by: Ben Pfaff > CC: Ed Maste Looks fine to me. ___ dev mailing list dev@openvswitch.org http:

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Simon Horman
On Tue, Mar 19, 2013 at 08:16:16AM -0700, Jesse Gross wrote: > On Tue, Mar 19, 2013 at 5:31 AM, Simon Horman wrote: > > On Tue, Mar 19, 2013 at 11:14:58AM +0900, Simon Horman wrote: > >> On Mon, Mar 18, 2013 at 06:35:48PM -0700, Jesse Gross wrote: > >> > On Mon, Mar 18, 2013 at 6:22 PM, Simon Horm

[ovs-dev] [PATCH -next] openvswitch: fix error return code in ovs_vport_cmd_set()

2013-03-20 Thread Wei Yongjun
From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun --- net/openvswitch/datapath.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/da

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-20 Thread Simon Horman
On Tue, Mar 19, 2013 at 12:20:51PM -0700, Jesse Gross wrote: > On Tue, Mar 19, 2013 at 7:57 AM, Simon Horman wrote: > > On Tue, Mar 19, 2013 at 10:35:40AM +0900, Simon Horman wrote: > >> On Mon, Mar 18, 2013 at 08:54:49AM -0700, Jesse Gross wrote: > >> > On Mon, Mar 18, 2013 at 12:37 AM, Simon Hor