Re: [ovs-dev] [PATCH 10/15] datapath: Add basic MPLS support to kernel

2013-02-28 Thread Simon Horman
On Thu, Feb 28, 2013 at 08:33:41PM -0800, Jesse Gross wrote: > On Thu, Feb 28, 2013 at 12:57 AM, Simon Horman wrote: > > On Wed, Feb 27, 2013 at 07:39:02AM -0800, Jesse Gross wrote: > >> On Tue, Feb 26, 2013 at 11:10 PM, Simon Horman wrote: > >> > On Tue, Feb 26, 2013 at 02:49:47PM -0800, Jesse G

Re: [ovs-dev] [PATCH 10/15] datapath: Add basic MPLS support to kernel

2013-02-28 Thread Jesse Gross
On Thu, Feb 28, 2013 at 12:57 AM, Simon Horman wrote: > On Wed, Feb 27, 2013 at 07:39:02AM -0800, Jesse Gross wrote: >> On Tue, Feb 26, 2013 at 11:10 PM, Simon Horman wrote: >> > On Tue, Feb 26, 2013 at 02:49:47PM -0800, Jesse Gross wrote: >> >> > diff --git a/datapath/flow.c b/datapath/flow.c >>

Re: [ovs-dev] [PATCH 2/2] datapath: Increase maximum allocation size of action list.

2013-02-28 Thread Pravin Shelar
On Thu, Feb 28, 2013 at 5:47 PM, Jesse Gross wrote: > On Thu, Feb 28, 2013 at 11:02 AM, Pravin B Shelar wrote: >> The switch to flow based tunneling increased the size of each output >> action in the flow action list. In extreme cases, this can result >> in the action list exceeding the maximum

[ovs-dev] [PATCH] ovs-ofctl: Better ovs-ofctl add-flows error reporting

2013-02-28 Thread Andy Zhou
When error is encountered with add-flows command, this patch adds file name and line number in addition to the parser error message to the output. The file name and line number will not be added to the output of "ovs-ofctl add-flow", only parser error message will appear. Same as before. Signed-o

Re: [ovs-dev] [PATCH 0/3 v2.20] MPLS actions and matches

2013-02-28 Thread Simon Horman
On Thu, Feb 28, 2013 at 05:46:16PM -0800, Jesse Gross wrote: > On Thu, Feb 28, 2013 at 4:38 PM, Simon Horman wrote: > > On Thu, Feb 28, 2013 at 11:12:41AM +, Rajahalme, Jarno (NSN - FI/Espoo) > > wrote: > >> On Feb 28, 2013, at 11:15 , ext Simon Horman wrote: > >> > * Implement recirculation

Re: [ovs-dev] [PATCH 2/2] datapath: Increase maximum allocation size of action list.

2013-02-28 Thread Jesse Gross
On Thu, Feb 28, 2013 at 11:02 AM, Pravin B Shelar wrote: > The switch to flow based tunneling increased the size of each output > action in the flow action list. In extreme cases, this can result > in the action list exceeding the maximum buffer size. > This doubles the maximum buffer size to com

Re: [ovs-dev] [PATCH 1/2] Revert "datapath: Increase maximum allocation size of action list."

2013-02-28 Thread Jesse Gross
On Thu, Feb 28, 2013 at 11:00 AM, Pravin B Shelar wrote: > This reverts commit 82b0d755094ec675ea1a49b4ae58bc1c5e8e51c2. > > This patch introduced bug by calling vfree() in interrupt context. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross __

Re: [ovs-dev] [PATCH 0/3 v2.20] MPLS actions and matches

2013-02-28 Thread Jesse Gross
On Thu, Feb 28, 2013 at 4:38 PM, Simon Horman wrote: > On Thu, Feb 28, 2013 at 11:12:41AM +, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> On Feb 28, 2013, at 11:15 , ext Simon Horman wrote: >> > * Implement recirculation and a host of more sophisticated MPLS features >> > including: >> > -

Re: [ovs-dev] [PATCH] nx-match: Correct writing of value and length in set_field_to_ofast()

2013-02-28 Thread Simon Horman
On Thu, Feb 28, 2013 at 10:33:12AM -0800, Ben Pfaff wrote: > On Thu, Feb 28, 2013 at 02:00:22PM +0900, Simon Horman wrote: > > On Wed, Feb 27, 2013 at 09:41:41AM -0800, Ben Pfaff wrote: > > > On Wed, Feb 27, 2013 at 04:12:16PM +0900, Simon Horman wrote: > > > > ofpbuf_put_* may reallocate the under

[ovs-dev] [PATCH 2/2] datapath: Increase maximum allocation size of action list.

2013-02-28 Thread Pravin B Shelar
The switch to flow based tunneling increased the size of each output action in the flow action list. In extreme cases, this can result in the action list exceeding the maximum buffer size. This doubles the maximum buffer size to compensate for the increase in action size. Action list is recieved f

[ovs-dev] [PATCH 1/2] Revert "datapath: Increase maximum allocation size of action list."

2013-02-28 Thread Pravin B Shelar
This reverts commit 82b0d755094ec675ea1a49b4ae58bc1c5e8e51c2. This patch introduced bug by calling vfree() in interrupt context. Signed-off-by: Pravin B Shelar --- datapath/datapath.c |8 datapath/flow.c | 19 ++- datapath/flow.h |5 + 3 files chan

Re: [ovs-dev] [PATCH 0/3 v2.20] MPLS actions and matches

2013-02-28 Thread Simon Horman
On Thu, Feb 28, 2013 at 11:12:41AM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > On Feb 28, 2013, at 11:15 , ext Simon Horman wrote: > > * Implement recirculation and a host of more sophisticated MPLS features > > including: > > - copy_ttl_in > > - copy_ttl_out > > - L3+ actions on MPLS fr

Re: [ovs-dev] [PATCH v7] Tunnel: Cleanup old tunnel infrastructure.

2013-02-28 Thread Jesse Gross
On Thu, Feb 28, 2013 at 10:27 AM, Pravin B Shelar wrote: > Since userspace flow based tunneling code is checked in, the kernel > port based tunneling code can be removed. > > Patch removes following components: > - tunnel ports hash table and moved tunnel ports list to individual >vports. >

[ovs-dev] [PATCH 2/2] ovs-ctl.in: Restore interfaces and ofports for userspace restarts.

2013-02-28 Thread Gurucharan Shetty
When we upgrade from pre-1.9 to 1.10 or later branches, when just the user space daemons are restarted, with the older kernel module intact, datapaths are recreated. This results in loosing the internal interface states like ip addresses, routing table entries etc. Also, the 'ofport' value of the

[ovs-dev] [PATCH 1/2] ovs-ctl.in: Clean up code for the next commit.

2013-02-28 Thread Gurucharan Shetty
Clean up code and carve out a couple of functions which will be used by the next commit. Signed-off-by: Gurucharan Shetty --- utilities/ovs-ctl.in | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/utilities/ovs-ctl.in b/utilitie

Re: [ovs-dev] vfree() OK from softirq?

2013-02-28 Thread Pravin Shelar
On Thu, Feb 28, 2013 at 3:32 PM, Ben Pfaff wrote: > I got the attached screenshot and crash on branch-1.10. At first > glance it looks like we're calling vfree() from a softirq. I'm not > sure that's allowed. > Right. It is not allowed. I will send out fix. > ___

[ovs-dev] vfree() OK from softirq?

2013-02-28 Thread Ben Pfaff
I got the attached screenshot and crash on branch-1.10. At first glance it looks like we're calling vfree() from a softirq. I'm not sure that's allowed. <>___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v6] Tunnel: Cleanup old tunnel infrastructure.

2013-02-28 Thread Jesse Gross
On Thu, Feb 28, 2013 at 11:32 AM, Pravin B Shelar wrote: > diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c > index 7d45930..1995f3a 100644 > --- a/ofproto/tunnel.c > +++ b/ofproto/tunnel.c > @@ -90,6 +88,9 @@ tnl_port_add__(const struct ofport *ofport, uint32_t > odp_port, > cfg = netdev_ge

Re: [ovs-dev] [PATCH] netdev: Update comment.

2013-02-28 Thread Ben Pfaff
Thanks, I applied this to master. On Thu, Feb 28, 2013 at 11:32:22AM -0800, Justin Pettit wrote: > Looks good. Thanks. > > --Justin > > > On Feb 28, 2013, at 11:20 AM, Ben Pfaff wrote: > > > The claim that there's only a single implementation was long obsolete. > > > > Signed-off-by: Ben Pf

Re: [ovs-dev] [PATCH] netdev: Update comment.

2013-02-28 Thread Justin Pettit
Looks good. Thanks. --Justin On Feb 28, 2013, at 11:20 AM, Ben Pfaff wrote: > The claim that there's only a single implementation was long obsolete. > > Signed-off-by: Ben Pfaff > --- > lib/netdev.h |9 + > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/lib/ne

[ovs-dev] [PATCH] netdev: Update comment.

2013-02-28 Thread Ben Pfaff
The claim that there's only a single implementation was long obsolete. Signed-off-by: Ben Pfaff --- lib/netdev.h |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/netdev.h b/lib/netdev.h index a691d70..13105ee 100644 --- a/lib/netdev.h +++ b/lib/netdev.h @@ -26

Re: [ovs-dev] [PATCH] netdev-linux: Fix netdev_linux_send() return value in corner case.

2013-02-28 Thread Ben Pfaff
Thanks, I pushed this to a bazillion branches. On Tue, Feb 26, 2013 at 03:46:58PM -0800, Justin Pettit wrote: > Looks good. > > --Justin > > > On Feb 26, 2013, at 12:35 PM, Ben Pfaff wrote: > > > A negative 'sock' means there was an error but netdev_linux_send() returns > > a positive errno v

Re: [ovs-dev] [PATCH] nx-match: Correct writing of value and length in set_field_to_ofast()

2013-02-28 Thread Ben Pfaff
On Thu, Feb 28, 2013 at 02:00:22PM +0900, Simon Horman wrote: > On Wed, Feb 27, 2013 at 09:41:41AM -0800, Ben Pfaff wrote: > > On Wed, Feb 27, 2013 at 04:12:16PM +0900, Simon Horman wrote: > > > ofpbuf_put_* may reallocate the underlying buffer of the ofpbuf and > > > thus writing data after a ofpb

[ovs-dev] [PATCH] AUTHORS: Add Andy Zhou.

2013-02-28 Thread Ben Pfaff
CC: Andy Zhou Signed-off-by: Ben Pfaff --- I already applied this to master. diff --git a/AUTHORS b/AUTHORS index 4b5e6fe..9613142 100644 --- a/AUTHORS +++ b/AUTHORS @@ -6,6 +6,7 @@ Alexey I. Froloff ra...@altlinux.org Andrew Evansaev...@nicira.com Andrew Lambeth w..

Re: [ovs-dev] [PATCH] python: Do not include time stamp in syslog messages.

2013-02-28 Thread Ben Pfaff
On Wed, Feb 27, 2013 at 07:20:07PM -0800, Andy Zhou wrote: > > vlog.py currently generates the same log messages, starts with the time stamp > information, for console, syslog and file. All messages start with current > time stamp information. > > Syslogd, by default, prepends time stamp with eac

Re: [ovs-dev] [PATCH] tunnel: Only print non-default UDP dst_port for LISP/VXLAN tunnels

2013-02-28 Thread Kyle Mestery (kmestery)
On Feb 28, 2013, at 11:21 AM, Jesse Gross wrote: > On Thu, Feb 28, 2013 at 6:30 AM, Kyle Mestery wrote: >> In get_tunnel_config(), distinguish between VXLAN and LISP when deciding >> whether or not to print UDP destination port. Only add the UDP >> destination port for either protocol if it is n

Re: [ovs-dev] [PATCH] tunnel: Only print non-default UDP dst_port for LISP/VXLAN tunnels

2013-02-28 Thread Jesse Gross
On Thu, Feb 28, 2013 at 6:30 AM, Kyle Mestery wrote: > In get_tunnel_config(), distinguish between VXLAN and LISP when deciding > whether or not to print UDP destination port. Only add the UDP > destination port for either protocol if it is not the default UDP port. > Update the LISP unit test to

[ovs-dev] [PATCH] tunnel: Only print non-default UDP dst_port for LISP/VXLAN tunnels

2013-02-28 Thread Kyle Mestery
In get_tunnel_config(), distinguish between VXLAN and LISP when deciding whether or not to print UDP destination port. Only add the UDP destination port for either protocol if it is not the default UDP port. Update the LISP unit test to match the new behavior as well. Signed-off-by: Kyle Mestery

Re: [ovs-dev] [PATCH 0/3 v2.20] MPLS actions and matches

2013-02-28 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Feb 28, 2013, at 11:15 , ext Simon Horman wrote: > * Implement recirculation and a host of more sophisticated MPLS features > including: > - copy_ttl_in > - copy_ttl_out > - L3+ actions on MPLS frames (e.g. pop_mpls(0x800),set_ttl) > - multi-level mpls_pop and mpls_push > * Other more speci

[ovs-dev] Betreff: GLUCKWUNSCHE! GLUCKWUNSCHE!! [ IHRE E-mail HAT GEWONNEN $450, 000.00 USD in USA LOTTERIE 2013 {REF NR , 575061725 } Show Details From * Don

2013-02-28 Thread usa . lotterie-gewinns
UNITED STATES OF AMERICA LOTTO INC. ADRESSE: OSTWESTLANDSTRASSE 1325 STADT: SILBERNER FRUHLING STATE/PROVINCE: MARYLAND POSTCODE: 20110 LAND: USA INC. REF NR: .364758679 STAPEL NR: .6485769789/646

[ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-02-28 Thread Simon Horman
This adds support for the OpenFlow 1.1+ dec_mpls_ttl action. And also adds an NX dec_mpls_ttl action. The handling of the TTL modification is entirely handled in userspace. Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.18 - v2.19 * No change v2.17 * Rebase * As suggested by

[ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-02-28 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- TODO: * Exercise check

[ovs-dev] [PATCH 2/3] Add support for set_mpls_ttl action

2013-02-28 Thread Simon Horman
This adds support for the OpenFlow 1.1+ set_mpls_ttl action. And also adds an NX set_mpls_ttl action. The handling of the TTL modification is entirely handled in userspace. Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.20 * Update comment for nx_action_mpls_ttl. The type sh

[ovs-dev] [PATCH 0/3 v2.20] MPLS actions and matches

2013-02-28 Thread Simon Horman
Hi, This series implements MPLS actions and matches based on work by Ravi K, Leo Alterman and Yamahata-san. Compared to the prior edition (v1.19) this series is vastly reduced in size. This is as a result of a discussion I had with Jesse Gross where he suggested that implementing recirculation wo

Re: [ovs-dev] [PATCH 10/15] datapath: Add basic MPLS support to kernel

2013-02-28 Thread Simon Horman
On Wed, Feb 27, 2013 at 07:39:02AM -0800, Jesse Gross wrote: > On Tue, Feb 26, 2013 at 11:10 PM, Simon Horman wrote: > > On Tue, Feb 26, 2013 at 02:49:47PM -0800, Jesse Gross wrote: > >> A couple high level comments: > >> * I'd like to nail down the format of the userspace/kernel interface > >> f