Re: [ovs-dev] [PATCH 1/2] datapath: Fix Flow dump operation.

2013-01-20 Thread Pravin Shelar
On Sun, Jan 20, 2013 at 9:02 PM, Ben Pfaff wrote: > On Sat, Jan 19, 2013 at 08:15:56PM -0800, Pravin B Shelar wrote: >> Following patch adds null check while inserting new netlink attribute. >> This was introduced by commit 9b405f1aa8d175d (datapath: More >> flexible kernel/userspace tunneling att

[ovs-dev] [PATCH 0/3] Reduce sset creation and deletion

2013-01-20 Thread Simon Horman
Hi, this short series of patches aims to increase the rate at which ovs-vswtichd can receive frames. It targets sset creation and deletion which showed up when using perf for profiling. For a configuration with a single match-all flow with actions=drop this patchset improves the rate at which fra

[ovs-dev] [PATCH 2/3] ofproto: Cache result in dp_enumerate_type

2013-01-20 Thread Simon Horman
It is not clear to me that the result calculated by dp_enumerate_type() can ever change. By caching the lookup made by dp_enumerate_types() calls to shash_add() and shash_destroy() destroy are avoided reducing the use of malloc(), free() and hash_bytes(). In my test environment this increased the

[ovs-dev] [PATCH 1/3] netdev-linux: Cache result in netdev_linux_miimon_run()

2013-01-20 Thread Simon Horman
In general the network devices don't change very often. By caching the lookup made by netdev_linux_miimon_run() calls to shash_add() and shash_destroy() destroy are avoided reducing the use of malloc(), free() and hash_bytes(). In my test environment this increased the rate at which packets could

[ovs-dev] [PATCH 3/3] ofproto: Cache result in ofproto_enumerate_types

2013-01-20 Thread Simon Horman
Given the current implementation it is not clear to me that the result calculated by ofproto_enumerate_types() can ever change. By caching the lookup made by ofproto_enumerate_types() calls to shash_add() and shash_destroy() destroy are avoided reducing the use of malloc(), free() and hash_bytes()

Re: [ovs-dev] [PATCH 2/2] datapath: Fix netlink attribute size for flow.

2013-01-20 Thread Ben Pfaff
On Sat, Jan 19, 2013 at 08:16:06PM -0800, Pravin B Shelar wrote: > Following patch fixes flow buffer size calculation to allocate > sufficient memory for all nested attributes in new tunnel > attribute. > > Signed-off-by: Pravin B Shelar > Bug #14767 Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH 1/2] datapath: Fix Flow dump operation.

2013-01-20 Thread Ben Pfaff
On Sat, Jan 19, 2013 at 08:15:56PM -0800, Pravin B Shelar wrote: > Following patch adds null check while inserting new netlink attribute. > This was introduced by commit 9b405f1aa8d175d (datapath: More > flexible kernel/userspace tunneling attribute.) > > Signed-off-by: Pravin B Shelar > Bug #147

[ovs-dev] [PATCH] ofproto: Remove redundant call to ofconn_get_ofproto

2013-01-20 Thread Paraneetharan Chandrasekaran
This is a cosmetic change. Remove the redundant call to ofconn_get_ofproto in handle_flow_mod. Signed-off-by: Paraneetharan C --- Patch attached. changes.diff Description: Binary data ___ dev mailing list dev@openvswitch.org http://openvswitch.org/ma