On Sun, Jan 20, 2013 at 9:02 PM, Ben Pfaff <b...@nicira.com> wrote: > On Sat, Jan 19, 2013 at 08:15:56PM -0800, Pravin B Shelar wrote: >> Following patch adds null check while inserting new netlink attribute. >> This was introduced by commit 9b405f1aa8d175d (datapath: More >> flexible kernel/userspace tunneling attribute.) >> >> Signed-off-by: Pravin B Shelar <pshe...@nicira.com> >> Bug #14767 > > I agree that this fixes a null pointer dereference. On that basis: > > Acked-by: Ben Pfaff <b...@nicira.com> > Thanks I pushed patch to master and 1.9.
> But: it looks like to me that we can end up with a partial set of > actions in the message, both with and without this patch. I think that > if only some of the actions can be included, then we should omit the > attribute entirely, because I believe that this was the original and > intended behavior before commit 9b405f1aa8d175d. ok, To check for space I can use actions_len which is pretty close to memory needed. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
