Re: [ovs-dev] [PATCH] manpages: Fix build

2013-01-04 Thread Ben Pfaff
On Fri, Jan 04, 2013 at 08:11:40PM -0600, Saul St. John wrote: > This patch fixes regressions in the dist and distclean targets, and in > the Debian build process, that were introduced by commit d2cb6c956b. > > Signed-off-by: Saul St. John Thanks. I updated the commit message by adding the firs

[ovs-dev] [PATCH] manpages: Fix build

2013-01-04 Thread Saul St. John
This patch fixes regressions in the dist and distclean targets, and in the Debian build process, that were introduced by commit d2cb6c956b. Signed-off-by: Saul St. John --- debian/openvswitch-common.manpages |2 +- utilities/bugtool/automake.mk |3 +-- 2 files changed, 2 insertions(

Re: [ovs-dev] [PATCH 2/2] bond: Change rebalance ratio to be more fair

2013-01-04 Thread Ben Pfaff
On Thu, Dec 20, 2012 at 09:55:06PM +, Zoltan Kiss wrote: > The old algorithm tries to converge to 0, despite it would mean a very > unbalanced situation. 1 is a more desirable goal. Fortunately rebalancing > never > worked, so this never caused a problem. But my previous patch needs it. > It w

[ovs-dev] [PATCH] rconn: Avoid memory leak in rconn_send_with_limit() on queue overflow.

2013-01-04 Thread Ben Pfaff
Bug #14357. Reported-by: Luca Giraudo Signed-off-by: Ben Pfaff --- This leak has been around forever. I expect to backport it all the way to 1.4. lib/rconn.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/rconn.c b/lib/rconn.c index 1ea022b..2049a90 1006

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-04 Thread Ben Pfaff
On Fri, Jan 04, 2013 at 12:39:40PM -0800, Romain Lenglet wrote: > On Jan 4, 2013, at 10:31 AM, Ben Pfaff wrote: > > >> +return di; > >> +} > > > > In vswitch.ovsschema, I believe that we could limit obs_domain_id to the > > 32-bit range, since it's a 32-bit value. Is it worthwhile to do so?

Re: [ovs-dev] [bug 14265 3/3] rconn: Fix null pointer dereference in rconn_add_monitor().

2013-01-04 Thread Ben Pfaff
Thanks for the reviews, I'll do another round of unit tests and push this. On Fri, Jan 04, 2013 at 12:39:19PM -0800, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > > On Wed, Jan 2, 2013 at 5:10 PM, Ben Pfaff wrote: > > > rconn_add_monitor() tries to check the version of the controller > >

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-04 Thread Romain Lenglet
On Jan 4, 2013, at 10:31 AM, Ben Pfaff wrote: >> +return di; >> +} > > In vswitch.ovsschema, I believe that we could limit obs_domain_id to the > 32-bit range, since it's a 32-bit value. Is it worthwhile to do so? Good idea. I've done that, and done the changes you suggested for the other

Re: [ovs-dev] [bug 14265 3/3] rconn: Fix null pointer dereference in rconn_add_monitor().

2013-01-04 Thread Ethan Jackson
Acked-by: Ethan Jackson On Wed, Jan 2, 2013 at 5:10 PM, Ben Pfaff wrote: > rconn_add_monitor() tries to check the version of the controller > connection being monitored, so that it can decide what OpenFlow version to > tell the monitor connection to negotiate. But at any given time an rconn >

Re: [ovs-dev] [bug 14265 2/3] ovs-ofctl: Use vconn_open() instead of vconn_open_block() in open_vconn__().

2013-01-04 Thread Ethan Jackson
Acked-by: Ethan Jackson On Wed, Jan 2, 2013 at 5:10 PM, Ben Pfaff wrote: > All of the paths in open_vconn__(), except the one path that calls > vconn_open() directly, just start the connection and do not block until > it completes. This changes the remaining path to work the same way. > > Thi

[ovs-dev] (no subject)

2013-01-04 Thread Mr.Aziz Tange
Sir/Madam, I am Mr.Aziz Tange a government and non governmental organization agent here in Burkina Faso. Presently, I have been authorized by the Ministry of works and housing to negotiate for a contractor who can handle Project Zaca or supply the construction materials for the project.

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-04 Thread Ben Pfaff
On Tue, Dec 18, 2012 at 11:52:11AM -0800, Romain Lenglet wrote: > Signed-off-by: Romain Lenglet ... > +struct dpif_ipfix * > +dpif_ipfix_create(void) > +{ > +struct dpif_ipfix *di; > +di = xcalloc(1, sizeof *di); You can use xzalloc(x) instead of xcalloc(1, x); > +return di; > +}

Re: [ovs-dev] [PATCH 2/4] ofproto: Translate NXAST_SAMPLE_IPFIX actions into SAMPLE dp actions

2013-01-04 Thread Ben Pfaff
On Tue, Dec 18, 2012 at 11:52:10AM -0800, Romain Lenglet wrote: > Signed-off-by: Romain Lenglet ... > +/* Compose SAMPLE action for sFlow or IPFIX. */ It would probably be better to document the usage of parameters here, at the top of the function, rather than with the comment > + /* Number

Re: [ovs-dev] [PATCH 1/4] ofp-actions: Add the NXAST_SAMPLE_IPFIX vendor action

2013-01-04 Thread Ben Pfaff
On Tue, Dec 18, 2012 at 11:52:09AM -0800, Romain Lenglet wrote: > Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding > OFPACT_SAMPLE_IPFIX OVS action. > > Signed-off-by: Romain Lenglet ... > +/* Action structure for NXAST_SAMPLE_IPFIX. > + * > + * Samples matching packets wi

Re: [ovs-dev] [PATCH 0/16 v2.13] Basic MPLS actions and matches

2013-01-04 Thread Ben Pfaff
Since Jesse is perpetually backlogged: if there are any parts of the series that can be usefully applied without changing the datapath, let me know, and I'll take care of it. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo

Re: [ovs-dev] [bug 14265 1/3] vconn: Fix parameters for vconn_open(), vconn_open_block(), pvconn_open().

2013-01-04 Thread Ben Pfaff
Thanks, applied to master. On Thu, Jan 03, 2013 at 04:41:33PM -0800, Ethan Jackson wrote: > This has annoyed me for a while too. Thanks. > > Acked-by: Ethan Jackson > > > On Wed, Jan 2, 2013 at 5:10 PM, Ben Pfaff wrote: > > > The customary parameter order in Open vSwitch is to put input par

Re: [ovs-dev] [PATCH] manpages: Put version number instead of date at bottom of page.

2013-01-04 Thread Ben Pfaff
Thanks, applied to master. On Wed, Jan 02, 2013 at 03:07:54PM -0800, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > > On Wed, Jan 2, 2013 at 10:19 AM, Ben Pfaff wrote: > > > We're really good about keeping manpages up to date, but terrible at > > updating the dates at the bottom of the ma

Re: [ovs-dev] [PATCH] FAQ: Remove doubled "modified" in FAQ answer.

2013-01-04 Thread Ben Pfaff
On Thu, Jan 03, 2013 at 04:54:46PM -0800, Jesse Gross wrote: > On Thu, Jan 3, 2013 at 4:52 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > FAQ |8 > > 1 files changed, 4 insertions(+), 4 deletions(-) > > Looks good. Thanks, applied to master.

Re: [ovs-dev] [PATCH] ovs-ofctl: Document to work with any OpenFlow switch.

2013-01-04 Thread Ben Pfaff
Thanks, pushed to master. On Wed, Jan 02, 2013 at 03:08:31PM -0800, Ethan Jackson wrote: > Acked-by: Ethan Jackson > > > On Wed, Jan 2, 2013 at 9:56 AM, Ben Pfaff wrote: > > > I've always intended ovs-ofctl to work with any OpenFlow switch, not just > > with Open vSwitch. This explicitly doc

Re: [ovs-dev] [PATCH 1/2] Fix handling of OFPP_ANY in OpenFlow 1.1 and later.

2013-01-04 Thread Ben Pfaff
On Thu, Jan 03, 2013 at 01:47:32PM -0800, Gurucharan Shetty wrote: > On Thu, Jan 3, 2013 at 11:20 AM, Ben Pfaff wrote: > > > On Thu, Jan 03, 2013 at 10:42:59AM -0800, Gurucharan Shetty wrote: > > > On Mon, Nov 26, 2012 at 10:11 AM, Ben Pfaff wrote: > > > > > > > From: Jarno Rajahalme > > > > >

Re: [ovs-dev] Stats for flow-based logical ports/tunnels?

2013-01-04 Thread Jesse Gross
On Fri, Jan 4, 2013 at 5:36 AM, Jarno Rajahalme wrote: > > On Dec 13, 2012, at 21:26 , ext Jesse Gross wrote: >> Yes, at the kernel level there is no mapping from tunnel IP >> information to either port or datapath - it just extracts the >> information and stores it in the flow. This is why the s

Re: [ovs-dev] Question about the availabiltiy of ovs python binding.

2013-01-04 Thread Ben Pfaff
On Fri, Jan 04, 2013 at 04:22:24PM +, ?? wrote: > 1. I want to run the ovs idl in a sperate thread, but the implementation > traps some fatal signal to remove unix socket file which is not allowed in > the thread that is no the main thread, does ovs idl python implementatin > only aimed t

[ovs-dev] Question about the availabiltiy of ovs python binding.

2013-01-04 Thread 张东亚
Hi list, Recently I am researching on ovs python binding, and basically I want to develop an app that operates and monitors ovsdb in python. So I want to know what's the status of ovs python binding, I found there does have an ovs idl implementation in the released source of ovs, and I have tes

[ovs-dev] Stats for flow-based logical ports/tunnels?

2013-01-04 Thread Jarno Rajahalme
On Dec 13, 2012, at 21:26 , ext Jesse Gross wrote: > Yes, at the kernel level there is no mapping from tunnel IP > information to either port or datapath - it just extracts the > information and stores it in the flow. This is why the single > datapath changes were necessary. > What is the plan