Re: [ovs-dev] [PATCH] rconn: Maintain original allowed_versions instead of substituting for zero.

2012-12-04 Thread Ben Pfaff
Thanks. I folded in this change to update the comment: @@ -172,14 +172,14 @@ static bool rconn_logging_connection_attempts__(const struct rconn *); * The new rconn is initially unconnected. Use rconn_connect() or * rconn_connect_unreliably() to connect it. * * Connections made by the rc

Re: [ovs-dev] [PATCH] rconn: Maintain original allowed_versions instead of substituting for zero.

2012-12-04 Thread Justin Pettit
Looks good. Should the last sentence in the comment describing rconn_create be removed, since it's talking about what happens if 'allowed_versions' is zero? --Justin On Dec 4, 2012, at 5:51 PM, Ben Pfaff wrote: > rconn_create() was substituting OFPUTIL_DEFAULT_VERSIONS if an > allowed_versio

[ovs-dev] [PATCH] rconn: Maintain original allowed_versions instead of substituting for zero.

2012-12-04 Thread Ben Pfaff
rconn_create() was substituting OFPUTIL_DEFAULT_VERSIONS if an allowed_versions of 0 was passed in. At the same time, connmgr_set_controllers() compared the adjusted value of allowed_versions against the original value, saw that they were different, and concluded that it should kill off and recrea

Re: [ovs-dev] [PATCH v6] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-12-04 Thread Jesse Gross
On Thu, Nov 29, 2012 at 2:46 PM, Kyle Mestery wrote: > Note: v6 of this patch addresses additional comments from > Jesse. Specifically, I've removed the hash table of > port/socket mappings and moved to a linked list. I've also > cleaned up the code around this quite a bit. > > Note: v5 of this pa

Re: [ovs-dev] [PATCH] FAQ: Add table of supported Linux versions.

2012-12-04 Thread Ben Pfaff
On Tue, Dec 04, 2012 at 01:42:07PM -0800, Jesse Gross wrote: > On Tue, Dec 4, 2012 at 12:46 PM, Ben Pfaff wrote: > > On Tue, Dec 04, 2012 at 08:43:31PM +, Kyle Mestery (kmestery) wrote: > >> On Dec 4, 2012, at 2:38 PM, Ben Pfaff wrote: > >> > Signed-off-by: Ben Pfaff > >> > >> > >> This look

Re: [ovs-dev] [PATCH] FAQ: Add table of supported Linux versions.

2012-12-04 Thread Jesse Gross
On Tue, Dec 4, 2012 at 12:46 PM, Ben Pfaff wrote: > On Tue, Dec 04, 2012 at 08:43:31PM +, Kyle Mestery (kmestery) wrote: >> On Dec 4, 2012, at 2:38 PM, Ben Pfaff wrote: >> > Signed-off-by: Ben Pfaff >> >> >> This looks great, and hopefully will help with questions around >> kernel versions g

[ovs-dev] [PATCH] vswitchd: Require "target" column to be unique in OVS database.

2012-12-04 Thread Ben Pfaff
Commit cc7ecee48 (vswitchd: Add unique indexes for some columns.) says, in part: With this commit, the database server itself rejects attempts to add Port or Interface records with duplicate names or Controller or Manager records with duplicate targets. but in fact didn't change the C

Re: [ovs-dev] OVS development - beginner

2012-12-04 Thread Ben Pfaff
Open vSwitch already has features for that. What do you propose to add? On Tue, Dec 04, 2012 at 01:20:19PM -0800, Ra Alva wrote: > Hello Ben, > > My task is to minimize the consumption of flow tables by flow enties > (in other words, preventing the over-population of flow tables by > flow enties

Re: [ovs-dev] OVS development - beginner

2012-12-04 Thread Ra Alva
Hello Ben, My task is to minimize the consumption of flow tables by flow enties (in other words, preventing the over-population of flow tables by flow enties) since the flow tables are of limited size. From: Ben Pfaff To: Ra Alva Cc: OVS Sent: Tuesday,

Re: [ovs-dev] OVS development - beginner

2012-12-04 Thread Ben Pfaff
On Tue, Dec 04, 2012 at 01:04:51PM -0800, Ra Alva wrote: > I am going to start a project on OVS. I am a complete beginner > here. Precisely my task deals with optimizing the usage of flow > tables in OVS. > > Could someone please tell me what my first steps should be to get > familiar with OVS and

[ovs-dev] OVS development - beginner

2012-12-04 Thread Ra Alva
Hello all, I am going to start a project on OVS. I am a complete beginner here. Precisely my task deals with optimizing the usage of flow tables in OVS. Could someone please tell me what my first steps should be to get familiar with OVS and the code? What are the most important things to do a

Re: [ovs-dev] [ovs-assert 1/4] util: Introduce ovs_assert macro.

2012-12-04 Thread Ben Pfaff
On Wed, Nov 07, 2012 at 10:48:16AM -0800, Ben Pfaff wrote: > An occasionally significant problem with the standard "assert" macro is > that it writes the failure message to stderr. In our daemons, stderr is > generally redirected to /dev/null. It's more useful to write the failure > message to th

Re: [ovs-dev] [PATCH] ofproto: Report correct error for emergency flow with timeout.

2012-12-04 Thread Ben Pfaff
On Thu, Nov 01, 2012 at 12:22:41AM -0700, Ben Pfaff wrote: > The OpenFlow 1.0 specification says: > > Emergency flow mod messages must have timeout values set to zero. > Otherwise, the switch must refuse the addition and respond with an > ofp_error_msg with OFPET_FLOW_MOD_FAILED type a

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-12-04 Thread Ben Pfaff
On Mon, Oct 29, 2012 at 09:34:37AM -0700, Ben Pfaff wrote: > Until now, a command like "ovs-vsctl --may-exist add-br br0" yielded a > confusing error message. Users had to realize that the correct form was > "ovs-vsctl -- --may-exist add-br br0", but instead they often reported a > bug or gave up

Re: [ovs-dev] [PATCH] vswitchd: Make the maximum size of MAC learning tables user-configurable.

2012-12-04 Thread Ben Pfaff
On Wed, Oct 24, 2012 at 05:01:29PM -0700, Ben Pfaff wrote: > We've had a couple of requests for this over the years. It's easy to do, > so let's implement it. > > Signed-off-by: Ben Pfaff I know that some users would find this handy, so it would be nice to get it reviewed. _

Re: [ovs-dev] [PATCH 3/3] ovs-ofctl: Make "ovs-ofctl monitor" respond to echo requests.

2012-12-04 Thread Ben Pfaff
On Wed, Oct 24, 2012 at 09:51:22AM -0700, Ben Pfaff wrote: > Otherwise the command will time out after a while when there's no traffic, > which probably isn't what we want. > > Reported-by: Henry Mai > Signed-off-by: Ben Pfaff It would be good to get this series reviewed and in, since the bug t

Re: [ovs-dev] [PATCH] vlog: New vlog/enable-rate-limit and vlog/disable-rate-limit commands.

2012-12-04 Thread Ben Pfaff
On Tue, Oct 16, 2012 at 10:15:48AM -0700, Ben Pfaff wrote: > A few times while troubleshooting it would have been useful to get > complete logs, rather than post-rate-limiting snapshots of them. These > ovs-appctl commands make that possible. > > Signed-off-by: Ben Pfaff It would be good to get

Re: [ovs-dev] [PATCH] nx-match: Log a warning when a wildcarded bit is set to 1.

2012-12-04 Thread Ben Pfaff
On Wed, Oct 03, 2012 at 09:48:57AM -0700, Ben Pfaff wrote: > This was prompted by a conversation on the openflow-discuss mailing list > where developers of some OpenFlow switches mentioned that they save an > entire copy of raw flows passed in by controllers because of the > possibility that there

Re: [ovs-dev] [PATCH net-next 3/7] ipv6: improve ipv6_find_hdr() to skip empty routing headers

2012-12-04 Thread Ansis Atteka
On Tue, Dec 4, 2012 at 10:15 AM, Jesse Gross wrote: > On Mon, Dec 3, 2012 at 10:06 AM, Pablo Neira Ayuso > wrote: >> On Mon, Dec 03, 2012 at 09:28:55AM -0800, Jesse Gross wrote: >>> On Mon, Dec 3, 2012 at 6:04 AM, Pablo Neira Ayuso >>> wrote: >>> > On Thu, Nov 29, 2012 at 10:35:45AM -0800, Jes

Re: [ovs-dev] [PATCH] FAQ: Add table of supported Linux versions.

2012-12-04 Thread Ben Pfaff
On Tue, Dec 04, 2012 at 08:43:31PM +, Kyle Mestery (kmestery) wrote: > On Dec 4, 2012, at 2:38 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > > This looks great, and hopefully will help with questions around > kernel versions going forward. > > Acked-by: Kyle Mestery Thanks, I add

Re: [ovs-dev] [PATCH] FAQ: Add table of supported Linux versions.

2012-12-04 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 2:38 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff This looks great, and hopefully will help with questions around kernel versions going forward. Acked-by: Kyle Mestery ___ dev mailing list dev@openvswitch.org http://openvswitch

[ovs-dev] [PATCH] FAQ: Add table of supported Linux versions.

2012-12-04 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- FAQ | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/FAQ b/FAQ index 9bb9ffa..15fb694 100644 --- a/FAQ +++ b/FAQ @@ -128,6 +128,32 @@ A: All official releases have been through a comprehensive testing supplanted b

Re: [ovs-dev] [PATCH 0/4] RFC: database backed logging console

2012-12-04 Thread Ben Pfaff
On Thu, Nov 29, 2012 at 07:53:10PM +0100, Thomas Graf wrote: > On 11/29/2012 06:23 PM, Ben Pfaff wrote: > >It's better in that it would simply report whether the port was > >successfully added in an unambiguous fashion, instead of shipping > >possibly a lot of possibly irrelevant log data to the us

Re: [ovs-dev] [PATCH] v2 openvswitch: Remove Linux bridge compatibility.

2012-12-04 Thread Jesse Gross
On Mon, Dec 3, 2012 at 10:53 AM, Pravin B Shelar wrote: > Currently brcompat does not on master due to recent > datapath changes. We have decided to remove it as it is > not used very widely. I think you missing a word in the first sentence. > diff --git a/NEWS b/NEWS > index bb80beb..ac56e3e 10

Re: [ovs-dev] Spurious test failure?

2012-12-04 Thread Ben Pfaff
On Tue, Dec 04, 2012 at 05:10:29PM +0200, Jarno Rajahalme wrote: > It seems to me that depending on test machine load or other > scheduling reasons, it is possible that some tests fail sometimes, > even if there is no real failure. One such case below, where it > seems that the middle reply comes i

Re: [ovs-dev] [PATCH net-next 3/7] ipv6: improve ipv6_find_hdr() to skip empty routing headers

2012-12-04 Thread Jesse Gross
On Mon, Dec 3, 2012 at 10:06 AM, Pablo Neira Ayuso wrote: > On Mon, Dec 03, 2012 at 09:28:55AM -0800, Jesse Gross wrote: >> On Mon, Dec 3, 2012 at 6:04 AM, Pablo Neira Ayuso >> wrote: >> > On Thu, Nov 29, 2012 at 10:35:45AM -0800, Jesse Gross wrote: >> >> @@ -159,9 +162,10 @@ int ipv6_find_hdr(c

Re: [ovs-dev] [PATCH net-next] openvswitch: Avoid useless holes in struct vport

2012-12-04 Thread Jesse Gross
On Mon, Dec 3, 2012 at 2:24 PM, Thomas Graf wrote: > > Having the 16bit port_no in between a set of pointers creates > an unwanted and useless hole in the struct. > > Signed-off-by: Thomas Graf Applied. ___ dev mailing list dev@openvswitch.org http://o

Re: [ovs-dev] [PATCH net-next] openvswitch: Use eth_mac_addr() instead of duplicating it

2012-12-04 Thread Jesse Gross
On Mon, Dec 3, 2012 at 2:17 PM, Thomas Graf wrote: > > bonus: if we ever are to use IFF_LIVE_ADDR_CHANGE for > anything further than to check availability in eth_mac_addr(), > Open vSwitch will be ready for that. > > Signed-off-by: Thomas Graf Applied. ___

Re: [ovs-dev] [PATCH] Discourage use of unencodable error codes, add a generic OFPERR_NX__UNKNOWN_ERROR code.

2012-12-04 Thread Ben Pfaff
On Tue, Dec 04, 2012 at 03:26:25PM +0200, Jarno Rajahalme wrote: > On Dec 3, 2012, at 21:21 , ext Ben Pfaff wrote: > > > On Sat, Dec 01, 2012 at 09:55:58AM -0800, Ben Pfaff wrote: > >> On Fri, Nov 30, 2012 at 02:22:00PM +0200, Jarno Rajahalme wrote: > >>>Removed error category types (OFPERR_OF

Re: [ovs-dev] [PATCH] INSTALL.Debian: New instructions for installing on Debian.

2012-12-04 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 9:40 AM, Ben Pfaff wrote: > On Tue, Dec 04, 2012 at 02:19:10PM +, Kyle Mestery (kmestery) wrote: >> >> On Dec 4, 2012, at 12:02 AM, Ben Pfaff wrote: >> >>> Signed-off-by: Ben Pfaff >>> --- >>> INSTALL|7 +--- >>> INSTALL.Debian | 125 >>> +++

Re: [ovs-dev] [PATCH] INSTALL.Debian: New instructions for installing on Debian.

2012-12-04 Thread Ben Pfaff
On Tue, Dec 04, 2012 at 02:19:10PM +, Kyle Mestery (kmestery) wrote: > > On Dec 4, 2012, at 12:02 AM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > INSTALL|7 +--- > > INSTALL.Debian | 125 > > > > Makefile.a

[ovs-dev] Spurious test failure?

2012-12-04 Thread Jarno Rajahalme
It seems to me that depending on test machine load or other scheduling reasons, it is possible that some tests fail sometimes, even if there is no real failure. One such case below, where it seems that the middle reply comes in a bit later than anticipated. On repeat this failure did not occur a

Re: [ovs-dev] [PATCH] INSTALL.Debian: New instructions for installing on Debian.

2012-12-04 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 12:02 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > INSTALL|7 +--- > INSTALL.Debian | 125 > Makefile.am|1 + > README | 31 -- > 4 files changed, 146 insertions(+), 18

[ovs-dev] US Airways reservation confirmation.

2012-12-04 Thread US Airways - Confirmation
You can check infrom 24 hours and up to 60 minutes beforeyour flight (2 hours if you're flyinginternationally).Then, all you need todo is print your boarding pass andhead to the gate. Purchasecode:574758Check-in online: Online bookingdetailsPayment method:  CREDIT CARD Sum will be withdrawn

Re: [ovs-dev] [PATCH] Discourage use of unencodable error codes, add a generic OFPERR_NX__UNKNOWN_ERROR code.

2012-12-04 Thread Jarno Rajahalme
On Dec 3, 2012, at 21:21 , ext Ben Pfaff wrote: > On Sat, Dec 01, 2012 at 09:55:58AM -0800, Ben Pfaff wrote: >> On Fri, Nov 30, 2012 at 02:22:00PM +0200, Jarno Rajahalme wrote: >>>Removed error category types (OFPERR_OFPET_*) from enum ofperr to make >>> it harder for contributors to use >>>

[ovs-dev] ATTN: PLEASE???

2012-12-04 Thread Engr.Luis Edward
FOR YOUR PERUSAL, I am Engineer Luis Edward a petrochemical/oil exploration engineer with ARABIAN GULF EXPLORATION COMPANY (AGECO)  one of the registered oil & gas exploration company in Libya.  I need your collaboration to investing in your country. Can you assist me and two other colleagues