Re: [ovs-dev] [PATCH 2/8] ofp-util: Flow Dump Protocol for OpenFlow 12

2012-11-19 Thread Ben Pfaff
On Tue, Nov 20, 2012 at 10:50:39AM +0900, Simon Horman wrote: > On Mon, Nov 19, 2012 at 05:11:21PM -0800, Ben Pfaff wrote: > > On Tue, Nov 20, 2012 at 09:39:56AM +0900, Simon Horman wrote: > > > On Mon, Nov 19, 2012 at 10:13:22AM -0800, Ben Pfaff wrote: > > > > On Mon, Nov 19, 2012 at 02:59:29PM +0

Re: [ovs-dev] OpenVswitch dev document

2012-11-19 Thread Cong Wang
On Mon, Nov 19, 2012 at 3:51 PM, 李强 wrote: > Hi,all. > I'm a student and now going on some project related to OpenVswtich. But > the source code seems so complicated to me. Do you have development document > about openvswitch? If you have, could you please mail me a copy? I have written an ar

Re: [ovs-dev] [PATCH 2/8] ofp-util: Flow Dump Protocol for OpenFlow 12

2012-11-19 Thread Simon Horman
On Mon, Nov 19, 2012 at 05:11:21PM -0800, Ben Pfaff wrote: > On Tue, Nov 20, 2012 at 09:39:56AM +0900, Simon Horman wrote: > > On Mon, Nov 19, 2012 at 10:13:22AM -0800, Ben Pfaff wrote: > > > On Mon, Nov 19, 2012 at 02:59:29PM +0900, Simon Horman wrote: > > > > Allow only OpenFlow 12 as a flow dump

[ovs-dev] [PATCH] ovs-ofctl: Don't rely on stat() to check unix sockets.

2012-11-19 Thread Ethan Jackson
ESX supports unix sockets, but they don't manifest themselves in file system like they do on Linux. Instead of using stat to check if a unix socket exist, this patch simply tries to open it instead. Signed-off-by: Ethan Jackson --- lib/stream-unix.c |1 - utilities/ovs-ofctl.c | 40 ++

Re: [ovs-dev] [PATCH 2/8] ofp-util: Flow Dump Protocol for OpenFlow 12

2012-11-19 Thread Ben Pfaff
On Tue, Nov 20, 2012 at 09:39:56AM +0900, Simon Horman wrote: > On Mon, Nov 19, 2012 at 10:13:22AM -0800, Ben Pfaff wrote: > > On Mon, Nov 19, 2012 at 02:59:29PM +0900, Simon Horman wrote: > > > Allow only OpenFlow 12 as a flow dump protocol for OpenFlow12. > > > Allow OpenFlow10 and NXM as flow du

Re: [ovs-dev] [PATCH 2/8] ofp-util: Flow Dump Protocol for OpenFlow 12

2012-11-19 Thread Simon Horman
On Mon, Nov 19, 2012 at 10:13:22AM -0800, Ben Pfaff wrote: > On Mon, Nov 19, 2012 at 02:59:29PM +0900, Simon Horman wrote: > > Allow only OpenFlow 12 as a flow dump protocol for OpenFlow12. > > Allow OpenFlow10 and NXM as flow dump protocols for other OpenFlow versions. > > This only changes the be

[ovs-dev] [so_error 3/3] socket-util: Remove get_socket_error().

2012-11-19 Thread Ben Pfaff
It has no remaining users. Signed-off-by: Ben Pfaff --- lib/socket-util.c | 13 - lib/socket-util.h |1 - python/ovs/socket_util.py |6 -- 3 files changed, 0 insertions(+), 20 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index 4843cc5

[ovs-dev] [so_error 2/3] socket-util: Avoid using SO_ERROR.

2012-11-19 Thread Ben Pfaff
ESX doesn't implement it, and there's another approach that should work everywhere, so drop back to that. Signed-off-by: Ben Pfaff --- lib/socket-util.c | 13 +++-- python/ovs/socket_util.py | 18 -- 2 files changed, 27 insertions(+), 4 deletions(-) diff --gi

[ovs-dev] [so_error 1/3] python/ovs/socket_util: Fix error path in set_nonblocking.

2012-11-19 Thread Ben Pfaff
'e' is an exception, not a socket, so get_exception_errno() is the appropriate function to obtain an error code from it. Signed-off-by: Ben Pfaff --- python/ovs/socket_util.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/ovs/socket_util.py b/python/ovs/socket_

Re: [ovs-dev] [PATCH] automake: Always include route-table.h in sources.

2012-11-19 Thread Ben Pfaff
As an experiment, I moved lib/route-table.h into an "if ESX" block, and it still got distributed on a non-ESX build. Also, I notice that the BSD-only .c and .h files still get distributed even on non-BSD. So I think something else must have been at work. On Mon, Nov 19, 2012 at 03:18:05PM -0800,

Re: [ovs-dev] [PATCH] automake: Always include route-table.h in sources.

2012-11-19 Thread Ethan Jackson
Im pretty sure it did at some point in time. This patch has been sitting in my repo for a long time and I can't seem to figure out what problem I was trying to solve. I'll shelve it for now. Ethan On Mon, Nov 19, 2012 at 1:44 PM, Ben Pfaff wrote: > On Mon, Nov 19, 2012 at 01:32:01PM -0800, Et

[ovs-dev] [PATCH] dpif-netdev: Make odp_flow_key_to_flow() check more explicit.

2012-11-19 Thread Ben Pfaff
ODP_FIT_PERFECT has value 0 but this 'if' statement doesn't make much sense unless you happen to know that. Signed-off-by: Ben Pfaff --- lib/dpif-netdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index c9e3210..6835b2b 100644

Re: [ovs-dev] [PATCH] don't use select.POLL* constants

2012-11-19 Thread Ben Pfaff
On Tue, Nov 20, 2012 at 07:27:31AM +0900, FUJITA Tomonori wrote: > On Mon, 19 Nov 2012 09:12:07 -0800 > Ben Pfaff wrote: > > > Why doesn't Mac OS X have the POLL* constants? Mac OS X is a Unix > > variant and does have the poll() system call. > > https://github.com/mxcl/homebrew/issues/9531 Th

Re: [ovs-dev] [PATCH] don't use select.POLL* constants

2012-11-19 Thread FUJITA Tomonori
Hi, On Mon, 19 Nov 2012 09:12:07 -0800 Ben Pfaff wrote: > Why doesn't Mac OS X have the POLL* constants? Mac OS X is a Unix > variant and does have the poll() system call. https://github.com/mxcl/homebrew/issues/9531 ___ dev mailing list dev@openvswi

Re: [ovs-dev] OpenVswitch dev document

2012-11-19 Thread Justin Pettit
I've uploaded some slides that I presented last month that included some material on developing for OVS: http://openvswitch.org/slides/OVS-Development.pdf Hope it helps. --Justin On Nov 19, 2012, at 2:51 AM, 李强 wrote: > Hi,all. > I'm a student and now going on some project relat

Re: [ovs-dev] [PATCH] automake: Always include route-table.h in sources.

2012-11-19 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 01:32:01PM -0800, Ethan Jackson wrote: > The Linux, ESX, and BSD route table implementations all require > route-table.h. However, it was only being included as a source in > the Linux build. > > Signed-off-by: Ethan Jackson This shouldn't have any effect. It basically

[ovs-dev] [PATCH] automake: Always include route-table.h in sources.

2012-11-19 Thread Ethan Jackson
The Linux, ESX, and BSD route table implementations all require route-table.h. However, it was only being included as a source in the Linux build. Signed-off-by: Ethan Jackson --- lib/automake.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/automake.mk b/lib/au

Re: [ovs-dev] [PATCH 3/8] vswitchd: Configuration of allowed OpenFlow versions

2012-11-19 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 02:59:30PM +0900, Simon Horman wrote: > Versions may be configured using the protocols column of > the bridge table. The protocols column is a set which accepts zero > or more of the values: 'OpenFlow10' and 'OpenFlow12'. > > If the protocols column is empty, then OpenFlow1

Re: [ovs-dev] [PATCHv3] datapath: add skb mark matching and set action

2012-11-19 Thread Jesse Gross
On Sat, Nov 17, 2012 at 11:28 AM, Ansis Atteka wrote: > diff --git a/lib/flow.c b/lib/flow.c > index 7084079..816d561 100644 > --- a/lib/flow.c > +++ b/lib/flow.c > @@ -352,6 +352,7 @@ flow_extract(struct ofpbuf *packet, uint32_t skb_priority, > } > flow->in_port = ofp_in_port; > fl

[ovs-dev] [PATCH v3] datapath: Add support for VXLAN tunnels to Open vSwitch

2012-11-19 Thread Kyle Mestery
Add support for VXLAN tunnels to Open vSwitch. Add support for setting the destination UDP port on a per-port basis. This is done by adding a "dst_port" parameter to the port configuration. This is only applicable currently to VXLAN tunnels. The only difference in v3 of this patch series is the so

Re: [ovs-dev] VXLAN source port hashing performance problems

2012-11-19 Thread Kyle Mestery (kmestery)
On Nov 19, 2012, at 12:16 PM, Jesse Gross wrote: > On Fri, Nov 16, 2012 at 2:30 PM, Kyle Mestery (kmestery) > wrote: >> On Nov 16, 2012, at 3:31 PM, Kyle Mestery (kmestery) >> wrote: >>> On Nov 16, 2012, at 3:18 PM, Jesse Gross wrote: On Fri, Nov 16, 2012 at 1:00 PM, Kyle Mestery (kmester

Re: [ovs-dev] VXLAN source port hashing performance problems

2012-11-19 Thread Jesse Gross
On Fri, Nov 16, 2012 at 2:30 PM, Kyle Mestery (kmestery) wrote: > On Nov 16, 2012, at 3:31 PM, Kyle Mestery (kmestery) > wrote: >> On Nov 16, 2012, at 3:18 PM, Jesse Gross wrote: >>> On Fri, Nov 16, 2012 at 1:00 PM, Kyle Mestery (kmestery) >>> wrote: On Nov 15, 2012, at 3:32 PM, Kyle Mest

Re: [ovs-dev] [PATCH 2/8] ofp-util: Flow Dump Protocol for OpenFlow 12

2012-11-19 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 02:59:29PM +0900, Simon Horman wrote: > Allow only OpenFlow 12 as a flow dump protocol for OpenFlow12. > Allow OpenFlow10 and NXM as flow dump protocols for other OpenFlow versions. > This only changes the behaviour prior to this patch in the case of OpenFlow12 > which seeme

Re: [ovs-dev] [PATCH 1/8] connmgr: Use version of underlying rconn

2012-11-19 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 02:59:28PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman Applied to master. Thank you! I think it's possible for ofconn_get_protocol() to return OFPUTIL_P_NONE in some cases for sending asynchronous messages, so I updated ofconn_receives_async_msg() to return

Re: [ovs-dev] [PATCH v6 0/8] Run-Time Open Flow Version Configuration

2012-11-19 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 02:59:27PM +0900, Simon Horman wrote: > This series adds run-time configuration of allowed OpenFlow versions to > ovs-vswtichd, ovs-ofctl and ovs-controller; and adds tests for Open Flow > 1.2 messages that utilise the run-time configuration of allowed OpenFlow > versions. >

Re: [ovs-dev] [PATCH] vswitchd: Make Interface's ofport a persistent column.

2012-11-19 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 09:09:34AM -0800, Gurucharan Shetty wrote: > Currently, the 'ofport' column in Interface table is > ephemeral and is populated by vswitchd everytime it is > started or when a new interface is created with vswitchd > running. > > Making it persistent lets vswitchd try and as

[ovs-dev] [PATCH] vswitchd: Make Interface's ofport a persistent column.

2012-11-19 Thread Gurucharan Shetty
Currently, the 'ofport' column in Interface table is ephemeral and is populated by vswitchd everytime it is started or when a new interface is created with vswitchd running. Making it persistent lets vswitchd try and assign the same ofport number to a particular interface across restarts. This is

Re: [ovs-dev] [PATCH] don't use select.POLL* constants

2012-11-19 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 03:50:52AM +0900, FUJITA Tomonori wrote: > Python doesn't have select.POLL* constants on some architectures > (e.g. MacOSX). This code needs to define the constants for itself. It > uses select.POLL* constants only internally (doesn't pass them > outside). So there is no har

Re: [ovs-dev] OpenVswitch dev document

2012-11-19 Thread Ben Pfaff
On Mon, Nov 19, 2012 at 03:51:45PM +0800, wrote: > I'm a student and now going on some project related to OpenVswtich. But > the source code seems so complicated to me. Do you have development > document about openvswitch? If you have, could you please mail me a copy? The PORTING file at

Re: [ovs-dev] [cleanups 06/12] dpif: Don't log warning for ENOENT with dpif_port_exists().

2012-11-19 Thread Justin Pettit
On Nov 16, 2012, at 9:46 AM, Ben Pfaff wrote: > On Fri, Nov 16, 2012 at 12:02:59AM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > It seems fine, but the commit message should explain why we're doing > this. Done. --Justin ___ de