On Nov 1, 2012, at 6:53 PM, Ben Pfaff wrote:
> On Thu, Nov 01, 2012 at 06:11:00PM -0700, Justin Pettit wrote:
>> Below, you should find an incremental.
>
> The incremental looks good. Thank you!
Thank you for the reviews! I just pushed it.
--Justin
_
On Tue, Oct 30, 2012 at 10:23 PM, Linus Torvalds
wrote:
> On Tue, Oct 30, 2012 at 6:36 PM, Sasha Levin wrote:
>>
>> I can either rebase that on top of mainline, or we can ask maintainers
>> to take it to their own trees if you take only 01/16 into mainline.
>> What would you prefer?
>
> I don't r
On Thu, Nov 01, 2012 at 06:11:00PM -0700, Justin Pettit wrote:
> Below, you should find an incremental.
The incremental looks good. Thank you!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Nov 1, 2012 at 7:33 AM, Christoph Lameter wrote:
> On Thu, 1 Nov 2012, Shan Wei wrote:
>
>> But for different field in same per-cpu variable, how to guarantee n_missed
>> and n_hit are from same cpu?
>> this_cpu_read(dp->stats_percpu->n_missed);
>> [processor changed]
>> this_cpu_read(dp->
On Nov 1, 2012, at 11:24 AM, Ben Pfaff wrote:
>> @@ -47,6 +47,11 @@ v1.9.0 - xx xxx
>> - The ofproto library is now responsible for assigning OpenFlow port
>> numbers. An ofproto implementation should assign them when
>> port_construct() is called.
>> +- All dpif-based b
(There isn't any difference.)
Based on a conversation in #openvswitch.
Signed-off-by: Ben Pfaff
---
FAQ | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/FAQ b/FAQ
index b14bfa4..911dbf8 100644
--- a/FAQ
+++ b/FAQ
@@ -168,6 +168,21 @@ A: Tunnel and patch vi
On Thu, Nov 01, 2012 at 04:51:17PM -0700, Jesse Gross wrote:
> On Thu, Nov 1, 2012 at 4:39 PM, Ben Pfaff wrote:
> > On Thu, Nov 01, 2012 at 04:13:15PM -0700, Jesse Gross wrote:
> >> On Thu, Nov 1, 2012 at 3:50 PM, Ben Pfaff wrote:
> >> > On Thu, Nov 01, 2012 at 03:48:33PM -0700, Jesse Gross wrote
On Thu, Nov 1, 2012 at 4:40 PM, Ben Pfaff wrote:
> On Thu, Nov 01, 2012 at 04:17:22PM -0700, Jesse Gross wrote:
>> We can format ipv4_tunnel keys from the kernel but can't currently
>> parse them. Userspace doesn't know how to do anything with this
>> information but this support enables utilitie
On Thu, Nov 1, 2012 at 4:39 PM, Ben Pfaff wrote:
> On Thu, Nov 01, 2012 at 04:13:15PM -0700, Jesse Gross wrote:
>> On Thu, Nov 1, 2012 at 3:50 PM, Ben Pfaff wrote:
>> > On Thu, Nov 01, 2012 at 03:48:33PM -0700, Jesse Gross wrote:
>> >> On Thu, Nov 1, 2012 at 1:26 PM, Pravin Shelar wrote:
>> >> >
On Wed, Oct 31, 2012 at 5:20 PM, Mehak Mahajan wrote:
> diff --git a/NEWS b/NEWS
> index f5d7f9e..ab629d0 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -38,6 +38,8 @@ post-v1.8.0
> - The autopath action.
> - Interface type "null".
> - Numeric values for reserved ports (see "ovs-
On Thu, Nov 01, 2012 at 04:18:05PM -0700, Justin Pettit wrote:
> Suggested-by: Ben Pfaff
> Signed-off-by: Justin Pettit
Thanks, looks good to me.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Nov 01, 2012 at 04:17:22PM -0700, Jesse Gross wrote:
> We can format ipv4_tunnel keys from the kernel but can't currently
> parse them. Userspace doesn't know how to do anything with this
> information but this support enables utilities like ovs-dpctl and
> ovs-appctl ofproto/trace to show
On Thu, Nov 01, 2012 at 04:13:15PM -0700, Jesse Gross wrote:
> On Thu, Nov 1, 2012 at 3:50 PM, Ben Pfaff wrote:
> > On Thu, Nov 01, 2012 at 03:48:33PM -0700, Jesse Gross wrote:
> >> On Thu, Nov 1, 2012 at 1:26 PM, Pravin Shelar wrote:
> >> >
> >> > On Thu, Nov 1, 2012 at 1:09 PM, Ben Pfaff wrote
On Thu, Nov 01, 2012 at 04:05:31PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Looks good to me, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Suggested-by: Ben Pfaff
Signed-off-by: Justin Pettit
---
ofproto/ofproto-dpif-sflow.c |4 +---
ofproto/ofproto-dpif-sflow.h |2 +-
ofproto/ofproto-dpif.c |2 +-
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/ofproto/ofproto-dpif-sflow.c b/ofproto/ofproto-dpif-sf
We can format ipv4_tunnel keys from the kernel but can't currently
parse them. Userspace doesn't know how to do anything with this
information but this support enables utilities like ovs-dpctl and
ovs-appctl ofproto/trace to show useful information.
Bug #13785
Signed-off-by: Jesse Gross
---
li
On Thu, Nov 1, 2012 at 3:50 PM, Ben Pfaff wrote:
> On Thu, Nov 01, 2012 at 03:48:33PM -0700, Jesse Gross wrote:
>> On Thu, Nov 1, 2012 at 1:26 PM, Pravin Shelar wrote:
>> >
>> > On Thu, Nov 1, 2012 at 1:09 PM, Ben Pfaff wrote:
>> >>
>> >> On Thu, Nov 01, 2012 at 12:47:47PM -0700, Pravin B Shelar
Signed-off-by: Justin Pettit
---
lib/dpif.c |7 +++
lib/dpif.h |1 +
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/lib/dpif.c b/lib/dpif.c
index 952a502..0093f61 100644
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -372,6 +372,13 @@ dpif_base_name(const struct dpif *dpif)
On Thu, Nov 01, 2012 at 03:48:33PM -0700, Jesse Gross wrote:
> On Thu, Nov 1, 2012 at 1:26 PM, Pravin Shelar wrote:
> >
> > On Thu, Nov 1, 2012 at 1:09 PM, Ben Pfaff wrote:
> >>
> >> On Thu, Nov 01, 2012 at 12:47:47PM -0700, Pravin B Shelar wrote:
> >> > Following patch fixes `ovs-appctl ofproto/
On Thu, Nov 1, 2012 at 1:26 PM, Pravin Shelar wrote:
>
> On Thu, Nov 1, 2012 at 1:09 PM, Ben Pfaff wrote:
>>
>> On Thu, Nov 01, 2012 at 12:47:47PM -0700, Pravin B Shelar wrote:
>> > Following patch fixes `ovs-appctl ofproto/trace` command with
>> > ipv4_tunnel key in flow.
>> >
>> > Bug #13785
>>
oferta de prestamo 3%___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Nov 01, 2012 at 02:00:03PM -0700, Jesse Gross wrote:
> On Thu, Nov 1, 2012 at 1:55 PM, Ben Pfaff wrote:
> > INSTALL recommends running "make modules_install" but it didn't mention
> > that this has to be done from datapath/linux. This commit makes this work
> > from the top-level build di
On Thu, Nov 1, 2012 at 1:55 PM, Ben Pfaff wrote:
> INSTALL recommends running "make modules_install" but it didn't mention
> that this has to be done from datapath/linux. This commit makes this work
> from the top-level build directory.
>
> (Another solution would be to update INSTALL, but this a
INSTALL recommends running "make modules_install" but it didn't mention
that this has to be done from datapath/linux. This commit makes this work
from the top-level build directory.
(Another solution would be to update INSTALL, but this approach seems a
little easier for the user.)
Signed-off-by
On Thu, Nov 01, 2012 at 01:26:48PM -0700, Pravin Shelar wrote:
> On Thu, Nov 1, 2012 at 1:09 PM, Ben Pfaff wrote:
>
> > On Thu, Nov 01, 2012 at 12:47:47PM -0700, Pravin B Shelar wrote:
> > > Following patch fixes `ovs-appctl ofproto/trace` command with
> > > ipv4_tunnel key in flow.
> > >
> > > B
On Thu, Nov 1, 2012 at 1:09 PM, Ben Pfaff wrote:
> On Thu, Nov 01, 2012 at 12:47:47PM -0700, Pravin B Shelar wrote:
> > Following patch fixes `ovs-appctl ofproto/trace` command with
> > ipv4_tunnel key in flow.
> >
> > Bug #13785
> > Signed-off-by: Pravin B Shelar
>
> Thank you!
>
> Will you ple
On Thu, Nov 01, 2012 at 12:47:47PM -0700, Pravin B Shelar wrote:
> Following patch fixes `ovs-appctl ofproto/trace` command with
> ipv4_tunnel key in flow.
>
> Bug #13785
> Signed-off-by: Pravin B Shelar
Thank you!
Will you please add a test to tests/odp.at?
Please use "%"SCNi32 for flags inst
On Thu, Nov 01, 2012 at 10:06:55AM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
This is really good (thank you!), but I think it can be improved.
First, I don't think it's a good idea to emphasize a kernel/user split
here. That's an implementation detail that I don't really want to
Following patch fixes `ovs-appctl ofproto/trace` command with
ipv4_tunnel key in flow.
Bug #13785
Signed-off-by: Pravin B Shelar
---
lib/odp-util.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 9ed17ed..ce37061 100644
--- a
On Thu, Nov 01, 2012 at 12:32:29AM -0700, Justin Pettit wrote:
> This commit switches to using a single backing datapath (called
> "ovs-datapath") for all bridges of that datapath's type. Previously,
> resources couldn't be shared across bridges, since each was in its own
> datapath. This change
On 11/01/12 at 11:01am, Ben Pfaff wrote:
> On Thu, Nov 1, 2012 at 10:47 AM, Thomas Graf wrote:
> > I was considering to add a notification bus allowing for ovs-vsctl
> > to sleep and wait for a success or error notification and thus block
> > until the operation has been carried out by vswitchd or
On Thu, Nov 1, 2012 at 10:47 AM, Thomas Graf wrote:
> I was considering to add a notification bus allowing for ovs-vsctl
> to sleep and wait for a success or error notification and thus block
> until the operation has been carried out by vswitchd or a timeout is
> reached. It would be more flexibl
On 11/01/12 at 09:44am, Ben Pfaff wrote:
> ovs-vsctl does not make Netlink calls. It only updates the database,
> via ovsdb-server. ovs-vswitchd does make the Netlink calls, but it
> doesn't talk directly to ovs-vsctl. It only monitors the database.
>
> > Currently the logfile has to be consult
Signed-off-by: Justin Pettit
---
FAQ | 35 +++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/FAQ b/FAQ
index 0e7713b..177f992 100644
--- a/FAQ
+++ b/FAQ
@@ -283,6 +283,41 @@ A: No. ERSPAN is an undocumented proprietary protocol.
As an
alt
On Thu, Nov 01, 2012 at 12:23:40AM -0700, Justin Pettit wrote:
> On Oct 23, 2012, at 11:18 AM, Ben Pfaff wrote:
> > GCC says:
> >
> > ../ofproto/ofproto-dpif.c: In function "show_dp_format":
> > ../ofproto/ofproto-dpif.c:7371: error: format "%llu" expects type "long l\
> > ong unsigned int", but
On Nov 1, 2012, at 2:23 AM, Ben Pfaff wrote:
> ofproto has a concept of "hidden" OpenFlow tables. Currently these are
> used internally only for ofproto-dpif for a couple of unimportant
> purposes. However, hidden tables were not hidden well enough, because
> OFTest was able to spot ofproto-dpif
On Thu, Nov 01, 2012 at 02:30:29PM +, Thomas Graf wrote:
> On 10/26/12 at 07:44am, Ben Pfaff wrote:
> > On Fri, Oct 26, 2012 at 09:22:35PM +0800, Cong Wang wrote:
> > > On 10/25/2012 11:20 PM, Ben Pfaff wrote:
> > > >Furthermore, ovs-vsctl is meant to be generic in the sense that you can
> > >
De Bollou ValérieBonne journée,J'aime à investir dans votre pays une bonne affaire lucrative, comme les affaires immobilières qui donneront lucratives, malheureusement pour moi, mon père est deccédé pendant les crises en Côte d'Ivoire par coup de fusil sur son chemin à un de ses sites d'exploitatio
Account| Customer Center Account ending in XXX9
An considerable announcement regarding latest Refused Activity ready for
you.
Enter website to Overview Message
Honored Discover Client,
There is an significant message waiting for
2012/11/1 Christoph Lameter
>
> > In addition, following usage of per_cpu_ptr can be replaced by
> this_cpu_read.
> >
> > cpu=get_cpu()
> >
> > *per_cpu_ptr(p,cpu)
> >
> >
> > put_cpu()
>
> Right.
>
>
Thanks very much,
I will resubmit new patchset.
On Thu, 1 Nov 2012, Shan Wei wrote:
> But for different field in same per-cpu variable, how to guarantee n_missed
> and n_hit are from same cpu?
> this_cpu_read(dp->stats_percpu->n_missed);
> [processor changed]
> this_cpu_read(dp->stats_percpu->n_hit);
What does current guarantee that? If it is
On 10/26/12 at 07:44am, Ben Pfaff wrote:
> On Fri, Oct 26, 2012 at 09:22:35PM +0800, Cong Wang wrote:
> > On 10/25/2012 11:20 PM, Ben Pfaff wrote:
> > >Furthermore, ovs-vsctl is meant to be generic in the sense that you can
> > >use an ovs-vsctl built in one place (on one OS) to control a switch an
Christoph Lameter said, at 2012/11/1 1:39:
> On Wed, 31 Oct 2012, Shan Wei wrote:
>
>> --- a/net/openvswitch/datapath.c
>> +++ b/net/openvswitch/datapath.c
>> @@ -208,7 +208,7 @@ void ovs_dp_process_received_packet(struct vport *p,
>> struct sk_buff *skb)
>> int error;
>> int key_len;
>
This commit switches to using a single backing datapath (called
"ovs-datapath") for all bridges of that datapath's type. Previously,
resources couldn't be shared across bridges, since each was in its own
datapath. This change will allow sharing of tunnels and cheaper patch
ports to be added in th
On Oct 23, 2012, at 11:18 AM, Ben Pfaff wrote:
> "git am" says:
>
>Applying: ofproto-dpif: Use a single underlying datapath across multiple
> br\
> idges.
>/home/blp/ovs/.git/rebase-apply/patch:696: trailing whitespace.
>return EOF;
>warning: 1 line adds whitespace error
ofproto has a concept of "hidden" OpenFlow tables. Currently these are
used internally only for ofproto-dpif for a couple of unimportant
purposes. However, hidden tables were not hidden well enough, because
OFTest was able to spot ofproto-dpif's hidden table and, seeing that it
had a couple of fl
The OpenFlow 1.0 specification says:
Emergency flow mod messages must have timeout values set to zero.
Otherwise, the switch must refuse the addition and respond with an
ofp_error_msg with OFPET_FLOW_MOD_FAILED type and
OFPFMFC_BAD_EMERG_TIMEOUT code.
but Open vSwitch reported OFP
47 matches
Mail list logo
