[ovs-dev] Сотрудничество

2012-10-30 Thread Юлия Халикова
Добрый день Мы заинтересованы в размещении платных ссылок на сайте OPENVSWITCH. Можем предложить 1200 руб/месяц. Перечисление любым удобным для вас способом. С уважением и надеждой на сотрудничество, Юлия Халикова ___ dev mailing list dev@openvswitch.or

[ovs-dev] [PATCH] Accept the traffic marked with RARP eth_type.

2012-10-30 Thread Mehak Mahajan
With this commit, OVS will accept the traffic with eth_type RARP. Signed-off-by: Mehak Mahajan --- datapath/flow.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index c70daee..c5f1b53 100644 --- a/datapath/flow.c +++ b/datapath/flow.

Re: [ovs-dev] the problem of bridge wlan

2012-10-30 Thread Ben Pfaff
On Wed, Oct 31, 2012 at 09:51:43AM +0800, wrote: >using openvswitch wireless > the step follows: > 1. > bridge name: brwlan0 > wireless name: wlan0 > virtual nic : tap0 > 2. > brwlan0 content wlan0 and tap0. > 3. > This time and the external network through. > 4. > qemu-system-x86_64 -

Re: [ovs-dev] [Single DP 14/15] dpif: Add new dpif_port_exists() function.

2012-10-30 Thread Ben Pfaff
On Tue, Oct 30, 2012 at 05:58:02PM -0700, Justin Pettit wrote: > On Oct 22, 2012, at 4:35 PM, Ben Pfaff wrote: > > > On Thu, Oct 18, 2012 at 12:51:59PM -0700, Justin Pettit wrote: > >> Provide the ability to determine whether a port exists in a datapath > >> without having to deal with a "dpif_po

Re: [ovs-dev] [Single DP 10/15] ofproto-dpif: Add ovs-appctl commands for ovs-dpctl functions.

2012-10-30 Thread Ben Pfaff
On Tue, Oct 30, 2012 at 05:37:07PM -0700, Justin Pettit wrote: > > On Oct 22, 2012, at 3:54 PM, Ben Pfaff wrote: > > > On Thu, Oct 18, 2012 at 12:51:55PM -0700, Justin Pettit wrote: > >> These commands will be useful in a future commit that makes multiple > >> bridges share a single backing data

Re: [ovs-dev] [Single DP 08/15] Separate OpenFlow port numbers from datapath ones.

2012-10-30 Thread Ben Pfaff
On Tue, Oct 30, 2012 at 03:34:32PM -0700, Justin Pettit wrote: > On Oct 22, 2012, at 3:11 PM, Ben Pfaff wrote: > > We want to avoid quickly reusing OpenFlow port numbers. Previously, > > that was indirectly implemented through dpif-linux, which makes an > > effort to avoid quickly reusing kernel

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2012 at 8:24 PM, Al Viro wrote: > > Oh, well... there go my blackmail plans ;-) Seriously, though, I'm at loss > regarding several embedded architectures - arch/score, in particular, > seems to be completely orphaned. Don't worry about it. Do a best-effort, and if nobody ever rea

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Al Viro
On Tue, Oct 30, 2012 at 07:48:19PM -0700, Linus Torvalds wrote: > On Tue, Oct 30, 2012 at 7:24 PM, Al Viro wrote: > > > > BTW, how serious have you been back at KS when you were talking about > > pull requests killing a thousand of lines of code being acceptable > > at any point in the cycle? > >

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2012 at 7:24 PM, Al Viro wrote: > > BTW, how serious have you been back at KS when you were talking about > pull requests killing a thousand of lines of code being acceptable > at any point in the cycle? Well... I'm absolutely a lot more open to pull requests that kill code than n

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Al Viro
On Tue, Oct 30, 2012 at 06:25:46PM -0700, Linus Torvalds wrote: > But whatever. This series has gotten way too much bike-shedding > anyway. I think it should just be applied, since it does remove lines > of code overall. I'd even possibly apply it to mainline, but it seems > to be against linux-ne

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2012 at 6:36 PM, Sasha Levin wrote: > > I can either rebase that on top of mainline, or we can ask maintainers > to take it to their own trees if you take only 01/16 into mainline. > What would you prefer? I don't really care deeply. The only reason to merge it now would be to avo

[ovs-dev] the problem of bridge wlan

2012-10-30 Thread 田杰
dear all openvswich dev: using openvswitch wireless the step follows: 1. bridge name: brwlan0 wireless name: wlan0 virtual nic : tap0 2. brwlan0 content wlan0 and tap0. 3. This time and the external network through. 4. qemu-system-x86_64 -m 2048 -hda ./winxptemp.img -net nic,macaddr=00:43

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Sasha Levin
Hi Linus, > But whatever. This series has gotten way too much bike-shedding > anyway. I think it should just be applied, since it does remove lines > of code overall. I'd even possibly apply it to mainline, but it seems > to be against linux-next. Yup, I switched to using -next because I've been

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Steven Rostedt
On Tue, 2012-10-30 at 18:25 -0700, Linus Torvalds wrote: > On Tue, Oct 30, 2012 at 6:16 PM, Steven Rostedt wrote: > > > > ({\ > > sizeof(val) <= 4 ? hash_32(val, bits) : hash_long(val, bits); \ > > }) > > > > Is the better

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2012 at 6:16 PM, Steven Rostedt wrote: > > ({\ > sizeof(val) <= 4 ? hash_32(val, bits) : hash_long(val, bits); \ > }) > > Is the better way to go. We are C programmers, we like to see the ?: on > a single l

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Steven Rostedt
On Tue, 2012-10-30 at 20:33 -0400, Sasha Levin wrote: > On Tue, Oct 30, 2012 at 5:42 PM, Tejun Heo wrote: > > Hello, > > > > Just some nitpicks. > > > > On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote: > >> +/* Use hash_32 when possible to allow for fast 32bit hashing in 64bit > >> ke

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Sasha Levin
On Tue, Oct 30, 2012 at 8:51 PM, Jim Rees wrote: > Sasha Levin wrote: > > On Tue, Oct 30, 2012 at 5:42 PM, Tejun Heo wrote: > > Hello, > > > > Just some nitpicks. > > > > On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote: > >> +/* Use hash_32 when possible to allow for fas

Re: [ovs-dev] [Single DP 14/15] dpif: Add new dpif_port_exists() function.

2012-10-30 Thread Justin Pettit
On Oct 22, 2012, at 4:35 PM, Ben Pfaff wrote: > On Thu, Oct 18, 2012 at 12:51:59PM -0700, Justin Pettit wrote: >> Provide the ability to determine whether a port exists in a datapath >> without having to deal with a "dpif_port" structure as with >> dpif_port_query_by_name(). A future patch will

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Jim Rees
Sasha Levin wrote: On Tue, Oct 30, 2012 at 5:42 PM, Tejun Heo wrote: > Hello, > > Just some nitpicks. > > On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote: >> +/* Use hash_32 when possible to allow for fast 32bit hashing in 64bit kernels. */ >> +#define hash_min(val, b

Re: [ovs-dev] [Single DP 13/15] ofproto: Add type "run" and "run_fast" provider methods.

2012-10-30 Thread Justin Pettit
On Oct 22, 2012, at 4:32 PM, Ben Pfaff wrote: > On Thu, Oct 18, 2012 at 12:51:58PM -0700, Justin Pettit wrote: >> Add the ability for ofproto providers to have top-level "run" and >> "run_fast" methods, similar to the current ofproto ones. There are no >> current users, but this will be useful i

Re: [ovs-dev] [Single DP 10/15] ofproto-dpif: Add ovs-appctl commands for ovs-dpctl functions.

2012-10-30 Thread Justin Pettit
On Oct 22, 2012, at 3:54 PM, Ben Pfaff wrote: > On Thu, Oct 18, 2012 at 12:51:55PM -0700, Justin Pettit wrote: >> These commands will be useful in a future commit that makes multiple >> bridges share a single backing datapath. The ovs-dpctl commands will >> show information about the backing da

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Sasha Levin
On Tue, Oct 30, 2012 at 5:42 PM, Tejun Heo wrote: > Hello, > > Just some nitpicks. > > On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote: >> +/* Use hash_32 when possible to allow for fast 32bit hashing in 64bit >> kernels. */ >> +#define hash_min(val, bits)

Re: [ovs-dev] [Single DP 09/15] tests: Rewrite unit tests to not expect bridge with odp zero.

2012-10-30 Thread Justin Pettit
On Oct 22, 2012, at 3:21 PM, Ben Pfaff wrote: > "git am" says: > >Applying: tests: Rewrite unit tests to not expect bridge with odp zero. >/home/blp/ovs/.git/rebase-apply/patch:2440: trailing whitespace. > [add-br test-br0], >/home/blp/ovs/.git/rebase-apply/patch:2472: trailing

Re: [ovs-dev] [Single DP 08/15] Separate OpenFlow port numbers from datapath ones.

2012-10-30 Thread Justin Pettit
On Oct 22, 2012, at 3:11 PM, Ben Pfaff wrote: > "git am" says: > >Applying: Separate OpenFlow port numbers from datapath ones. >/home/blp/ovs/.git/rebase-apply/patch:230: trailing whitespace. > >warning: 1 line adds whitespace errors. >Press any key to continue… Whoops. > In t

Re: [ovs-dev] [PATCH v4] datapath: Remove tunnel header caching.

2012-10-30 Thread Jesse Gross
On Tue, Oct 30, 2012 at 2:15 PM, Pravin B Shelar wrote: > v3-v4: > - Updated debian cheangelog. > - Added comment for reserved bit in TNL_F_ flags. > v2-v3: > - Fixed according to comments from Jesse. > - Dropped flow-refcount related changes, Jesse will >

Re: [ovs-dev] [PATCH v3] netdev: Deprecate CAPWAP support.

2012-10-30 Thread Jesse Gross
On Tue, Oct 30, 2012 at 2:15 PM, Pravin B Shelar wrote: > v2-v3: > - Updated changelog > - Removed warning from kernel datapath. > v1-v2: > - Added userspace warning. > - Added a NEWS item. > --8<--cut here-->8-- > > T

Re: [ovs-dev] [PATCH v3] datapath: Fix sparse warning for symbol 'BUILD_BUG_ON_NOT_POWER_OF_2'

2012-10-30 Thread Jesse Gross
On Tue, Oct 30, 2012 at 2:15 PM, Pravin B Shelar wrote: > v2-v3: > - Added bug.h to Modules.mk > v1-v2: > - Moved BUILD_BUG_ON_NOT_POWER_OF_2 symbol definition for bug.h > --8<--cut here-->8-- > > BUILD_BUG_ON_NOT_POWER_OF_2 symbol is

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Tejun Heo
Hello, Just some nitpicks. On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote: > +/* Use hash_32 when possible to allow for fast 32bit hashing in 64bit > kernels. */ > +#define hash_min(val, bits) > \ > +({

[ovs-dev] [PATCH v4] datapath: Remove tunnel header caching.

2012-10-30 Thread Pravin B Shelar
v3-v4: - Updated debian cheangelog. - Added comment for reserved bit in TNL_F_ flags. v2-v3: - Fixed according to comments from Jesse. - Dropped flow-refcount related changes, Jesse will post seperate patch for same. v1-v2: - Fixed capwap fragment c

[ovs-dev] [PATCH v3] netdev: Deprecate CAPWAP support.

2012-10-30 Thread Pravin B Shelar
v2-v3: - Updated changelog - Removed warning from kernel datapath. v1-v2: - Added userspace warning. - Added a NEWS item. --8<--cut here-->8-- The CAPWAP implementation is just the encapsulation format and therefore re

[ovs-dev] [PATCH v3] datapath: Fix sparse warning for symbol 'BUILD_BUG_ON_NOT_POWER_OF_2'

2012-10-30 Thread Pravin B Shelar
v2-v3: - Added bug.h to Modules.mk v1-v2: - Moved BUILD_BUG_ON_NOT_POWER_OF_2 symbol definition for bug.h --8<--cut here-->8-- BUILD_BUG_ON_NOT_POWER_OF_2 symbol is moved from kernel.h to bug.h in 3.4. Therefore sparse is giving warn

Re: [ovs-dev] [PATCH v8 16/16] tracing output: use new hashtable implementation

2012-10-30 Thread Steven Rostedt
On Tue, 2012-10-30 at 14:46 -0400, Sasha Levin wrote: > Switch tracing to use the new hashtable implementation. This reduces the > amount of generic unrelated code in the tracing module. > > Signed-off-by: Sasha Levin Acked-by: Steven Rostedt -- Steve ___

Re: [ovs-dev] [PATCH v8 06/16] tracepoint: use new hashtable implementation

2012-10-30 Thread Mathieu Desnoyers
* Sasha Levin (levinsasha...@gmail.com) wrote: > Switch tracepoints to use the new hashtable implementation. This reduces the > amount of generic unrelated code in the tracepoints. > > Signed-off-by: Sasha Levin Reviewed-by: Mathieu Desnoyers > --- > kernel/tracepoint.c | 25 +

Re: [ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Mathieu Desnoyers
* Sasha Levin (levinsasha...@gmail.com) wrote: > This hashtable implementation is using hlist buckets to provide a simple > hashtable to prevent it from getting reimplemented all over the kernel. > > Signed-off-by: Sasha Levin Reviewed-by: Mathieu Desnoyers > --- > > Changes from v8: > > -

[ovs-dev] [PATCH v8 16/16] tracing output: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch tracing to use the new hashtable implementation. This reduces the amount of generic unrelated code in the tracing module. Signed-off-by: Sasha Levin --- kernel/trace/trace_output.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/kernel/trace/trace_o

[ovs-dev] [PATCH v8 15/16] openvswitch: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch openvswitch to use the new hashtable implementation. This reduces the amount of generic unrelated code in openvswitch. Signed-off-by: Sasha Levin --- net/openvswitch/vport.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/net/openv

[ovs-dev] [PATCH v8 14/16] net, rds: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch rds to use the new hashtable implementation. This reduces the amount of generic unrelated code in rds. Signed-off-by: Sasha Levin --- net/rds/bind.c | 20 +-- net/rds/connection.c | 100 ++- 2 files changed, 53 insertions(+),

[ovs-dev] [PATCH v8 13/16] lockd: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch lockd to use the new hashtable implementation. This reduces the amount of generic unrelated code in lockd. Signed-off-by: Sasha Levin --- fs/lockd/svcsubs.c | 58 ++ 1 file changed, 28 insertions(+), 30 deletions(-) diff --git a/fs/lock

[ovs-dev] [PATCH v8 12/16] dm: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch dm to use the new hashtable implementation. This reduces the amount of generic unrelated code in the dm. Signed-off-by: Sasha Levin --- drivers/md/dm-snap.c | 24 + drivers/md/persistent-data/dm-block-manager.c | 1 - .../persistent-data

[ovs-dev] [PATCH v8 11/16] net, l2tp: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch l2tp to use the new hashtable implementation. This reduces the amount of generic unrelated code in l2tp. Signed-off-by: Sasha Levin --- net/l2tp/l2tp_core.c| 140 +++- net/l2tp/l2tp_core.h| 15 -- net/l2tp/l2tp_debugfs.c | 19 +++--

[ovs-dev] [PATCH v8 10/16] dlm: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch dlm to use the new hashtable implementation. This reduces the amount of generic unrelated code in the dlm. Signed-off-by: Sasha Levin --- fs/dlm/lowcomms.c | 53 ++--- 1 file changed, 18 insertions(+), 35 deletions(-) diff --git a/fs/dlm/lo

[ovs-dev] [PATCH v8 09/16] SUNRPC/cache: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch cache to use the new hashtable implementation. This reduces the amount of generic unrelated code in the cache implementation. Signed-off-by: Sasha Levin --- net/sunrpc/cache.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/net/sunrpc/cache.c b/net/

[ovs-dev] [PATCH v8 08/16] block, elevator: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch elevator to use the new hashtable implementation. This reduces the amount of generic unrelated code in the elevator. This also removes the dymanic allocation of the hash table. The size of the table is constant so there's no point in paying the price of an extra dereference when accessing

[ovs-dev] [PATCH v8 07/16] net, 9p: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch 9p error table to use the new hashtable implementation. This reduces the amount of generic unrelated code in 9p. Signed-off-by: Sasha Levin --- net/9p/error.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/net/9p/error.c b/net/9p/error.c index 2

[ovs-dev] [PATCH v8 06/16] tracepoint: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch tracepoints to use the new hashtable implementation. This reduces the amount of generic unrelated code in the tracepoints. Signed-off-by: Sasha Levin --- kernel/tracepoint.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/kernel/tracepoint.c

[ovs-dev] [PATCH v8 05/16] mm/huge_memory: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch hugemem to use the new hashtable implementation. This reduces the amount of generic unrelated code in the hugemem. This also removes the dymanic allocation of the hash table. The size of the table is constant so there's no point in paying the price of an extra dereference when accessing i

[ovs-dev] [PATCH v8 04/16] workqueue: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch workqueues to use the new hashtable implementation. This reduces the amount of generic unrelated code in the workqueues. Signed-off-by: Sasha Levin --- kernel/workqueue.c | 86 ++ 1 file changed, 15 insertions(+), 71 deletions(-) diff -

[ovs-dev] [PATCH v8 03/16] mm, ksm: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch ksm to use the new hashtable implementation. This reduces the amount of generic unrelated code in the ksm module. Signed-off-by: Sasha Levin --- mm/ksm.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index 31ae5ea

[ovs-dev] [PATCH v8 02/16] userns: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch to using the new hashtable implementation to store user structs. This reduces the amount of generic unrelated code in kernel/user.c. Signed-off-by: Sasha Levin --- kernel/user.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/kernel/

[ovs-dev] [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Sasha Levin
This hashtable implementation is using hlist buckets to provide a simple hashtable to prevent it from getting reimplemented all over the kernel. Signed-off-by: Sasha Levin --- Changes from v8: - Addressed comments from Tejun Heo and Mathieu Desnoyers. include/linux/hashtable.h | 196 +++

Re: [ovs-dev] [PATCH v2] datapath: Add support for 3.6 kernel.

2012-10-30 Thread Jesse Gross
On Mon, Oct 29, 2012 at 8:49 PM, Pravin Shelar wrote: > On Mon, Oct 29, 2012 at 7:21 PM, Jesse Gross wrote: >> On Mon, Oct 29, 2012 at 2:32 PM, Pravin B Shelar wrote: >>> Signed-off-by: Pravin B Shelar >>> --- >>> datapath/datapath.c |4 ++-- >>> datapath/tunnel.c | 33

Re: [ovs-dev] [PATCH v3] datapath: Remove tunnel header caching.

2012-10-30 Thread Jesse Gross
On Mon, Oct 29, 2012 at 2:32 PM, Pravin B Shelar wrote: > Tunnel caching was added to reduce CPU utilization on TX path > by caching packet header, So performance gain is directly proportional > to number of skbs transferred. But with help of offloads skb are getting > larger. So there are less n

Re: [ovs-dev] [PATCH] datapath: Add Upstream id for GRE type.

2012-10-30 Thread Jesse Gross
On Mon, Oct 29, 2012 at 8:49 PM, Pravin Shelar wrote: > On Mon, Oct 29, 2012 at 6:56 PM, Jesse Gross wrote: >> On Mon, Oct 29, 2012 at 12:57 PM, Pravin Shelar wrote: >>> On Fri, Oct 26, 2012 at 11:32 AM, Jesse Gross wrote: Also, did you look at the userspace code to see whether it can hand

Re: [ovs-dev] [PATCH] netdev-vport: Warn users that pmtud is deprecated

2012-10-30 Thread Ansis Atteka
On Mon, Oct 29, 2012 at 8:33 PM, Jesse Gross wrote: > On Mon, Oct 29, 2012 at 9:22 AM, Ansis Atteka wrote: >> This is a complementary patch to the other one I sent out previously. >> The pupose of it is to make it more obvious that tunnel pmtud is >> deprecated and will be removed soon. >> >> Req

Re: [ovs-dev] [PATCH 3/8] nx-match: Do not check pre-requisites for load actions

2012-10-30 Thread Simon Horman
On Tue, Oct 30, 2012 at 09:59:24AM +0900, Simon Horman wrote: > On Mon, Oct 29, 2012 at 09:58:58AM -0700, Ben Pfaff wrote: > > On Sat, Oct 27, 2012 at 03:05:57PM +0900, Simon Horman wrote: > > > There are (or at least will be) cases where this check can produce false > > > positives. For example,