On Oct 22, 2012, at 4:32 PM, Ben Pfaff <b...@nicira.com> wrote:

> On Thu, Oct 18, 2012 at 12:51:58PM -0700, Justin Pettit wrote:
>> Add the ability for ofproto providers to have top-level "run" and
>> "run_fast" methods, similar to the current ofproto ones.  There are no
>> current users, but this will be useful in a future commit.
>> 
>> Signed-off-by: Justin Pettit <jpet...@nicira.com>
> 
> The box is misshapen here:
> /* ## --------------------------- ## */
> +/* ## Top-Level type Functions ## */
> +/* ## --------------------------- ## */
> and there should be a blank line following it.

Yikes.  That was very un-me.

> We should think about having a better way to iterate through ofproto
> types.

Agreed.

> Looks good.

Thanks!

--Justin


_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to