Signed-off-by: Ben Pfaff
---
This is an additional commit that, applied on top of the series that
I posted yesterday, makes it possible to run OFTest against an
Open vSwitch build tree with just "make check-oftest".
The previous series starts here:
http://openvswitch.org/pipermail/dev/201
This adds support for the OpenFlow 1.1+ copy_ttl_out action.
And also adds an NX copy_ttl_out action.
The implementation does not support copying in the case where the outermost
header is IP as it is unclear to me that Open vSwtich has a notion of an
inner IP header to copy the TLL from.
The hand
This adds support for the OpenFlow 1.1+ copy_ttl_out action.
And also adds an NX copy_ttl_out action.
The implementation does not support copying in the case where the outermost
header is IP as it is unclear to me that Open vSwtich has a notion of an
inner IP header to copy the TLL from.
The impl
This adds support for the OpenFlow 1.1+ set_mpls_ttl action.
And also adds an NX set_mpls_ttl action.
The handling of the TTL modification is entirely handled in userspace.
Signed-off-by: Simon Horman
---
include/openflow/nicira-ext.h | 12
lib/ofp-actions.c | 26 ++
This adds support for the OpenFlow 1.1+ dec_mpls_ttl action.
And also adds an NX dec_mpls_ttl action.
The handling of the TTL modification is entirely handled in userspace.
Signed-off-by: Simon Horman
---
include/openflow/nicira-ext.h |1 +
lib/flow.c|8
lib
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman and Ravi K.
Cc: Isaku Yamahata
Cc: Ravi K
Cc: Leo Alterman
Signed-off-by: Simon Horman
---
v2.3
* s/mpls_stack/mpls_bos/
There are (or at least will be) cases where this check can produce false
positives. For example, a flow which matches a non-MPLS packet and then
applies an MPLS push action followed by an action to load the MPLS label.
I believe this is the same problem that was recently discussed in
relation to
From: Justin Pettit
Thanks to Ben Pfaff for immediately pinpointing the likely location of
the issue.
Signed-off-by: Justin Pettit
Signed-off-by: Simon Horman
---
lib/flow.c|1 +
tests/ofproto-dpif.at | 36 ++--
2 files changed, 19 insertions(
Hi,
This series implements basic MPLS actions and matches based on work by
Ravi K, Leo Alterman and Yamahata-san.
The main limitation of this implementation is that it only
supports manipulating the outer-most MPLS label.
Key difference between the previous post, v2.4:
* Various clean-ups and f
On Fri, Oct 26, 2012 at 05:22:13PM +0900, Isaku Yamahata wrote:
> On Thu, Oct 18, 2012 at 06:02:20PM +0900, Simon Horman wrote:
> > diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
> > index 1fb0304..13eb367 100644
> > --- a/lib/ofp-actions.c
> > +++ b/lib/ofp-actions.c
> > @@ -378,6 +378,26 @@ o
On Fri, Oct 26, 2012 at 05:08:31PM +0900, Isaku Yamahata wrote:
> Some inlined comments in case label == 0. I don't find any dependency on it.
Thanks Yamahata-san,
I agree with both of your comments, I should have fixed these up
when adding tracking of the stack depth (which was also suggested by
On Fri, Oct 26, 2012 at 02:29:30PM -0700, Gurucharan Shetty wrote:
> When physical interfaces are added to a bond through the
> /etc/network/interfaces script, administratively 'up' the
> slave interfaces.
>
> Signed-off-by: Gurucharan Shetty
This seems reasonable.
Thanks,
Ben.
___
On Thu, Oct 25, 2012 at 11:14 AM, Pravin B Shelar wrote:
> Tunnel caching was added to reduce CPU utilization on TX path
> by caching packet header, So performance gain is directly proportional
> to number of skbs transferred. But with help of offloads skb are getting
> larger. So there are less n
On Sat, Oct 27, 2012 at 1:07 PM, Pravin B Shelar wrote:
> diff --git a/datapath/tunnel.c b/datapath/tunnel.c
> index 5b74877..04ff55f 100644
> --- a/datapath/tunnel.c
> +++ b/datapath/tunnel.c
> @@ -1007,10 +1011,9 @@ int ovs_tnl_send(struct vport *vport, struct sk_buff
> *skb)
>
When physical interfaces are added to a bond through the
/etc/network/interfaces script, administratively 'up' the
slave interfaces.
Signed-off-by: Gurucharan Shetty
---
debian/ifupdown.sh |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/debian/ifupdown.sh b/debian/ifu
On Thu, Oct 25, 2012 at 1:34 PM, Ben Pfaff wrote:
> On Thu, Oct 25, 2012 at 01:33:32PM -0700, Pravin Shelar wrote:
>> On Thu, Oct 25, 2012 at 1:22 PM, Ben Pfaff wrote:
>> > On Sat, Oct 27, 2012 at 01:07:35PM -0700, Pravin B Shelar wrote:
>> >> Signed-off-by: Pravin B Shelar
>> >
>> > ...
>> >
>>
On Thu, Oct 25, 2012 at 1:28 PM, Pravin Shelar wrote:
> On Thu, Oct 25, 2012 at 1:19 PM, Ben Pfaff wrote:
>> On Sat, Oct 27, 2012 at 01:07:24PM -0700, Pravin B Shelar wrote:
>>> Signed-off-by: Pravin B Shelar
>>
>> I'm curious, what warning does sparse give? (You could add this to
>> the commit
On Sat, Oct 27, 2012 at 1:07 PM, Pravin B Shelar wrote:
> kernel 3.5 added a switch to turn on UDP encap, capwap needs
> to enable it.
>
> Signed-off-by: Pravin B Shelar
> ---
> datapath/linux/compat/include/linux/udp.h |5 +
> datapath/vport-capwap.c |2 +-
> 2 fil
On Sat, Oct 27, 2012 at 1:07 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
I think we should probably add a little bit of information about the
rationale and timeline to the commit message. I would also mention
that it is deprecated in the schema documentation for CAPWAP.
> v1.8
On Fri, Oct 26, 2012 at 12:24:47PM -0700, Rich Lane wrote:
> Would it be ok if I added dummy.py (as platforms/ovs-dummy.py) to the
> OFTest repository? In the future I want to support maintaining platform
> modules separately from OFTest, but the DataPlanePort interface is going to
> change quite a
On Fri, Oct 26, 2012 at 12:36:41PM -0700, Ethan Jackson wrote:
> Occasionally, backtrace() will deadlock in the signal handler
> because it does some non signal safe initialization. Specifically,
> it opens a shared object. As a work around, this patch forces
> backtrace() to run outside of a sig
Occasionally, backtrace() will deadlock in the signal handler
because it does some non signal safe initialization. Specifically,
it opens a shared object. As a work around, this patch forces
backtrace() to run outside of a signal handler, so that future
calls will perform as expected.
Signed-off
Hi Ben,
Would it be ok if I added dummy.py (as platforms/ovs-dummy.py) to the
OFTest repository? In the future I want to support maintaining platform
modules separately from OFTest, but the DataPlanePort interface is going to
change quite a bit before then. If ovs-dummy.py is versioned with the re
On Fri, Oct 26, 2012 at 01:35:34PM -0500, Adam Heath wrote:
> On 10/26/2012 01:11 PM, Ben Pfaff wrote:
> > On Fri, Oct 26, 2012 at 01:00:32PM -0500, Adam Heath wrote:
> >> On 10/26/2012 11:43 AM, Ben Pfaff wrote:
> >>>
> >>> [snip]
> >>
> >> Right you are, mea-culpa. You're right that there is an
On 10/26/2012 01:11 PM, Ben Pfaff wrote:
> On Fri, Oct 26, 2012 at 01:00:32PM -0500, Adam Heath wrote:
>> On 10/26/2012 11:43 AM, Ben Pfaff wrote:
>>>
>>> [snip]
>>
>> Right you are, mea-culpa. You're right that there is an example in
>> the manpage, showing exactly what I want. Sorry for the noi
On Fri, Oct 26, 2012 at 11:28:42AM -0700, Gurucharan Shetty wrote:
> Running ovs-save directly to save datapath configuration can
> wait forever if ovsdb-server is not running. Use a timeout.
>
> Signed-off-by: Gurucharan Shetty
Looks good, thanks.
___
Running ovs-save directly to save datapath configuration can
wait forever if ovsdb-server is not running. Use a timeout.
Signed-off-by: Gurucharan Shetty
---
utilities/ovs-save | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/utilities/ovs-save b/utilities/ovs-s
On Sat, Oct 27, 2012 at 1:06 PM, Pravin B Shelar wrote:
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index 89feb61..d4a043c 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> @@ -182,6 +182,7 @@ enum ovs_vport_type {
> OVS_VPORT_T
On Fri, Oct 26, 2012 at 09:24:54AM -0700, Dan Talayco wrote:
> I know there are still some rough edges with OFTest, but there are a number
> of changes that have improved things (the control-C issue is a lot better
> than it was, but still present in some situations) and we continue to make
> progr
On Fri, Oct 26, 2012 at 11:21 AM, Ben Pfaff wrote:
> On Fri, Oct 26, 2012 at 11:19:37AM -0700, Ben Pfaff wrote:
>> On Thu, Oct 25, 2012 at 11:14:38AM -0700, Pravin B Shelar wrote:
>> > v1-v2:
>> > - Fixed capwap fragment case.
>> > - simplified tnl_send.
>> > --8<--
On Fri, Oct 26, 2012 at 11:19:37AM -0700, Ben Pfaff wrote:
> On Thu, Oct 25, 2012 at 11:14:38AM -0700, Pravin B Shelar wrote:
> > v1-v2:
> > - Fixed capwap fragment case.
> > - simplified tnl_send.
> > --8<--cut here-->8--
> >
> > Tunnel cach
On Thu, Oct 25, 2012 at 11:14:38AM -0700, Pravin B Shelar wrote:
> v1-v2:
> - Fixed capwap fragment case.
> - simplified tnl_send.
> --8<--cut here-->8--
>
> Tunnel caching was added to reduce CPU utilization on TX path
> by caching packe
On Fri, Oct 26, 2012 at 01:00:32PM -0500, Adam Heath wrote:
> On 10/26/2012 11:43 AM, Ben Pfaff wrote:
> >
> > [snip]
>
> Right you are, mea-culpa. You're right that there is an example in
> the manpage, showing exactly what I want. Sorry for the noise, and
> thanks for the fast response.
It's
v1-v2:
- Fixed capwap fragment case.
- simplified tnl_send.
--8<--cut here-->8--
Tunnel caching was added to reduce CPU utilization on TX path
by caching packet header, So performance gain is directly proportional
to number of skbs tr
On 10/26/2012 11:43 AM, Ben Pfaff wrote:
>
> [snip]
Right you are, mea-culpa. You're right that there is an example in
the manpage, showing exactly what I want. Sorry for the noise, and
thanks for the fast response.
___
dev mailing list
dev@openvswitc
On Fri, Oct 26, 2012 at 01:43:19PM +0900, Isaku Yamahata wrote:
> This implementes push_vlan with 802.1Q.
> NOTE: 802.1AD (QinQ) is not supported. It requires another effort.
>
> Signed-off-by: Isaku Yamahata
Applied to master, thank you!
___
dev maili
Your message dated Fri, 26 Oct 2012 09:43:49 -0700
with message-id <20121026164349.gi22...@nicira.com>
and subject line Re: Bug#691508: ovs-vsctl: --may-exist --if-exists don't work
has caused the Debian Bug report #691508,
regarding ovs-vsctl: --may-exist --if-exists don't work
to be marked as don
On Thu, Oct 25, 2012 at 11:14:34PM -0700, Ben Pfaff wrote:
> On Thu, Oct 25, 2012 at 05:12:21PM -0700, Ben Pfaff wrote:
> > It passes a few tests; I've only tried a few.
> >
> > Now that I look at it, there are some bugs here that will prevent
> > traffic from actually passing through, but they ar
Hi Ben--
Thanks for working on this!
I know there are still some rough edges with OFTest, but there are a number
of changes that have improved things (the control-C issue is a lot better
than it was, but still present in some situations) and we continue to make
progress (especially with contribut
Package: openvswitch-switch
Version: 1.4.2+git20120612-9
>From the man page:
[--may-exist] add-br bridge
[--may-exist] add-br bridge parent vlan
[--may-exist] add-port bridge port [column[:key]=value]...
[--if-exists] del-port [bridge] port
>From my script:
++ ovs-vs
On Fri, Oct 26, 2012 at 03:25:46PM +0800, JieYue Ma wrote:
> During my observation, it seems that the flow expire time has some
> kind of heuristic algo to compute. I add some log for flow miss, and
> start to ping from A to B. At first, the flow from A to B seems to
> miss almost every 5 seconds,
On Fri, Oct 26, 2012 at 09:22:35PM +0800, Cong Wang wrote:
> On 10/25/2012 11:20 PM, Ben Pfaff wrote:
> >Furthermore, ovs-vsctl is meant to be generic in the sense that you can
> >use an ovs-vsctl built in one place (on one OS) to control a switch and
> >database running elsewhere (on another OS).
On 10/25/2012 11:20 PM, Ben Pfaff wrote:
Furthermore, ovs-vsctl is meant to be generic in the sense that you can
use an ovs-vsctl built in one place (on one OS) to control a switch and
database running elsewhere (on another OS). You don't want to apply the
local host's restrictions to changes to
(Letter to the President or Brand Owner, thanks)
Dear President,
We are the department of Asian Domain Registration Service in China. I have
something to confirm with you. We formally received an application on October
25,2012 that a company which self-styled "GOX Investment Ltd" were applying to
On Thu, Oct 18, 2012 at 06:02:20PM +0900, Simon Horman wrote:
> diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
> index 1fb0304..13eb367 100644
> --- a/lib/ofp-actions.c
> +++ b/lib/ofp-actions.c
> @@ -378,6 +378,26 @@ ofpact_from_nxast(const union ofp_action *a, enum
> ofputil_action_code code
On 10/28/2012 04:07 AM, Pravin B Shelar wrote:
--- a/datapath/vport-capwap.c
+++ b/datapath/vport-capwap.c
@@ -473,6 +473,7 @@ static struct vport *capwap_create(const struct vport_parms
*parms)
struct vport *vport;
int err;
+ pr_err("%s: capwap support is deprecated\n", _
Some inlined comments in case label == 0. I don't find any dependency on it.
On Thu, Oct 18, 2012 at 06:02:18PM +0900, Simon Horman wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index a6915fb..e606ae1 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -74,6 +74
Hi,
During my observation, it seems that the flow expire time has some
kind of heuristic algo to compute. I add some log for flow miss, and
start to ping from A to B. At first, the flow from A to B seems to
miss almost every 5 seconds, but as time goes by, the miss interval
enlarges, which means t
48 matches
Mail list logo
