On Sat, Oct 27, 2012 at 1:07 PM, Pravin B Shelar <pshe...@nicira.com> wrote:
> Signed-off-by: Pravin B Shelar <pshe...@nicira.com>

I think we should probably add a little bit of information about the
rationale and timeline to the commit message.  I would also mention
that it is deprecated in the schema documentation for CAPWAP.

>  v1.8.0 - xx xxx xxxx
> diff --git a/datapath/vport-capwap.c b/datapath/vport-capwap.c
> index 39aec42..a113af6 100644
> --- a/datapath/vport-capwap.c
> +++ b/datapath/vport-capwap.c
> @@ -473,6 +473,7 @@ static struct vport *capwap_create(const struct 
> vport_parms *parms)
>         struct vport *vport;
>         int err;
>
> +       pr_err("%s: capwap support is deprecated\n", __func__);

It might be better to warn in userspace since more people will are
likely to look at ovs-vswitchd.log for this type of thing.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to