On Fri, Sep 21, 2012 at 09:26:43AM +0900, Simon Horman wrote:
> On Thu, Sep 20, 2012 at 08:29:19AM -0700, Ben Pfaff wrote:
> > On Thu, Sep 20, 2012 at 04:14:26PM +0900, Simon Horman wrote:
> > > Signed-off-by: Simon Horman
> > >
> > > ---
> > >
> > > I'm unsure of the history of why this is so,
On Thu, Sep 20, 2012 at 08:29:19AM -0700, Ben Pfaff wrote:
> On Thu, Sep 20, 2012 at 04:14:26PM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
> >
> > ---
> >
> > I'm unsure of the history of why this is so,
> > but it seems misleading at best.
>
> This seems reasonable but it shoul
ovs-vswitchd should only write to write-only columns. Furthermore,
writing to a column which is not write-only can cause serious
performance degradations. This patch causes ovs-vswitchd to log
and reject writes to read-write columns.
Signed-off-by: Ethan Jackson
---
Here's an updated version.
> I think that at the least the name here is misleading. The
> OVSDB_IDL_MONITOR flag is set if the IDL will monitor a particular
> column. Thus, it is set for read-only, write-only, and (if we really
> did this) read/write columns.
oops, yes this was just a bug. I meant to use ==. I'll change
On Thu, Sep 20, 2012 at 08:47:31AM -0700, Ben Pfaff wrote:
> On Thu, Sep 20, 2012 at 01:10:40PM +0900, Simon Horman wrote:
> > ...
> > [ho...@verge.net.au: removed trailing whitespace]
>
> Oops, I missed doing that in my version before I pushed it. Sorry ;-)
No problems, the whitespace in questi
On Thu, Sep 20, 2012 at 02:48:54PM -0700, Ethan Jackson wrote:
> ovs-vswitchd should only write to write-only columns. Furthermore,
> writing to a column which is not write-only can cause serious
> performance degradations. This patch causes ovs-vswitchd to log
> and reject writes to read-write c
In ovsdb_jsonrpc_session_got_request() we scope creating of a monitor
to a particular database, but don't scope deletions of monitors in the
same way. Is it possible that two monitors of the same name would be
added to two different databases, and then a cancel could destroy the
wrong one?
Traili
Acked-by: Ethan Jackson
On Fri, Sep 7, 2012 at 10:09 AM, Ben Pfaff wrote:
> This makes the command's behavior more predictable when there is more than
> one database.
>
> Signed-off-by: Ben Pfaff
> ---
> ovsdb/ovsdb-client.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> dif
Acked-by: Ethan Jackson
On Fri, Sep 7, 2012 at 10:09 AM, Ben Pfaff wrote:
> This will make it easier to print a list of databases in sorted order,
> which will happen in a followup commit.
>
> This commit should have no effect on visible OVS behavior.
>
> Signed-off-by: Ben Pfaff
> ---
> ovsd
Acked-by: Ethan Jackson
On Fri, Sep 7, 2012 at 10:09 AM, Ben Pfaff wrote:
> All the other variables are initialized at the top and I don't see a reason
> that this variable is special.
>
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-lib.in |3 ++-
> 1 files changed, 2 insertions(+), 1
Acked-by: Ethan Jackson
On Fri, Sep 7, 2012 at 10:09 AM, Ben Pfaff wrote:
> This paragraph is about show-log so it should be indented the same as the
> other paragraph about show-log.
>
> Signed-off-by: Ben Pfaff
> ---
> ovsdb/ovsdb-tool.1.in |2 +-
> 1 files changed, 1 insertions(+), 1 d
Acked-by: Ethan Jackson
On Fri, Sep 7, 2012 at 10:09 AM, Ben Pfaff wrote:
> The arguments to the callback were changed some time ago but the comment
> still described the older form.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/unixctl.c | 14 +++---
> 1 files changed, 7 insertions(+),
ovs-vswitchd should only write to write-only columns. Furthermore,
writing to a column which is not write-only can cause serious
performance degradations. This patch causes ovs-vswitchd to log
and reject writes to read-write columns.
Signed-off-by: Ethan Jackson
---
lib/ovsdb-idl.c | 23
Looks good.
thanx!
mehak
On Thu, Sep 20, 2012 at 11:13 AM, Ben Pfaff wrote:
> From: Anupam Chanda
>
> Two instances of ofputil_flow_update had the priority field uninitialized.
> This would cause flow updates to contain undefined priority values.
>
> This bug was introduced by commit 81a76618
From: Anupam Chanda
Two instances of ofputil_flow_update had the priority field uninitialized.
This would cause flow updates to contain undefined priority values.
This bug was introduced by commit 81a76618 (classifier: Break cls_rule
'flow' and 'wc' members into new "struct match".)
Signed-off-
This would have saved some time and puzzlement earlier today.
Reported-by: Paul Ingram
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 9f7acd1..dcdd8f2 1006
> I think that ovs-vswitchd only writes to write-only columns. Maybe we
> should have some way to catch that more easily. Compile-time would be
> ideal, but runtime (logging a message? failing an assertion?) would
> be easier.
Agreed, I'll send out a patch.
Ethan
__
On Mon, Aug 27, 2012 at 12:20:45PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> The callback function of call_rcu() just calls a kfree(), so we
> can use kfree_rcu() instead of call_rcu() + callback function.
>
> spatch with a semantic match is used to found this problem.
> (http://coccinel
I have to apologize for my current backlog of unreviewed patches. Not
only am I snowed under by the recent VMware acquisition, but I'm also
moving from one house to another and have no Internet access at the
new house yet (besides having a house full of boxes to unpack).
I hope to make some progr
On Thu, Sep 20, 2012 at 01:10:40PM +0900, Simon Horman wrote:
> ...
> [ho...@verge.net.au: removed trailing whitespace]
Oops, I missed doing that in my version before I pushed it. Sorry ;-)
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org
This is a necessary step toward supporting full 32-bit OF1.1+ port numbers
in a later version of OVS.
Signed-off-by: Ben Pfaff
---
NEWS | 13 +++--
lib/ofp-util.c |6 +++---
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/NEWS b/NEWS
index 38e5129..29fd9f3
On Thu, Sep 20, 2012 at 10:50:23AM +0900, Simon Horman wrote:
> On Wed, Sep 19, 2012 at 10:45:25AM -0700, Ben Pfaff wrote:
> > On Tue, Sep 18, 2012 at 08:58:14AM +0900, Simon Horman wrote:
> > > On Mon, Sep 17, 2012 at 03:53:28PM -0700, Ben Pfaff wrote:
> > > > everywhere that such a port can
On Thu, Sep 20, 2012 at 04:14:26PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
>
> ---
>
> I'm unsure of the history of why this is so,
> but it seems misleading at best.
This seems reasonable but it should handle ARP as well.
Thanks,
Ben.
Hello My Dear,
Compliment of the day, i hope you are doing well and feeling fine
and healthy. My name is Jacinta Victor from Sudan, am a single girl
searching
for friend, I am tall and fair in complexion,
I know you will be surprise when you will receive this
letter on how do I got you
On Wed, Sep 19, 2012 at 07:27:10PM -0700, Ethan Jackson wrote:
> This column should be write only, otherwise every call to update it
> has to make a trip to the database. Since this column is updated
> every time through the run loop as part of refresh_instant_stats(),
> this patch fixes a signifi
On 09/19/2012 07:27 PM, Ben Pfaff wrote:
On Wed, Sep 19, 2012 at 07:22:59PM +0200, Andi wrote:
We have installed openvswitch in netkit(a user-mode linux front-end
let's say) after cross-compiling it for UML. During the startup of
the virtual machines we use a script to install openvswitch using
Signed-off-by: Simon Horman
---
I'm unsure of the history of why this is so,
but it seems misleading at best.
---
lib/flow.c |2 +-
tests/ofp-print.at |2 +-
tests/ofproto.at | 10 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/flow.c b/lib/flo
27 matches
Mail list logo
