On Wed, Sep 19, 2012 at 07:27:10PM -0700, Ethan Jackson wrote:
> This column should be write only, otherwise every call to update it
> has to make a trip to the database.  Since this column is updated
> every time through the run loop as part of refresh_instant_stats(),
> this patch fixes a significant performance degradation.
> 
> Signed-off-by: Ethan Jackson <et...@nicira.com>

Looks good, thanks.

I think that ovs-vswitchd only writes to write-only columns.  Maybe we
should have some way to catch that more easily.  Compile-time would be
ideal, but runtime (logging a message?  failing an assertion?) would
be easier.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to