commit 6a0a5bbbc (ofproto-dpif: Make sure one-packet flows have zero
duration.) was supposed to fix failures in the "ofproto-dpif - NetFlow
flow expiration" test, but it didn't fix the whole problem. That commit
eliminated one reason why a one-packet flow might be shown as having an
nonzero durati
The following commit will need to use a value other than a literal
time_msec() in one case. This commit is just preparation.
Factoring the time_msec() call out of the loop in
handle_flow_miss_without_facet() is a really minor optimization. It isn't
the main point here.
Signed-off-by: Ben Pfaff
On Sat, Aug 18, 2012 at 11:10:50AM +0800, Baohua Yang wrote:
> <1> All incoming network packet will be handler
> by ovs_dp_process_received_packet(), right?
> In ovs_dp_process_received_packet(), for the missing
> packets, ovs_dp_upcall() will be called to send the OVS_PACKET_CMD_MISS
> cmd, and f
Thanks Ben!
I still have several question. Could you give further suggestion?
<1> All incoming network packet will be handler
by ovs_dp_process_received_packet(), right?
In ovs_dp_process_received_packet(), for the missing
packets, ovs_dp_upcall() will be called to send the OVS_PACKET_CMD_MISS
cmd
On Fri, Aug 17, 2012 at 07:18:41PM -0700, Ethan Jackson wrote:
> diff --git a/lib/autopath.c b/lib/autopath.c
> index 93fedd1..61c5026 100644
> --- a/lib/autopath.c
> +++ b/lib/autopath.c
> @@ -32,6 +32,8 @@
>
> VLOG_DEFINE_THIS_MODULE(autopath);
>
> +static bool warned = false;
> +
> void
>
On Fri, Aug 17, 2012 at 07:18:40PM -0700, Ethan Jackson wrote:
> diff --git a/lib/bond.c b/lib/bond.c
> index 7178416..5e097b0 100644
> --- a/lib/bond.c
> +++ b/lib/bond.c
> @@ -255,6 +255,12 @@ bond_reconfigure(struct bond *bond, const struct
> bond_settings *s)
> if (bond->balance != s->bal
We are planning to deprecate and eventually remove the autopath action
and stable bond mdoe. They will be officially deprecated at the end
of next week (Friday the 24th) and removed in February 2013. If for
some reason you think deprecating and removing these features is
inappropriate, respond to
The autopath action is an obsolete attempt to replicate
functionality contained in the bundle action. It is ugly and of
questionable usefulness. This patch deprecates it and schedules
its removal for February 2013. If there are concerns, please email
dev@openvswitch.org.
Signed-off-by: Ethan Ja
The stable bond mode is an obsolete attempt to replicate the
functionality contained in the bundle action. They are ugly and of
questionable usefulness. This patch deprecates them and schedules
their removal for February 2013. If there are concerns, please
email dev@openvswitch.org.
Signed-off-
I'm going to hold of merging these patches for a week to give
people a chance to express concerns.
Ethan Jackson (2):
bond: Deprecate stable bonds.
nicira-ext: Deprecate the autopath action.
NEWS | 4
include/openflow/nicira-ext.h | 2 +-
lib/autopath.c
I've decided to drop this in favor of the strategy mentioned below.
On Thu, Aug 16, 2012 at 5:06 PM, Ben Pfaff wrote:
> I proposed to Ethan via IM that we should do this kind of non-urgent
> feature removal in a couple of steps:
>
> - Mention on ovs-dev that we're deprecating it.
>
>
In the tests, I think it's a good idea to manually set the
lacp-port-id and the lacp-aggregation-key in the database, because
those are arbitrarily generated by the switch.
Otherwise looks good, This is a huge win. Thanks for doing this.
Ethan
On Fri, Aug 10, 2012 at 3:25 PM, Ben Pfaff wrote:
Looks good, thanks.
Ethan
On Fri, Aug 17, 2012 at 4:34 PM, Ben Pfaff wrote:
> Some Open vSwitch utilities can do useful work when they are not run as
> root. Without this commit, these utilities will log a warning on failure
> to use the SO_RCVBUFFORCE socket option if they open any Netlink soc
Signed-off-by: Ben Pfaff
---
tests/ofproto-macros.at |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at
index 944fbac..b10ff50 100644
--- a/tests/ofproto-macros.at
+++ b/tests/ofproto-macros.at
@@ -64,6 +64,11 @@ m4_def
These messages rarely report bugs any longer, but they are still useful
occasionally for debugging, so this commit reduces their severity without
deleting them.
It might make sense to increase the threshold for printing these.
Signed-off-by: Ben Pfaff
---
lib/timeval.c | 10 +-
1 file
This information is also available via ovs-ofctl and through other means,
and it's not really anything we need to warn about anyhow.
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/brid
This avoids a log warning:
bridge|WARN|port bond: Using the default bond_mode active-backup.
Note that in previous versions, the default bond_mode was balance-slb
This warning is harmless, but I'm trying to add checks for "warn" and
higher severity log messages to the tests, so it makes s
Some Open vSwitch utilities can do useful work when they are not run as
root. Without this commit, these utilities will log a warning on failure
to use the SO_RCVBUFFORCE socket option if they open any Netlink sockets.
This will always happen, it does not report anything unexpected or
fixable as n
On Fri, Aug 17, 2012 at 03:55:27PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Ethan Jackson
---
vswitchd/INTERNALS | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/vswitchd/INTERNALS b/vswitchd/INTERNALS
index 7aa3c29..2b48c9b 100644
--- a/vswitchd/INTERNALS
+++ b/vswitchd/INTERNALS
@@ -27,12 +27,13 @@ one slave, th
Some Open vSwitch utilities can do useful work when they are not run as
root. Without this commit, these utilities will log a warning on failure
to use the SO_RCVBUFFORCE socket option if they open any Netlink sockets.
This will always happen, it does not report anything unexpected or
fixable as n
Thanks, applied to master.
On Fri, Aug 17, 2012 at 02:46:33PM -0700, Mehak Mahajan wrote:
> Looks good.
>
> thanx!
> mehak
>
> On Fri, Aug 17, 2012 at 2:00 PM, Ben Pfaff wrote:
>
> > Found by valgrind.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > utilities/ovs-ofctl.c |1 +
> > 1 files c
Thanks for the review. I pushed this to master and soon to branch-1.8.
On Fri, Aug 17, 2012 at 02:48:19PM -0700, Mehak Mahajan wrote:
> Looks good.
>
> thanx!
> mehak
>
> On Fri, Aug 17, 2012 at 1:59 PM, Ben Pfaff wrote:
>
> > Found by valgrind.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> >
Looks good.
thanx!
mehak
On Fri, Aug 17, 2012 at 1:59 PM, Ben Pfaff wrote:
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-print.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/ofp-print.c b/lib/ofp-print.c
> index 3f5b6be..99e6456 100644
Looks good.
thanx!
mehak
On Fri, Aug 17, 2012 at 2:00 PM, Ben Pfaff wrote:
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-ofctl.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> index dd5f4b
Found by valgrind.
Signed-off-by: Ben Pfaff
---
lib/ofp-print.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 3f5b6be..99e6456 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -1044,6 +1044,7 @@ ofp_print_flow_stats_reply(st
Found by valgrind.
Signed-off-by: Ben Pfaff
---
utilities/ovs-ofctl.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index dd5f4ba..622e32f 100644
--- a/utilities/ovs-ofctl.c
+++ b/utilities/ovs-ofctl.c
@@ -2615,6 +2615,7 @@
Thanks guys! Waiting for the build.
On Fri, Aug 17, 2012 at 1:24 PM, Ben Pfaff wrote:
> Thanks for the reviews. I applied this to master.
>
> On Fri, Aug 17, 2012 at 01:19:04PM -0700, Ethan Jackson wrote:
> > Looks good to me. I was never particularly comfortable with the masks
> > in flow_met
Thank you for the review. I applied this to master.
On Fri, Aug 17, 2012 at 01:25:20PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
>
> Ethan
>
> On Fri, Aug 17, 2012 at 1:19 PM, Ben Pfaff wrote:
> > The functions being called already do nothing if passed a null pointer.
> >
> > Signed-of
Looks good, thanks.
Ethan
On Fri, Aug 17, 2012 at 1:19 PM, Ben Pfaff wrote:
> The functions being called already do nothing if passed a null pointer.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-util.c | 13 +++--
> 1 files changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/l
Thanks for the reviews. I applied this to master.
On Fri, Aug 17, 2012 at 01:19:04PM -0700, Ethan Jackson wrote:
> Looks good to me. I was never particularly comfortable with the masks
> in flow_metadata, this is much cleaner. Thanks.
>
> Ethan
>
> On Fri, Aug 17, 2012 at 1:55 AM, Joe Stringe
The bonding code is supposed to tag flows two ways:
- According to the chosen bond slave, to make it easy to invalidate all
of the flows assigned to a given slave.
- According to the hash value for a flow, to make it easy to invalidate
all of the flows that hash into the same
The functions being called already do nothing if passed a null pointer.
Signed-off-by: Ben Pfaff
---
lib/ofp-util.c | 13 +++--
1 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index ad29174..210db3b 100644
--- a/lib/ofp-util.c
+++ b/lib/o
Looks good to me. I was never particularly comfortable with the masks
in flow_metadata, this is much cleaner. Thanks.
Ethan
On Fri, Aug 17, 2012 at 1:55 AM, Joe Stringer wrote:
> Looks good to me.
> ___
> dev mailing list
> dev@openvswitch.org
> http
On Fri, Aug 17, 2012 at 08:42:53PM +1200, Joe Stringer wrote:
> On 16 August 2012 06:43, Ben Pfaff wrote:
> > On Wed, Aug 15, 2012 at 12:28:47AM +1200, Joe Stringer wrote:
> >> In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to
> >> write to the metadata field. Internally
On Fri, Aug 17, 2012 at 08:06:29PM +1200, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
Applied to master, thanks a lot!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Aug 17, 2012 at 04:50:57PM +0800, Baohua Yang wrote:
> In the openvswitch code file include\linux\openvswitch.h, there's 4
> defined cmds, as
> enum ovs_packet_cmd{
> OVS_PACKET_CMD_UNSPEC,
> OVS_PACKET_CMD_MISS,
> OVS_PACKET_CMD_ACTION,
> OVS_PACKET_CMD_EXECUTE
> }
>
>
Looks good to me.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi,all
In the openvswitch code file include\linux\openvswitch.h, there's 4
defined cmds, as
enum ovs_packet_cmd{
OVS_PACKET_CMD_UNSPEC,
OVS_PACKET_CMD_MISS,
OVS_PACKET_CMD_ACTION,
OVS_PACKET_CMD_EXECUTE
}
However, in datapath\datapath.c, there is only the handler for
the OVS_PA
On 16 August 2012 06:43, Ben Pfaff wrote:
> On Wed, Aug 15, 2012 at 12:28:47AM +1200, Joe Stringer wrote:
>> In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to
>> write to the metadata field. Internally it is represented using
>> ofpact_metadata.
>>
>> We introduce NXAST_
Signed-off-by: Joe Stringer
---
utilities/ovs-ofctl.8.in |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 705036f..386f7c8 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/utilities/ovs-ofctl.8.in
@@ -614,6 +614,1
41 matches
Mail list logo
