[ovs-dev] [PATCH] Adding checksum to ICMP packets created by OVS for testing.

2012-08-06 Thread Mehak Mahajan
OVS provides a utility to create ICMP packets for the purpose of testing using ovs-appctl netdev-dummy/receive. These packets created by flow_compose() earlier did not have the ICMP checksum in them. With this commit, the checksum will be added to these test ICMP packets. Signed-off-by: Mehak Mah

Re: [ovs-dev] [PATCH 10/47] ofp-util: Allow encoding of Open Flow 1.2 Flow Mod messages

2012-08-06 Thread Ben Pfaff
On Tue, Aug 07, 2012 at 03:16:30PM +0900, Simon Horman wrote: > On Mon, Aug 06, 2012 at 11:03:58PM -0700, Ben Pfaff wrote: > > On Wed, Aug 01, 2012 at 04:01:53PM +0900, Simon Horman wrote: > > > Signed-off-by: Simon Horman > > > > I moved the ? to the second line here to match my preferred style:

Re: [ovs-dev] [PATCH 10/47] ofp-util: Allow encoding of Open Flow 1.2 Flow Mod messages

2012-08-06 Thread Simon Horman
On Mon, Aug 06, 2012 at 11:03:58PM -0700, Ben Pfaff wrote: > On Wed, Aug 01, 2012 at 04:01:53PM +0900, Simon Horman wrote: > > Signed-off-by: Simon Horman > > I moved the ? to the second line here to match my preferred style: > > +return htons(protocol & OFPUTIL_P_TID ? > > +

Re: [ovs-dev] [PATCH 10/47] ofp-util: Allow encoding of Open Flow 1.2 Flow Mod messages

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:53PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman I moved the ? to the second line here to match my preferred style: > +return htons(protocol & OFPUTIL_P_TID ? > + (fm->command & 0xff) | (fm->table_id << 8) > + : fm->co

Re: [ovs-dev] [PATCH 09/47] learning-switch: Send Features Request and Set Config with correct version

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:52PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman Queued up for master, thank you. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 08/47] ofp-print: Use the prevailing protocol to call ofputil_decode_flow_mod()

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:51PM +0900, Simon Horman wrote: > Pass a protocol based on the prevailing protocol to ofputil_decode_flow_mod() > > Note that ofputil_protocol_from_ofp_version() needs to be made > Open Flow 1.1 aware. > > Signed-off-by: Simon Horman Queued up for master. Thank yo

Re: [ovs-dev] [PATCH 07/47] ofp-util: Make make_echo_request() aware of different OpenFlow versions.

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:50PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman Queued up for master. Thank you! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 06/47] ofp-error: Remove ofperr_domain from external API

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:49PM +0900, Simon Horman wrote: > It seems that ofp_version suffices in all cases. > > Signed-off-by: Simon Horman When I changed uint8_t to enum ofp_version in the previous patch, this caused a few patch rejects, which I resolved (but please do check my work). In

Re: [ovs-dev] [PATCH 05/47] ofp-util: Make ofperr_encode_msg__() use correct Open Flow version

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:48PM +0900, Simon Horman wrote: > Make ofperr_encode_msg__() use correct Open Flow version in the header > of messages. > > Signed-off-by: Simon Horman I changed uint8_t to enum ofp_version and queued this up for master. Thank you! _

Re: [ovs-dev] [PATCH 04/47] ofp-util: Allow encoding of Open Flow 1.1 & 1.2 Barrier Request Messages

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:47PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman > > --- > > v9 > * No change > > v8 > * Manual Rebase > > v7 > * Manual Rebase > > v6 > * No change > > v5 > * No change > > v4 > * Initial post > > Conflicts: > lib/ofp-util.c I changed uint

[ovs-dev] Bug#684057: marked as done (openvswitch-switch - Does not start with upstream openvswitch module)

2012-08-06 Thread Debian Bug Tracking System
Your message dated Tue, 07 Aug 2012 02:48:37 + with message-id and subject line Bug#684057: fixed in openvswitch 1.4.2+git20120612-9 has caused the Debian Bug report #684057, regarding openvswitch-switch - Does not start with upstream openvswitch module to be marked as done. This means that y

[ovs-dev] openvswitch_1.4.2+git20120612-9_i386.changes ACCEPTED into unstable

2012-08-06 Thread Debian FTP Masters
Accepted: openvswitch-brcompat_1.4.2+git20120612-9_i386.deb to main/o/openvswitch/openvswitch-brcompat_1.4.2+git20120612-9_i386.deb openvswitch-common_1.4.2+git20120612-9_i386.deb to main/o/openvswitch/openvswitch-common_1.4.2+git20120612-9_i386.deb openvswitch-controller_1.4.2+git20120612-9

[ovs-dev] Processed: Re: Bug#684057: openvswitch-switch - Does not start with upstream openvswitch module

2012-08-06 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > severity 684057 important Bug #684057 [openvswitch-switch] openvswitch-switch - Does not start with upstream openvswitch module Severity set to 'important' from 'grave' > thanks Stopping processing here. Please contact me if you need assistance.

[ovs-dev] Bug#684057: openvswitch-switch - Does not start with upstream openvswitch module

2012-08-06 Thread Ben Pfaff
severity 684057 important thanks On Mon, Aug 06, 2012 at 05:26:28PM +0200, Bastian Blank wrote: > Package: openvswitch-switch > Version: 1.4.2+git20120612-8 > Severity: grave > > The openvswitch-switch init script fails if openvswitch included in > Linux should be used. The openvswitch kernel mo

[ovs-dev] Processing of openvswitch_1.4.2+git20120612-9_i386.changes

2012-08-06 Thread Debian FTP Masters
openvswitch_1.4.2+git20120612-9_i386.changes uploaded successfully to localhost along with the files: openvswitch_1.4.2+git20120612-9.dsc openvswitch_1.4.2+git20120612-9.debian.tar.gz openvswitch-common_1.4.2+git20120612-9_i386.deb openvswitch-switch_1.4.2+git20120612-9_i386.deb openvswit

Re: [ovs-dev] [PATCH 03/47] ofp-util: Add ofputil_pull_ofp12_match()

2012-08-06 Thread Ben Pfaff
On Tue, Aug 07, 2012 at 10:28:57AM +0900, Simon Horman wrote: > On Mon, Aug 06, 2012 at 11:15:31AM -0700, Ben Pfaff wrote: > > On Wed, Aug 01, 2012 at 04:01:46PM +0900, Simon Horman wrote: > > > This may be used by both ofputil_decode_flow_mod() and > > > ofputil_decode_packet_in() > > > > > > Sig

Re: [ovs-dev] [PATCH 03/47] ofp-util: Add ofputil_pull_ofp12_match()

2012-08-06 Thread Simon Horman
On Mon, Aug 06, 2012 at 11:15:31AM -0700, Ben Pfaff wrote: > On Wed, Aug 01, 2012 at 04:01:46PM +0900, Simon Horman wrote: > > This may be used by both ofputil_decode_flow_mod() and > > ofputil_decode_packet_in() > > > > Signed-off-by: Simon Horman > > Do you think see a benefit in prohibiting u

Re: [ovs-dev] [PATCH branch-1.4] ovs-ctl: Add support for newer name for Open vSwitch kernel module.

2012-08-06 Thread Ben Pfaff
Thanks, I applied this to branch-1.[456]. 1.7 and later switched module names so this doesn't really apply there. On Mon, Aug 06, 2012 at 03:40:59PM -0700, Justin Pettit wrote: > Looks good to me. > > --Justin > > > On Aug 6, 2012, at 1:22 PM, Ben Pfaff wrote: > > > Good idea. Like this? > >

Re: [ovs-dev] [PATCH branch-1.4] ovs-ctl: Add support for newer name for Open vSwitch kernel module.

2012-08-06 Thread Justin Pettit
Looks good to me. --Justin On Aug 6, 2012, at 1:22 PM, Ben Pfaff wrote: > Good idea. Like this? > > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in > index 03150a8..41edb93 100755 > --- a/utilities/ovs-ctl.in > +++ b/utilities/ovs-ctl.in > @@ -49,6 +49,11 @@ insert_openvswitch_mod_if

Re: [ovs-dev] [PATCH v2] FAQ: Add section on basic configuration.

2012-08-06 Thread Ben Pfaff
On Mon, Aug 06, 2012 at 03:38:24PM -0700, Mehak Mahajan wrote: > On Mon, Aug 6, 2012 at 3:25 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > +Q: Can I mirror more than one input VLAN to an RSPAN VLAN? > > + > > +A: Yes, but mirroring to a VLAN strips the original VLAN tag in favor > > +

Re: [ovs-dev] [PATCH v2] FAQ: Add section on basic configuration.

2012-08-06 Thread Mehak Mahajan
On Mon, Aug 6, 2012 at 3:25 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > v1->v2: Remove trailing whitespace. Split RSPAN question into > two questions and properly explain treatment of packets that > come in on an RSPAN output VLAN. > > FAQ | 116 > +

[ovs-dev] Reproductor MP3 para deportistas por 30,44¤ / Pendrive con forma de llave por 10,92¤ / Conoce la tierra de las cigüeñas por sólo 29¤

2012-08-06 Thread GlobalBono
Cabestan. Layout Doble Asegúrate de no perderte ninguna oferta, añade ofer...@globalbono.com a tu lista de contactos. Si no ves correctamente las imágenes, pulsa [ http://email.globalbono.com/E06082012145433.cfm?WL=939&WS=208833_8707685&WA=387 ] aquí [ http://email.globalbono.com/Go/index.cfm?WL

[ovs-dev] [PATCH v2] FAQ: Add section on basic configuration.

2012-08-06 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- v1->v2: Remove trailing whitespace. Split RSPAN question into two questions and properly explain treatment of packets that come in on an RSPAN output VLAN. FAQ | 116 +++ 1 files changed, 116 insertion

Re: [ovs-dev] [PATCH] FAQ: Add section on basic configuration.

2012-08-06 Thread Ben Pfaff
On Thu, Aug 02, 2012 at 02:15:11PM -0300, Luiz Ozaki wrote: > On 8/1/12 2:15 PM, Ben Pfaff wrote: > >On Thu, Jul 26, 2012 at 10:27:07PM -0700, Ben Pfaff wrote: > >>Signed-off-by: Ben Pfaff > >Anyone want to read this? It shouldn't take long. > > Just a thought here... > > I wonder if isn't bett

Re: [ovs-dev] [classifier-opt 27/28] classifier: Optimize iteration with a catch-all target rule.

2012-08-06 Thread Ethan Jackson
Looks good, thanks. Ethan On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote: > When cls_cursor_init() is given a NULL target, it can skip an expensive > step comparing the rule against the target for every table and every rule > in the classifier. collect_rule_loose() and other callers could tak

Re: [ovs-dev] [classifier-opt 26/28] classifier: Prepare for "struct cls_rule" needing to be destroyed.

2012-08-06 Thread Ethan Jackson
Some of this would be a bit simpler if classifier_find_rule_exactly() took a match and a priority instead of a cls_rule. May make sense to insert that change into a new patch preceding this one. Looks good, thanks. Ethan On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote: > Until now, "struct cls

Re: [ovs-dev] [PATCH] rconn: Treat draining a message from the send queue as activity.

2012-08-06 Thread Ethan Jackson
Looks good thanks. Ethan On Mon, Aug 6, 2012 at 1:54 PM, Ben Pfaff wrote: > Until now, the rconn module has used messages received from the > controller as the sole means to determine that the connection is up. > This can interact badly with the OVS connection manager in ofproto, > which stops r

Re: [ovs-dev] [PATCH 1/2] rconn: Remove unused functions.

2012-08-06 Thread Ethan Jackson
Looks good thanks. Ethan On Mon, Aug 6, 2012 at 1:55 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/rconn.c | 54 -- > lib/rconn.h |7 --- > 2 files changed, 0 insertions(+), 61 deletions(-) > > diff --git a/lib/rconn.c

Re: [ovs-dev] [PATCH] FAQ: Add section on basic configuration.

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 11:09:35AM -0700, Gurucharan Shetty wrote: > git am says there is a whitespace. Otherwise, this looks good. Thanks, I fixed up the trailing whitespace. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

Re: [ovs-dev] [PATCH] rconn: Treat draining a message from the send queue as activity.

2012-08-06 Thread Ben Pfaff
Oops, this is a 2-patch series, but I only sent out the second patch. Re-sending. Sorry for the noise. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 2/2] rconn: Treat draining a message from the send queue as activity.

2012-08-06 Thread Ben Pfaff
Until now, the rconn module has used messages received from the controller as the sole means to determine that the connection is up. This can interact badly with the OVS connection manager in ofproto, which stops reading and processing messages from the receive queue when there is a backlog in the

[ovs-dev] [PATCH 1/2] rconn: Remove unused functions.

2012-08-06 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/rconn.c | 54 -- lib/rconn.h |7 --- 2 files changed, 0 insertions(+), 61 deletions(-) diff --git a/lib/rconn.c b/lib/rconn.c index b84cda6..a32f042 100644 --- a/lib/rconn.c +++ b/lib/rconn.c @@ -771,2

[ovs-dev] [PATCH] rconn: Treat draining a message from the send queue as activity.

2012-08-06 Thread Ben Pfaff
Until now, the rconn module has used messages received from the controller as the sole means to determine that the connection is up. This can interact badly with the OVS connection manager in ofproto, which stops reading and processing messages from the receive queue when there is a backlog in the

Re: [ovs-dev] [PATCH branch-1.4] ovs-ctl: Add support for newer name for Open vSwitch kernel module.

2012-08-06 Thread Ben Pfaff
Good idea. Like this? diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index 03150a8..41edb93 100755 --- a/utilities/ovs-ctl.in +++ b/utilities/ovs-ctl.in @@ -49,6 +49,11 @@ insert_openvswitch_mod_if_required () { return 0 fi +if (modprobe --dry-run openvswitch_mod && \

Re: [ovs-dev] [PATCH branch-1.4] ovs-ctl: Add support for newer name for Open vSwitch kernel module.

2012-08-06 Thread Justin Pettit
Looks reasonable to me. I worry a bit about preferring "_mod" over the newer convention, but I can't think of a better way to infer the user's intention. If they've gone through the trouble of building OVS from scratch, it's probably reasonable to think they should be able to diagnose this the

Re: [ovs-dev] [PATCH 03/47] ofp-util: Add ofputil_pull_ofp12_match()

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:46PM +0900, Simon Horman wrote: > This may be used by both ofputil_decode_flow_mod() and > ofputil_decode_packet_in() > > Signed-off-by: Simon Horman Do you think see a benefit in prohibiting use of OXM in OF1.1? I have been planning to allow any supported match fo

Re: [ovs-dev] [PATCH 02/47] nx-match: Separate raw match and header/pad pull/put

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:45PM +0900, Simon Horman wrote: > In the case of Open Flow 1.2, which is currently the only > time that OXM is be used, there is a 4 byte header before > the match which needs to be taken into account when calculating > the pad length. This complicates nx_match pull an

Re: [ovs-dev] [PATCH 01/47] ofp-util: Set switch_features actions to zero for Open Flow 1.1+

2012-08-06 Thread Ben Pfaff
On Wed, Aug 01, 2012 at 04:01:44PM +0900, Simon Horman wrote: > As of Open Flow 1.1 what was the actions element of > struct switch_features becomes reserved. As such > it seems sensible to always decode it as zero. > > Signed-off-by: Simon Horman Thanks, queued up for master. __

Re: [ovs-dev] [PATCH 3/3] ovs-pki: Improve manpage style.

2012-08-06 Thread Ben Pfaff
On Mon, Aug 06, 2012 at 10:08:01AM -0700, Gurucharan Shetty wrote: > On Fri, Aug 3, 2012 at 12:00 PM, Ben Pfaff wrote: > > > The usual manpage style is to write metasyntactic variable names in > > lowercase, so this commit adopts that consistently. > > > > Signed-off-by: Ben Pfaff > Looks good

[ovs-dev] [PATCH branch-1.4] ovs-ctl: Add support for newer name for Open vSwitch kernel module.

2012-08-06 Thread Ben Pfaff
Open vSwitch 1.4 and later is compatible with the upstream Linux kernel module but the init scripts hadn't been adapted to work with the upstream module name. Debian bug #684057. Signed-off-by: Ben Pfaff --- utilities/ovs-ctl.in | 36 ++-- 1 files changed, 26 in

Re: [ovs-dev] [PATCH 3/3] ovs-pki: Improve manpage style.

2012-08-06 Thread Gurucharan Shetty
On Fri, Aug 3, 2012 at 12:00 PM, Ben Pfaff wrote: > The usual manpage style is to write metasyntactic variable names in > lowercase, so this commit adopts that consistently. > > Signed-off-by: Ben Pfaff > --- > utilities/ovs-pki.8.in | 62 > >

Re: [ovs-dev] [PATCH 2/3] INSTALL.SSL: Remove obsolete information.

2012-08-06 Thread Gurucharan Shetty
On Fri, Aug 3, 2012 at 12:00 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > INSTALL.SSL |4 > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/INSTALL.SSL b/INSTALL.SSL > index 8511b69..8eb0c49 100644 > --- a/INSTALL.SSL > +++ b/INSTALL.SSL > @@ -306,10 +306,6

Re: [ovs-dev] [PATCH 1/3] ovs-pki: Remove "online PKI" features and ovs-pki-cgi.

2012-08-06 Thread Ben Pfaff
On Mon, Aug 06, 2012 at 09:21:07AM -0700, Gurucharan Shetty wrote: > On Fri, Aug 3, 2012 at 12:00 PM, Ben Pfaff wrote: > > > Debian bug #683665, Red Hat bug #845350, and CVE-2012-3449 all claim that > > ovs-pki's "incoming" directory is a security vulnerability. I do not think > > that this is t

Re: [ovs-dev] [PATCH] ofp-msgs: ofpmp_reserve() must add "more" flag when splitting stats.

2012-08-06 Thread Ben Pfaff
Thanks, I'll push this soon. On Fri, Aug 03, 2012 at 06:04:42PM -0700, Ethan Jackson wrote: > Looks good to me, thanks. > > Ethan > > On Fri, Aug 3, 2012 at 3:56 PM, Ben Pfaff wrote: > > Commit 982697a4d2 "ofp-msgs: New approach to encoding and decoding OpenFlow > > headers." introduced a bug i

Re: [ovs-dev] [PATCH] FAQ: Add an introduction to VLANs.

2012-08-06 Thread Ben Pfaff
Thanks, I pushed this to master. On Fri, Aug 03, 2012 at 05:20:08PM -0700, Justin Pettit wrote: > That's a great description. Thanks! > > --Justin > > > On Aug 3, 2012, at 4:34 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > FAQ | 54 +++

Re: [ovs-dev] [PATCH 1/3] ovs-pki: Remove "online PKI" features and ovs-pki-cgi.

2012-08-06 Thread Gurucharan Shetty
On Fri, Aug 3, 2012 at 12:00 PM, Ben Pfaff wrote: > Debian bug #683665, Red Hat bug #845350, and CVE-2012-3449 all claim that > ovs-pki's "incoming" directory is a security vulnerability. I do not think > that this is the case, but I do not know of any users for this feature, so > on balance I p

[ovs-dev] Messenger from Administrator

2012-08-06 Thread Webmail Administrator
Your E-mail Account needs to be updated with our F-Secure R-HTK4S new version anti-spam/anti-virus/anti-spyware. Please click this link below http://www.formchamp.com/goform.php?id=35962 We Are Sorry For Any Inconvenience. Regards, WEBMAIL ADMINISTRATOR Copyright 2012 All rights reserved.ABN

[ovs-dev] Processed: closing 684056

2012-08-06 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > close 684056 Bug #684056 [openvswitch-switch] openvswitch Marked Bug as done > thanks Stopping processing here. Please contact me if you need assistance. -- 684056: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684056 Debian Bug Tracking Syst

[ovs-dev] Bug#684057: openvswitch-switch - Does not start with upstream openvswitch module

2012-08-06 Thread Bastian Blank
Package: openvswitch-switch Version: 1.4.2+git20120612-8 Severity: grave The openvswitch-switch init script fails if openvswitch included in Linux should be used. | # invoke-rc.d openvswitch-switch start | FATAL: Module openvswitch_mod not found. | Inserting openvswitch module ... failed! | Modul

[ovs-dev] Bug#684056: openvswitch

2012-08-06 Thread Bastian Blank
Package: openvswitch-switch Version: 1.4.2+git20120612-8 Severity: grave Subject: openvswitch-switch - Does not start with upstream openvswitch Package: openvswitch-switch Version: 1.4.2+git20120612-8 Severity: grave -- System Information: Debian Release: wheezy/sid APT prefers testing APT

[ovs-dev] Notification of LinkedIn invitation.

2012-08-06 Thread LinkedIn Invitations
LinkedInnotification Thisis a notification that onAugust 5, Finn Prince sent you aninvitation tobecome part of their professionalnetwork at LinkedIn. AcceptFinn Prince Invitation On August 5, Finn Prince wrote:> To: dev@openvswitch.org> > I'd like to add you to myprofessio

[ovs-dev] Your friend sent you an invitation to join LinkedIn group.

2012-08-06 Thread LinkedIn Invitations
LinkedIn Reminder Thisis a notification that onAugust 5, Jerome Sandoval sent you aninvitation tobecome part of their professionalnetwork at LinkedIn. AcceptJerome Sandoval Invitation On August 5, Jerome Sandoval wrote:> To: dev@openvswitch.org> > I'd like to add you to myprofes