Option --ovs is added for ovs-bugtool command to collect
only OpenvSwitch relevant information. To perform
filtering in plugins, a new xml attribute filters="ovs" (optional)
would be required in element 'command','files','directory' in
openvswitch.xml. Value of 'filters' attribute will be compared
Thanks Ben. I will send v5 patch.
On 7/19/12 12:00 AM, "Ben Pfaff" wrote:
>On Wed, Jul 18, 2012 at 11:59:27PM +0530, Arun Sharma wrote:
>> Please let me know your comments.
>
>See inline.
>
>> On 7/14/12 9:20 AM, "Arun Sharma" wrote:
>>
>> >Please see comments inline.
>> >
>> >On 7/13/12 10:08
On Thu, Jul 19, 2012 at 10:08:50AM +0900, Simon Horman wrote:
> On Wed, Jul 18, 2012 at 10:21:50AM -0700, Ben Pfaff wrote:
> > On Wed, Jul 18, 2012 at 12:02:19PM +0900, Simon Horman wrote:
> > > Signed-off-by: Simon Horman
> >
> > When I apply this to master (currently 333be161abe78), I get the
>
On Wed, Jul 18, 2012 at 09:47:01AM -0700, Ben Pfaff wrote:
> On Wed, Jul 18, 2012 at 08:41:28PM +0900, Isaku Yamahata wrote:
> > output OFPP_TABLE should send the packet to the first table whose
> > table id is 0.
> > Nicira extension case, output-reg and bundle action, the behavior
> > is kept.
>
On Wed, Jul 18, 2012 at 09:29:31AM -0700, Ben Pfaff wrote:
> On Wed, Jul 18, 2012 at 08:41:17PM +0900, Isaku Yamahata wrote:
> > Signed-off-by: Isaku Yamahata
>
> It looks like your intended strategy for handling Apply-Actions is to
> put those actions into a nested set of ofpacts. I see how thi
I may be able to help you find the targeted list you are looking for, just
complete the form below and send it to me. If I have your list then I will send
you samples, counts and pricing.
1. Business or Consumer?
2. Emails only or full Contact Data?
3. Business Categories required (please list
On Wed, Jul 18, 2012 at 11:18:29AM -0700, Ethan Jackson wrote:
> The enable_system_stats() function calls smap_get_bool() on the
> ovsrec_open_vswitch passed to it. This was segmentation faulting
> when 'null_cfg' defined in bridge_reconfigure() was used because
> there was no Open vSwitch table.
The enable_system_stats() function calls smap_get_bool() on the
ovsrec_open_vswitch passed to it. This was segmentation faulting
when 'null_cfg' defined in bridge_reconfigure() was used because
there was no Open vSwitch table.
Signed-off-by: Ethan Jackson
---
vswitchd/bridge.c | 2 ++
1 file ch
On Wed, Jul 18, 2012 at 10:21:50AM -0700, Ben Pfaff wrote:
> On Wed, Jul 18, 2012 at 12:02:19PM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
>
> When I apply this to master (currently 333be161abe78), I get the
> following test failure. It isn't immediately obvious to me why this
>
On Wed, Jul 18, 2012 at 11:59:27PM +0530, Arun Sharma wrote:
> Please let me know your comments.
See inline.
> On 7/14/12 9:20 AM, "Arun Sharma" wrote:
>
> >Please see comments inline.
> >
> >On 7/13/12 10:08 PM, "Ben Pfaff" wrote:
> >
> >>On Wed, Jul 11, 2012 at 07:41:59PM -0700, Arun Sharma
Please let me know your comments.
On 7/14/12 9:20 AM, "Arun Sharma" wrote:
>Please see comments inline.
>
>On 7/13/12 10:08 PM, "Ben Pfaff" wrote:
>
>>On Wed, Jul 11, 2012 at 07:41:59PM -0700, Arun Sharma wrote:
>>> Option --ovs is added for ovs-bugtool command to collect
>>> only OpenvSwitch r
On Wed, Jul 11, 2012 at 05:34:56PM -0500, Ethan Jackson wrote:
> > +/* We can end up in these states is */
>
> This sentence doesn't make a lot of sense to me.
Yeah, I agree. I don't know what it was meant to say, so I deleted
it.
> Otherwise looks good, thanks.
Thanks. I'll push this ser
On Wed, Jul 11, 2012 at 04:46:41PM -0500, Ethan Jackson wrote:
> > +/* Deletes 'node' from 'sh'. Neither the node's key nor its value is
> > freed;
> > + * instead, ownership is transferred to the caller. Returns the node's
> > key. */
>
> This should say from 'smap'
Thanks, fixed.
> > +char
On Mon, Jul 16, 2012 at 04:57:48PM -0700, Ben Pfaff wrote:
> On Fri, Jul 13, 2012 at 02:19:10PM +0900, Simon Horman wrote:
> > On Thu, Jul 12, 2012 at 09:48:34PM -0700, Ben Pfaff wrote:
> > > On Fri, Jul 13, 2012 at 01:46:39PM +0900, Simon Horman wrote:
> > > > On Thu, Jul 12, 2012 at 09:17:11PM -0
On Wed, Jul 18, 2012 at 12:02:19PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
When I apply this to master (currently 333be161abe78), I get the
following test failure. It isn't immediately obvious to me why this
change should have an effect on dl_vlan_pcp, so I'll leave it to you
to
Yeah, Isaku cited that text in his original commit. I'll add it to
the commit message before I push.
Thanks,
Ben.
On Wed, Jul 18, 2012 at 10:08:04AM -0700, Justin Pettit wrote:
> Looks good. Even the later versions of OpenFlow specify that behavior. From
> the 1.3 candidate spec:
>
> Th
Looks good. Even the later versions of OpenFlow specify that behavior. From
the 1.3 candidate spec:
The action list of an OFPT_PACKET_OUT message can also
specify the OFPP_TABLE reserved port as an output action
to process the packet through the existing flow entries,
startin
On Wed, Jul 18, 2012 at 08:41:28PM +0900, Isaku Yamahata wrote:
> output OFPP_TABLE should send the packet to the first table whose
> table id is 0.
> Nicira extension case, output-reg and bundle action, the behavior
> is kept.
>
> From the spec,
> > Submit the packet to the first flow table NB: T
Commit 299016266ed1 (New action NXAST_RESUBMIT_TABLE.) changed OFPP_TABLE
from resubmitting to table 0 to resubmitting to the current table. This
wasn't mentioned in the change log and I believe it was a typo. This
commit changes the behavior back.
This isn't a very serious bug because OpenFlow
On Wed, Jul 18, 2012 at 08:41:17PM +0900, Isaku Yamahata wrote:
> Signed-off-by: Isaku Yamahata
It looks like your intended strategy for handling Apply-Actions is to
put those actions into a nested set of ofpacts. I see how this would
work--it is one strategy that I have considered--but the stra
On Wed, Jul 18, 2012 at 08:41:16PM +0900, Isaku Yamahata wrote:
> So far, didn't checked if action structure of variable length
> has multiple length of 8 bytes.
>
> Signed-off-by: Isaku Yamahata
I believe that this is redundant with the !(len % OFP_ACTION_ALIGN)
check in action_is_valid(), call
On Wed, Jul 18, 2012 at 08:41:15PM +0900, Isaku Yamahata wrote:
> Those logic is same, so simplify it. This will be also use for OF12.
>
> Signed-off-by: Isaku Yamahata
Applied to master, thank you.
I am not sure that we really need something new for OF1.2, however,
because as far as I know the
Thanks, I applied this to master.
On Tue, Jul 17, 2012 at 11:38:45PM -0700, Justin Pettit wrote:
> Looks reasonable to me.
>
> --Justin
>
>
> On Jul 16, 2012, at 3:13 PM, Ben Pfaff wrote:
>
> > Reported-by: Ed Maste
> > Signed-off-by: Ben Pfaff
> > ---
> > INSTALL.userspace | 13 ++
On Wed, Jul 18, 2012 at 10:00:49AM +0200, Bastian Blank wrote:
> On Tue, Jul 17, 2012 at 09:31:44AM -0700, Ben Pfaff wrote:
> > On Tue, Jul 17, 2012 at 03:20:40PM +0200, Bastian Blank wrote:
> > > openvswitch uses a db called /etc/openvswitch/conf.db. This file is
> > > programmatic modified and no
On Wed, Jul 18, 2012 at 09:57:13AM +0200, Bastian Blank wrote:
> Enabling brcompat without openvswitch-brcompat installed or the module
> available breaks the init script and normal operation without brcompat.
I'm surprised to hear that, because the init script contains:
if test X"$BRCOMPAT"
On Wed, Jul 18, 2012 at 09:55:56AM +0200, Bastian Blank wrote:
> Installing openvswitch-brcompat is not enough to actually enable it.
> There is an additional switch in /etc/defaults/openvswitch-switch to
> enable it.
It's documented in the package description:
Once this package is installed, a
Signed-off-by: Isaku Yamahata
---
ofproto/ofproto-dpif.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 4ffcbd7..641eab0 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -5503,9 +5503,14 @@
The split out function will be used for goto-table instruction.
Signed-off-by: Isaku Yamahata
---
lib/packets.c | 42 ++
lib/packets.h |2 ++
ofproto/ofproto-dpif.c | 39 ++-
3 files changed, 46
Signed-off-by: Isaku Yamahata
---
ofproto/ofproto-dpif.c | 274 ++--
1 files changed, 147 insertions(+), 127 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 69b9682..47c4789 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofp
Signed-off-by: Isaku Yamahata
---
ofproto/ofproto-dpif.c | 31 ---
1 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 559a9d1..12c61af 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
output OFPP_TABLE should send the packet to the first table whose
table id is 0.
Nicira extension case, output-reg and bundle action, the behavior
is kept.
>From the spec,
> Submit the packet to the first flow table NB: This destination port
> can only be used in packet-out messages. Submit the p
Signed-off-by: Isaku Yamahata
---
ofproto/ofproto-dpif.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 641eab0..4783b7f 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -5575,9 +5575,11 @@ do_
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c | 182 -
lib/ofp-util.c| 26
2 files changed, 191 insertions(+), 17 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 2489879..a88c253 100644
--- a/lib/ofp-
When goto-table instruction results in table miss, generate packet-in event
Signed-off-by: Isaku Yamahata
---
ofproto/ofproto-dpif.c | 18 +++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 12c61af..d272cc0 1
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c | 140 +++-
lib/ofp-actions.h | 30 ++-
ofproto/ofproto-dpif.c |7 +++
3 files changed, 163 insertions(+), 14 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
i
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c |3 +++
lib/ofp-parse.c |9 +
lib/ofp-util.c|2 ++
lib/ofp-util.def | 10 ++
lib/ofp-util.h|3 +++
5 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
Signed-off-by: Isaku Yamahata
---
ofproto/ofproto-dpif.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 47c4789..4ffcbd7 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -5571,6 +5571,9 @@ do_xlat
Signed-off-by: Isaku Yamahata
---
v4
newly introduced
---
lib/ofp-parse.c | 36 ++--
lib/ofp-util.c |1 +
2 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index 65b3f0f..3cddc86 100644
--- a/lib/ofp-parse.c
++
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c | 15 +++
lib/ofp-actions.h |1 +
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index d7df9e6..6c78ac1 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -32,6 +32,
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c | 42 +-
1 files changed, 33 insertions(+), 9 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 6c78ac1..2489879 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -1602,6 +16
Those logic is same, so simplify it. This will be also use for OF12.
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c | 46 +++---
1 files changed, 15 insertions(+), 31 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 566ccda..08
So far, didn't checked if action structure of variable length
has multiple length of 8 bytes.
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 0874cc4..d274895 100644
-
Signed-off-by: Isaku Yamahata
---
lib/ofp-actions.c | 22 ++
lib/ofp-actions.h |4
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index d274895..2f80a29 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@
This patch adds instruction OF11 apply-actions/goto-table supports.
The approach is to introduce OFPACT_ which corresponds to instruction.
Although I haven't tested it fully yet, I'd like to get feed back before
going too further. It this approach is sane?
If so, I'll go finish it. (Or go for oth
On Tue, Jul 17, 2012 at 09:31:44AM -0700, Ben Pfaff wrote:
> On Tue, Jul 17, 2012 at 03:20:40PM +0200, Bastian Blank wrote:
> > openvswitch uses a db called /etc/openvswitch/conf.db. This file is
> > programmatic modified and not user editable. This violates ยง10.7 of the
> > policy.
> Can you be mo
Package: openvswitch-brcompat
Version: 1.4.2+git20120612-2
Severity: serious
Enabling brcompat without openvswitch-brcompat installed or the module
available breaks the init script and normal operation without brcompat.
Bastian
-- System Information:
Debian Release: wheezy/sid
APT prefers test
Package: openvswitch-brcompat
Version: 1.4.2+git20120612-2
Severity: normal
Installing openvswitch-brcompat is not enough to actually enable it.
There is an additional switch in /etc/defaults/openvswitch-switch to
enable it.
Bastian
-- System Information:
Debian Release: wheezy/sid
APT prefers
47 matches
Mail list logo
