Yeah, Isaku cited that text in his original commit. I'll add it to the commit message before I push.
Thanks, Ben. On Wed, Jul 18, 2012 at 10:08:04AM -0700, Justin Pettit wrote: > Looks good. Even the later versions of OpenFlow specify that behavior. From > the 1.3 candidate spec: > > The action list of an OFPT_PACKET_OUT message can also > specify the OFPP_TABLE reserved port as an output action > to process the packet through the existing flow entries, > starting at the first flow table. > > --Justin > > On Jul 18, 2012, at 9:46 AM, Ben Pfaff wrote: > > > Commit 299016266ed1 (New action NXAST_RESUBMIT_TABLE.) changed OFPP_TABLE > > from resubmitting to table 0 to resubmitting to the current table. This > > wasn't mentioned in the change log and I believe it was a typo. This > > commit changes the behavior back. > > > > This isn't a very serious bug because OpenFlow 1.0 says that OFPP_TABLE is > > supposed to be used only in packet-out messages, in which case the current > > table is 0 anyhow. > > > > Reported-by: Isaku Yamahata <yamah...@valinux.co.jp> > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > --- > > ofproto/ofproto-dpif.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > > index 5265d7b..dc15c15 100644 > > --- a/ofproto/ofproto-dpif.c > > +++ b/ofproto/ofproto-dpif.c > > @@ -5158,7 +5158,7 @@ xlate_output_action(struct action_xlate_ctx *ctx, > > compose_output_action(ctx, ctx->flow.in_port); > > break; > > case OFPP_TABLE: > > - xlate_table_action(ctx, ctx->flow.in_port, ctx->table_id); > > + xlate_table_action(ctx, ctx->flow.in_port, 0); > > break; > > case OFPP_NORMAL: > > xlate_normal(ctx); > > -- > > 1.7.2.5 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
