On Thu, Jul 12, 2012 at 11:07:15AM +1200, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
Applied to master, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Jul 11, 2012 at 02:10:42PM -0700, Ben Pfaff wrote:
> On Mon, Jul 09, 2012 at 06:03:55PM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
>
> I'm not sure about MFM_IPV6_LABEL, because it means that an exact-match
> mask would be rejected, even though an exact-match mask is suppo
Signed-off-by: Joe Stringer
---
lib/meta-flow.c | 16 ++--
1 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index 8e7d4fc..8ba21fc 100644
--- a/lib/meta-flow.c
+++ b/lib/meta-flow.c
@@ -998,17 +998,11 @@ mf_get_value(const struct mf_f
In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to
write to the metadata field. Internally it is represented using ofpact_metadata.
We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in
OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA.
Wh
[Please keep this on the list.]
I don't think you need to use queues. Just rules of the form:
ovs-ofctl add-flow priority=100,in_port=1,tcp,tp_dst=5001,output=3
ovs-ofctl add-flow priroity=50,in_port=1,output=2
ovs-ofctl add-flow priroity=50,in_port=2,output=1
> +/* We can end up in these states is */
This sentence doesn't make a lot of sense to me.
Otherwise looks good, thanks.
Ethan
> +S_REQUEST_SENT, /* Sent a request to worker. */
> +S_REPLY_RECEIVED/* Received a reply from worker. */
> +} state;
> +
> +/* In
Hi Dear,Compliment s of the season !!Um, i am aminata by name, i wishto have
you as my friend so shall we be good friends ? I want us to baseon mutual
friendship because A 'Hello' today can mean a friendship tomorrow. Friendship
is a word, the very sight of which in print makes the heart warm
It should be pretty straight-forward with the "ovs-ofctl add-flow" command.
There's a pretty extensive man page for the ovs-ofctl program.
--Justin
On Jul 11, 2012, at 3:19 PM, Anand Daga wrote:
> System:
> We have a VM 10.70.11.86 on a XENServer with OVS. The VM is connected to the
> OVS(xe
*System:*
We have a VM 10.70.11.86 on a XENServer with OVS. The VM is connected to
the OVS(xenbr0) on tap1.0 which is port 1 of OVS.
Now we have 2 physical n/w interfaces namely eth0 & eth1 on OVS port 2 & 3
resp.
*System diagram:*
<> ---> tap1.0 <>
Looks good to me.
Ethan
On Wed, Jun 27, 2012 at 1:25 PM, Ben Pfaff wrote:
> "smap" is now the appropriate data structure for a string-to-string map.
>
> Also changes ovsdb_datum_from_shash() into ovsdb_datum_from_smap() since
> system-stats related code was the only client.
>
> Signed-off-by: B
On Wed, Jul 11, 2012 at 03:29:01PM -0500, Ethan Jackson wrote:
> Looks good to me. I don't think this should cause any bugs btw. What
> will happen is in non-extended mode some junk will be shoved in the
> zero section of the CCM. Shouldn't cause any problems, but of course
> it's best not to do
> +/* Deletes 'node' from 'sh'. Neither the node's key nor its value is freed;
> + * instead, ownership is transferred to the caller. Returns the node's key.
> */
This should say from 'smap'
> +char *
> +smap_steal(struct smap *smap, struct smap_node *node)
> +{
> +char *key = node->key;
>
thanks, you're right.
thee correct syntax is :
ip link add gre3 type gretap remote 10.98.98.13 local 10.98.98.1
Best Regards,
Nicolas Prochazka.
2012/7/11 Jesse Gross
> On Wed, Jul 11, 2012 at 2:09 PM, Ben Pfaff wrote:
> > On Wed, Jul 11, 2012 at 10:53:43PM +0200, nicolas prochazka wrote:
> >
Looks good to me. Really clean actually.
Ethan
On Wed, Jun 27, 2012 at 1:25 PM, Ben Pfaff wrote:
> These will acquire a caller in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/smap.c | 36
> lib/smap.h |5 +
> 2 files changed, 41 i
On Thu, Jul 12, 2012 at 12:06:36AM +1200, Joe Stringer wrote:
>
> > +/* XXX Unused function */
> > +static void
> > +ofpact_metadata_to_openflow11(const struct ofpact_metadata *om,
> > + struct ofpbuf *out)
> > +{
> > +struct ofp11_instruction_write_metadata *oiwm;
On Thu, Jul 12, 2012 at 12:01:11AM +1200, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
Thank you, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jul 09, 2012 at 06:03:54PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
Applied to master. Thank you!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Jul 11, 2012 at 2:09 PM, Ben Pfaff wrote:
> On Wed, Jul 11, 2012 at 10:53:43PM +0200, nicolas prochazka wrote:
>> Hello,
>> i'm trying to configure openswitch with GRE interface with GRE kernel
>> module, not with openswitch gre module ( that's works well)
>>
>> Kernel : 3.5.0-rc6 + Gre mo
On Mon, Jul 09, 2012 at 06:03:55PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
I'm not sure about MFM_IPV6_LABEL, because it means that an exact-match
mask would be rejected, even though an exact-match mask is supposed to
be equivalent to a match without a mask. I think that we need
On Wed, Jul 11, 2012 at 10:53:43PM +0200, nicolas prochazka wrote:
> Hello,
> i'm trying to configure openswitch with GRE interface with GRE kernel
> module, not with openswitch gre module ( that's works well)
>
> Kernel : 3.5.0-rc6 + Gre module + openvswitch module
>
>ip tunnel add GRE1 mod
Hello,
i'm trying to configure openswitch with GRE interface with GRE kernel
module, not with openswitch gre module ( that's works well)
Kernel : 3.5.0-rc6 + Gre module + openvswitch module
ip tunnel add GRE1 mode gre remote 10.98.98.1 local 10.98.98.16 ttl 255
ip link set GRE1 up
ovs-
Looks good to me. I don't think this should cause any bugs btw. What
will happen is in non-extended mode some junk will be shoved in the
zero section of the CCM. Shouldn't cause any problems, but of course
it's best not to do this.
Will you please backport this to the appropriate branches?
Tha
Thanks for the fixes! A couple nitpick comments inline. v2 and your
responses in v1 resolved all of my previous concerns.
On Tue, Jul 10, 2012 at 11:40 PM, Arun Sharma wrote:
> +# Filter out ovs relevant information if --ovs option passed
> +# else collect all information
> +if onl
On Wed, Jul 11, 2012 at 11:14 AM, Zoltan Kiss wrote:
> Regarding this change, I would also consider to change OVSP_NONE to
> UINT16_MAX:
>
> -#define OVSP_NONE ((uint16_t) -1)
> +#define OVSP_NONE UINT16_MAX
Please send a patch.
___
dev mailing list
dev
On Wed, Jul 11, 2012 at 11:03 AM, Zoltan Kiss wrote:
> This is just a small cosmetic change to express what that value means.
>
> Signed-off-by: Zoltan Kiss
Your patch doesn't compile because OVSP_NONE is defined only in
userspace, not the kernel. The actual value doesn't mean anything
though s
Regarding this change, I would also consider to change OVSP_NONE to
UINT16_MAX:
-#define OVSP_NONE ((uint16_t) -1)
+#define OVSP_NONE UINT16_MAX
This macro is used everywhere to be assigned to u16 variables, so it
would be more elegant and portable to express 0x in this way. Here
is a dis
This is just a small cosmetic change to express what that value means.
Signed-off-by: Zoltan Kiss
---
datapath/datapath.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index dc2cfad..b2d6d51 100644
--- a/datapath/datapath.c
++
On Tue, Jun 26, 2012 at 05:02:22PM -0700, ravi kerur wrote:
> Patch sent last night had missed some fixes in the kernel + whitespace
> errors. Anyways attaching latest patch.
Hi Ravi. I'm playing with your patches and come to some questions.
- More than 1 MPLS labels case
This case seems unfini
Option --ovs is added for ovs-bugtool command to collect
only OpenvSwitch relevant information. To perform
filtering in plugins, a new xml attribute filters="ovs" (optional)
would be required in element 'command','files','directory' in
openvswitch.xml. Value of 'filters' attribute will be compared
OK, I've pushed my bug fix to vlan-maint.
I haven't actually reviewed your optimization for correctness. I'll be
out most of the day today, then I'll review it tomorrow.
On Wed, Jul 11, 2012 at 03:42:48PM +0100, Zoltan Kiss wrote:
> Yes, I would definitely want you to post your fix to vlan-maint
On Wed, Jul 11, 2012 at 09:16:00AM -0400, Ed Maste wrote:
>
> Signed-off-by: Ed Maste
Applied to master, thanks a lot.
(I adjusted the Signed-off-by: to match your From: address.)
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman
Hello,
My names are Miss Angela Kami. I came across your email ID as i was browsing
and have much interest on you as directed by my spirit.I really need us to be
very close friends and what ever.
please send to me am email so that i can send to you my picture for you to know
me the more.I be
Yes, I would definitely want you to post your fix to vlan-maint, I've
also tested it.
Regarding my patch about optimization, we have reviewed it, and I think
it's not a crucial optimization for us (such PACKET_OUTs which generate
further PACKET_INs are supposed to be a rare case), so I don't ins
Thanks for the review comments. Applied the comments and the comments are
mentioned inline.
I will share Patch V2 in next email.
From: Reid Price
Date: Tue, 10 Jul 2012 18:57:12 -0700
To: Arun Sharma
Cc:
Subject: Re: [ovs-dev] [PATCH] ovs-bugtool: Added --ovs option to get only
ovs relate
Signed-off-by: Ed Maste
---
lib/route-table-bsd.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c
index c145091..1c29071 100644
--- a/lib/route-table-bsd.c
+++ b/lib/route-table-bsd.c
@@ -29,6 +29,8 @@
#include
#include
+#include "vlog
> +/* XXX Unused function */
> +static void
> +ofpact_metadata_to_openflow11(const struct ofpact_metadata *om,
> + struct ofpbuf *out)
> +{
> +struct ofp11_instruction_write_metadata *oiwm;
> +
> +oiwm = instruction_put_OFPIT11_WRITE_METADATA(out);
> +oiwm-
In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to
write to the metadata field. Internally it is represented using ofpact_metadata.
We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in
OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA.
Wh
Signed-off-by: Joe Stringer
---
tests/ovs-ofctl.at | 11 ---
tests/test-classifier.c | 14 ++
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at
index 491e0ab..a50a04d 100644
--- a/tests/ovs-ofctl.at
+++ b/tests/ovs
Continuing the work started with 969fc56c2abb0c3a1bf0225032250aa537df55a3, this
patch series adds more tests for the existing OXM_OF_METADATA field, and adds
support for writing to this field - in 1.0+ using vendor extensions, and in 1.1
with the WRITE_METADATA instruction.
Joe Stringer (2):
tes
Thanks Ben,
all of your comments look sensible and useful to me. I add some reply below.
Il 11/07/2012 01:59, Ben Pfaff ha scritto:
> Thanks.
>
> Would you mind updating NOTICE and debian/copyright.in to mention the
> license on the new contribution?
>
Sure.
> Do you want to add an INSTALL.Fre
On Wed, Jul 11, 2012 at 01:14:28AM -0700, Justin Pettit wrote:
> On Jul 11, 2012, at 1:07 AM, Ben Pfaff wrote:
>
> > I actually prefer decimal over hexadecimal most of the time (I only have
> > 10 fingers) but referring to output of ds_put_hex_dump() I want to use
> > hexadecimal because that's th
On Jul 11, 2012, at 1:07 AM, Ben Pfaff wrote:
> I actually prefer decimal over hexadecimal most of the time (I only have
> 10 fingers) but referring to output of ds_put_hex_dump() I want to use
> hexadecimal because that's the base that ds_put_hex_dump() uses for the
> offsets it prints along the
On Wed, Jul 11, 2012 at 01:02:06AM -0700, Justin Pettit wrote:
>
> On Jul 11, 2012, at 12:59 AM, Ben Pfaff wrote:
>
> > On Wed, Jul 11, 2012 at 12:57:20AM -0700, Justin Pettit wrote:
> >> On Jul 11, 2012, at 12:53 AM, Ben Pfaff wrote:
> >>
> >>> +Q: How can I figure out the port number for a giv
On Wed, Jul 11, 2012 at 12:37:41AM -0700, Justin Pettit wrote:
> On Jul 9, 2012, at 2:21 PM, Ben Pfaff wrote:
>
> > +if (!VLOG_DROP_WARN(&rl)) {
> > +struct ds s;
> > +
> > +ds_init(&s);
> > +ds_put_hex_dump(&s, in, n_in * sizeof *in, 0, false);
> > +
On Jul 11, 2012, at 12:59 AM, Ben Pfaff wrote:
> On Wed, Jul 11, 2012 at 12:57:20AM -0700, Justin Pettit wrote:
>> On Jul 11, 2012, at 12:53 AM, Ben Pfaff wrote:
>>
>>> +Q: How can I figure out the port number for a given port?
>>
>> "Port number" is such an overloaded term that maybe we should
On Wed, Jul 11, 2012 at 12:57:20AM -0700, Justin Pettit wrote:
> On Jul 11, 2012, at 12:53 AM, Ben Pfaff wrote:
>
> > +Q: How can I figure out the port number for a given port?
>
> "Port number" is such an overloaded term that maybe we should be more
> specific. What about "OpenFlow port number"
On Jul 11, 2012, at 12:55 AM, Ben Pfaff wrote:
> On Wed, Jul 11, 2012 at 12:52:36AM -0700, Justin Pettit wrote:
>> On Jul 11, 2012, at 12:15 AM, Ben Pfaff wrote:
>>
>>> +A: The term "normalization" in the log message means that a flow
>>> + cannot match on an L3 field without saying what L3 pro
On Jul 11, 2012, at 12:53 AM, Ben Pfaff wrote:
> +Q: How can I figure out the port number for a given port?
"Port number" is such an overloaded term that maybe we should be more specific.
What about "OpenFlow port number"? Also, it may be useful that it
distinguishes it from the datapath port
On Wed, Jul 11, 2012 at 12:52:36AM -0700, Justin Pettit wrote:
> On Jul 11, 2012, at 12:15 AM, Ben Pfaff wrote:
>
> > +A: The term "normalization" in the log message means that a flow
> > + cannot match on an L3 field without saying what L3 protocol is in
> > + use. The "ovs-ofctl" command ab
I don't understand why, but I've had this question from multiple people
recently.
Signed-off-by: Ben Pfaff
---
FAQ | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/FAQ b/FAQ
index 572b852..66f7b6a 100644
--- a/FAQ
+++ b/FAQ
@@ -520,6 +520,33 @@
On Jul 11, 2012, at 12:15 AM, Ben Pfaff wrote:
> +A: The term "normalization" in the log message means that a flow
> + cannot match on an L3 field without saying what L3 protocol is in
> + use. The "ovs-ofctl" command above didn't say, so the L3 field
> + match was dropped.
Maybe I'm just
On Jul 9, 2012, at 2:21 PM, Ben Pfaff wrote:
> +if (!VLOG_DROP_WARN(&rl)) {
> +struct ds s;
> +
> +ds_init(&s);
> +ds_put_hex_dump(&s, in, n_in * sizeof *in, 0, false);
> +VLOG_WARN("bad action format at offset %#x:\n%s",
> +
Signed-off-by: Ben Pfaff
---
FAQ | 31 +++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/FAQ b/FAQ
index 7f3a784..572b852 100644
--- a/FAQ
+++ b/FAQ
@@ -489,6 +489,37 @@ Q: My OpenFlow controller doesn't see the VLANs that I
expect.
A: See answe
53 matches
Mail list logo
