On Jul 9, 2012, at 2:21 PM, Ben Pfaff wrote:
> + if (!VLOG_DROP_WARN(&rl)) {
> + struct ds s;
> +
> + ds_init(&s);
> + ds_put_hex_dump(&s, in, n_in * sizeof *in, 0, false);
> + VLOG_WARN("bad action format at offset %#x:\n%s",
> + (n_in - left) * sizeof *a, ds_cstr(&s));
Very minor, but there are a couple of inconsistencies. First, you're taking
sizeof "*in" in one spot and "*a" later. It seems like "sizeof *a" is more
common in the function with two calls. Second, the offset is printed in
decimal in the bad action case and hex in the bad action format case.
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
