Looks good.
--Justin
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
> The flow_cookie member of struct ofoperation has always been there, but it
> seems that it's never been used. This fixes the code so that if a modify
> operation fails the rule's original flow cookie is restored.
>
> Signed-o
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
> @@ -873,7 +875,8 @@ struct rconn_packet_counter *
> rconn_packet_counter_create(void)
> {
> struct rconn_packet_counter *c = xmalloc(sizeof *c);
> -c->n = 0;
> +c->n_packets = 0;
> +c->n_bytes = 0;
> c->ref_cnt = 1;
Do you think i
Looks good.
--Justin
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
> This is likely to be part of OpenFlow 1.3.1 or 1.4 and we have use for it
> beforehand to report evicted flows.
>
> Signed-off-by: Ben Pfaff
> ---
> include/openflow/openflow-common.h |3 ++-
> lib/ofp-print.c
Looks good.
--Justin
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
> An upcoming commit will introduce a user outside of ofp-util.c.
>
> The change to put_stats_reply__() is larger than strictly necessary to
> avoid making really ugly line breaks.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-
Looks good.
--Justin
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
> In an upcoming commit I want to print comma-separated, not space-separated,
> names for a set of bits.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-print.c | 20 +++-
> 1 files changed, 11 insertions(+), 9 de
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
> +/* Returns true if 'rule' exactly matches 'criteria' or are more specific
> than
s/are/is/
> + * Equivalently, the truth table for whether a field matches is:
> + *
> + * rule
> + *
> + *
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:
> An upcoming commit will add support for flow table monitoring by
> controllers. One feature of this upcoming support is that a controller's
> own changes to the flow table can be abbreviated to a summary, since the
> controller presumably know what
Buy cialis Here!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
