Looks good.

--Justin


On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote:

> The flow_cookie member of struct ofoperation has always been there, but it
> seems that it's never been used.  This fixes the code so that if a modify
> operation fails the rule's original flow cookie is restored.
> 
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> ofproto/ofproto.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index dfa83e5..66e8bb8 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -3650,6 +3650,7 @@ ofopgroup_complete(struct ofopgroup *group)
>             if (!op->error) {
>                 rule->modified = time_msec();
>             } else {
> +                rule->flow_cookie = op->flow_cookie;
>                 free(rule->ofpacts);
>                 rule->ofpacts = op->ofpacts;
>                 rule->ofpacts_len = op->ofpacts_len;
> -- 
> 1.7.2.5
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to