[ovs-dev] [PATCv2] ovs-l3ping: A new test utility that allows to detect L3 tunneling issues

2012-06-29 Thread Ansis Atteka
ovs-l3ping is similar to ovs-test, but the main difference is that it does not require administrator to open firewall holes for the XML/RPC control connection. This is achieved by encapsulating the Control Connection over the L3 tunnel itself. This tool is not intended as a replacement for ovs-tes

[ovs-dev] [flow monitor 10/11] ofproto: Refactor rule_has_out_port() in terms of new ofp-util function.

2012-06-29 Thread Ben Pfaff
An upcoming commit will introduce a second user for the new function actions_output_to_port(). Signed-off-by: Ben Pfaff --- lib/ofp-util.c| 15 +++ lib/ofp-util.h|3 +++ ofproto/ofproto.c | 15 +++ 3 files changed, 21 insertions(+), 12 deletions(-) diff -

[ovs-dev] [flow monitor 09/11] ofp-util: Make put_stats__() public as ofputil_put_stats_header().

2012-06-29 Thread Ben Pfaff
An upcoming commit will introduce a user outside of ofp-util.c. The change to put_stats_reply__() is larger than strictly necessary to avoid making really ugly line breaks. Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 25 ++--- lib/ofp-util.h |4 2 files changed,

[ovs-dev] [flow monitor 08/11] ofp-util: New function ofputil_postappend_stats_reply().

2012-06-29 Thread Ben Pfaff
It's easier to make up stats replies if you don't have to accurately predict the number of bytes that will be necessary. This immediately allows us to rewrite ofputil_append_flow_stats_reply() without using NXM_MAX_LEN, which in turn allows us to deleted NXM_MAX_LEN entirely, which is nice since k

[ovs-dev] [flow monitor 07/11] ofp-print: Slightly extend ofp_print_bit_names().

2012-06-29 Thread Ben Pfaff
In an upcoming commit I want to print comma-separated, not space-separated, names for a set of bits. Signed-off-by: Ben Pfaff --- lib/ofp-print.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/lib/ofp-print.c b/lib/ofp-print.c index 5103c3e..e6d9151

[ovs-dev] [flow monitor 06/11] classifier: New function cls_rule_is_loose_match().

2012-06-29 Thread Ben Pfaff
This function will be useful in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/classifier.c | 76 -- lib/classifier.h |3 ++ 2 files changed, 48 insertions(+), 31 deletions(-) diff --git a/lib/classifier.c b/lib/classifier.c index

[ovs-dev] [flow monitor 05/11] ofproto: Finalize all ofoperations in a given ofgroup at the same time.

2012-06-29 Thread Ben Pfaff
An upcoming commit will add support for flow table monitoring by controllers. One feature of this upcoming support is that a controller's own changes to the flow table can be abbreviated to a summary, since the controller presumably know what it has already sent to the switch. However, the summary

[ovs-dev] [flow monitor 04/11] ofproto: Make ofoperation_create() return the new operation.

2012-06-29 Thread Ben Pfaff
This seems like sensible return value semantics to me, even though the new operation is also available through rule->pending. This is a code cleanup only that should not affect behavior. Signed-off-by: Ben Pfaff --- ofproto/ofproto.c | 27 ++- 1 files changed, 18 inser

[ovs-dev] [flow monitor 03/11] nicira-ext: Fix wrong information in comment.

2012-06-29 Thread Ben Pfaff
The priority of exact-match flows is ignored only for the OF1.0 flow match format, never for NXM. Signed-off-by: Ben Pfaff --- include/openflow/nicira-ext.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h in

[ovs-dev] [flow monitor 02/11] ovs-ofctl: Fix typos in manpage.

2012-06-29 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index 9c4ea0c..3ca217b 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@ -276,7 +276,7 @@ I

[ovs-dev] [flow monitor 01/11] ofproto: Fix typos in comments.

2012-06-29 Thread Ben Pfaff
This corrects the spelling of the OFOPERATION_* constants. Signed-off-by: Ben Pfaff --- ofproto/ofproto.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index ce4da9d..5221318 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofprot

Re: [ovs-dev] [PATCH] ovs-vswitchd: Call mlockall() from the daemon, not the parent or monitor.

2012-06-29 Thread Ethan Jackson
Thanks! On Fri, Jun 29, 2012 at 5:20 PM, Ben Pfaff wrote: > Thanks, I pushed this to master, branch-1.7, branch-1.6, and I'll > crossport to earlier branches in a while. > > On Fri, Jun 29, 2012 at 04:24:22PM -0400, Justin Pettit wrote: >> Great catch!  Thanks, Ben. >> >> --Justin >> >> >> On Jun

Re: [ovs-dev] [PATCH] ovs-vswitchd: Call mlockall() from the daemon, not the parent or monitor.

2012-06-29 Thread Ben Pfaff
Thanks, I pushed this to master, branch-1.7, branch-1.6, and I'll crossport to earlier branches in a while. On Fri, Jun 29, 2012 at 04:24:22PM -0400, Justin Pettit wrote: > Great catch! Thanks, Ben. > > --Justin > > > On Jun 29, 2012, at 12:28 PM, Ben Pfaff wrote: > > > mlockall(2) says: > >

Re: [ovs-dev] MPLS and VLAN QinQ patch

2012-06-29 Thread Jesse Gross
Ben and I talked a little about the best way to move forward with this. At this point, none of the possible implementations for handling TTL are particularly appealing. Recirculation in the kernel is likely the right solution for at least some of the problems but it would likely be complicated an

Re: [ovs-dev] [PATCH] Route-table implementation for (Free)BSD

2012-06-29 Thread Ben Pfaff
On Fri, Jun 29, 2012 at 09:11:24PM +, Ed Maste wrote: > This is a trivial implementation of the route-table functionality for > FreeBSD, as needed by ofproto/ofproto-dpif-sflow.c. It has not yet > been extensively tested. > > Signed-off-by: Ed Maste > --- > Note that my primary goal here was

Re: [ovs-dev] [PATCH] Move Linux #include under #ifdef __linux__

2012-06-29 Thread Ben Pfaff
On Fri, Jun 29, 2012 at 09:13:54PM +, Ed Maste wrote: > > Signed-off-by: Ed Maste Thanks, applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Move Linux #include under #ifdef __linux__

2012-06-29 Thread Ed Maste
Signed-off-by: Ed Maste --- lib/vlandev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vlandev.c b/lib/vlandev.c index 77e8e93..ffb8e73 100644 --- a/lib/vlandev.c +++ b/lib/vlandev.c @@ -23,13 +23,13 @@ #include #include "hash.h" -#include "rtnetlink-link.h" #

[ovs-dev] [PATCH] Route-table implementation for (Free)BSD

2012-06-29 Thread Ed Maste
This is a trivial implementation of the route-table functionality for FreeBSD, as needed by ofproto/ofproto-dpif-sflow.c. It has not yet been extensively tested. Signed-off-by: Ed Maste --- Note that my primary goal here was to get a basic implementation to allow it to build, so that I can move

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-29 Thread Ethan Jackson
> If Ethan tells us his plan, then maybe we can just execute that > instead of implementing for BSD.  Ceteris paribus, I agree that it's > better to delete code than to add more of it! My plan is basically to delete the route_table code entirely because the features it implements aren't particular

Re: [ovs-dev] [PATCH] Using UTC in all of ovs logs

2012-06-29 Thread Arun Sharma
Fixed and shared the Patch V2. On 6/28/12 8:44 PM, "Ben Pfaff" wrote: >On Thu, Jun 28, 2012 at 07:23:48PM -0700, Arun Sharma wrote: >> Fixed the remaining programs which does not logs in UTC timestamp >>format. >> >> Signed-off-by: Arun Sharma > >In vlog_init(), I think we should drop %z from

[ovs-dev] [PATCH V2] Using UTC in all of ovs logs

2012-06-29 Thread Arun Sharma
Fixed the remaining programs which does not logs in UTC timestamp format. Also updated NEWS. Signed-off-by: Arun Sharma --- NEWS |5 - lib/table.c |2 +- lib/vlog.c|4 ++-- ovsdb/ovsdb-tool.c|2 +- utilities/ovs-ofctl.c |2 +- 5

Re: [ovs-dev] [PATCH] ovs-vswitchd: Call mlockall() from the daemon, not the parent or monitor.

2012-06-29 Thread Justin Pettit
Great catch! Thanks, Ben. --Justin On Jun 29, 2012, at 12:28 PM, Ben Pfaff wrote: > mlockall(2) says: > > Memory locks are not inherited by a child created via fork(2) and are > automatically removed (unlocked) during an execve(2) or when the > process terminates. > > wh

[ovs-dev] [PATCH V2] ovs-ofctl: Ability to sort dump-flows by priority/other flow fields.

2012-06-29 Thread Arun Sharma
ovs-ofctl will have --sort[=field]|--rsort[=field] option for 'dump-flows'. Sort by field if specified else sort by default field 'priority'. Option "--sort" to sort in ascending order and "--rsort" to sort in descending order for flow fields. If field values found equal in some entries then those

[ovs-dev] [PATCH] ovs-vswitchd: Call mlockall() from the daemon, not the parent or monitor.

2012-06-29 Thread Ben Pfaff
mlockall(2) says: Memory locks are not inherited by a child created via fork(2) and are automatically removed (unlocked) during an execve(2) or when the process terminates. which means that --mlockall was ineffective in combination with --detach or --monitor or both.

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-29 Thread Ben Pfaff
On Fri, Jun 29, 2012 at 09:44:55AM -0400, Ed Maste wrote: > On 28 June 2012 23:15, Ben Pfaff wrote: > > The route-table implementation is definitely not portable, but I don't > > think there's anything in the interface that can't be implemented in > > FreeBSD.  One proper solution, then, would be

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-29 Thread Ed Maste
On 28 June 2012 23:15, Ben Pfaff wrote: > The route-table implementation is definitely not portable, but I don't > think there's anything in the interface that can't be implemented in > FreeBSD.  One proper solution, then, would be to add an implementation > that works in FreeBSD.  I'd certainly t

Re: [ovs-dev] [RFC v4 00/63] Preliminary Open Flow 1.2 Message Support

2012-06-29 Thread Isaku Yamahata
On Fri, Jun 29, 2012 at 01:41:31PM +0900, Isaku Yamahata wrote: > ../utilities/ovs-ofctl.c: In function 'do_show': > ../utilities/ovs-ofctl.c:500:63: warning: 'vconn' is used uninitialized in > this function [-Wuninitialized] The following local hack is necessary to make ovs-ofctl work. At the m