[ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-25 Thread Justin Pettit
Commit e72e793 (Add ability to restrict flow mods and flow stats requests to cookies.) modified cookie handling. Some of its behavior was unintuitive and there was at least one bug (described below). Commit f66b87d (DESIGN: Document uses for flow cookies.) attempted to document a clean design for

Re: [ovs-dev] [PATCH] ofp-util: Clean up cookie handling.

2012-05-25 Thread Justin Pettit
On May 21, 2012, at 4:00 PM, Ben Pfaff wrote: > "git am" says: > >Applying: ofp-util: Clean up cookie handling. >/home/blp/ovs/.git/rebase-apply/patch:189: trailing whitespace. >/* Wildcard matching of the cookie is only supported through NXM. > */ >warning: 1 line adds

[ovs-dev] [loss-report 4/4] dpif-linux: Log details when a packet is lost.

2012-05-25 Thread Ben Pfaff
Until now, when a packet was dropped in the kernel-to-user buffers, we logged the occurrence but nothing that would allow a person reading the log after the fact to learn why it was dropped. This commit adds details that identify the major sources of packets in the buffer, which should help. Sign

[ovs-dev] [loss-report 3/4] dpif-linux: Slightly refactor internal data structures.

2012-05-25 Thread Ben Pfaff
An initial attempt also replaced the 'uint32_t ready_mask' in struct dpif_linux by a 'bool ready' in each struct dpif_channel, but I wasn't happy with the result (the ready_mask bitmap works out really well) and so I dropped that part. Signed-off-by: Ben Pfaff --- lib/dpif-linux.c | 67 +++

[ovs-dev] [loss-report 2/4] dpif-linux: Avoid pessimal behavior when kernel-to-user buffers overflow.

2012-05-25 Thread Ben Pfaff
When a kernel-to-user Netlink buffer overflows, the kernel reports ENOBUFS without passing along an actual message. When it does this, we should immediately try again, because we know that there is a message waiting, instead of reporting the error to the caller. This improves the OVS response rat

[ovs-dev] [loss-report 1/4] poll-loop: More strictly rate-limit high CPU use.

2012-05-25 Thread Ben Pfaff
120 messages per minute just isn't helpful. Signed-off-by: Ben Pfaff --- lib/poll-loop.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/poll-loop.c b/lib/poll-loop.c index ba6c3a1..516cf13 100644 --- a/lib/poll-loop.c +++ b/lib/poll-loop.c @@ -1,5 +1,5 @@ /* - *

Re: [ovs-dev] [ovs-discuss] kernel crash - openvswitch_mod

2012-05-25 Thread Jesse Gross
On Fri, May 25, 2012 at 11:59 AM, Luiz Ozaki wrote: > On 5/25/12 11:05 AM, Jesse Gross wrote: >> >> No, the caller will perform that check. rpl_skb_gso_segment() is a >> compatibility replacement for skb_gso_segment() on older kernels. It needs >> to return a pointer, not an error code. > > > Hmmm

Re: [ovs-dev] [ovs-discuss] kernel crash - openvswitch_mod

2012-05-25 Thread Luiz Ozaki
On 5/25/12 11:05 AM, Jesse Gross wrote: No, the caller will perform that check. rpl_skb_gso_segment() is a compatibility replacement for skb_gso_segment() on older kernels. It needs to return a pointer, not an error code. Hmmm... Yea, Im trying to do some debug on this. I did the objdump, I

Re: [ovs-dev] [PATCH 05/21] vswitchd: Add add_tunnel_ports()

2012-05-25 Thread Ben Pfaff
On Thu, May 24, 2012 at 06:08:58PM +0900, Simon Horman wrote: > Add tunnel tundevs for tunnel realdevs as needed. > > In general the notion is that realdevs may be configured by users > and from an end-user point of view are compatible with the existing > port-based tunneling code. And that tundev

Re: [ovs-dev] MPLS and VLAN QinQ patch

2012-05-25 Thread Ravi.Kerur
-Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Friday, May 25, 2012 9:32 AM To: Kerur, Ravi Cc: dev@openvswitch.org Subject: Re: [ovs-dev] MPLS and VLAN QinQ patch On Fri, May 25, 2012 at 01:24:00AM +0200, ravi.ke...@telekom.com wrote: > On Thu, May 24, 2012 at 11:58:5

Re: [ovs-dev] MPLS and VLAN QinQ patch

2012-05-25 Thread Ben Pfaff
On Fri, May 25, 2012 at 01:24:00AM +0200, ravi.ke...@telekom.com wrote: > On Thu, May 24, 2012 at 11:58:53PM +0200, ravi.ke...@telekom.com wrote: > > Ben Pfaff writes: > > > get_l3_ttl_and_tos() > > > > > > > > > Why does get_l3_ttl_and_tos() consider an unknown IP version as

Re: [ovs-dev] MPLS and VLAN QinQ patch

2012-05-25 Thread Ben Pfaff
On Fri, May 25, 2012 at 06:27:11PM +0200, ravi.ke...@telekom.com wrote: > Sorry for the confusion, I was not questioning your comments they > are valid and I have addressed them. While making changes it > occurred to me how invalid_ttl is handled in the controller, will it > suffer from similar ttl

Re: [ovs-dev] MPLS and VLAN QinQ patch

2012-05-25 Thread Ravi.Kerur
Sorry for the confusion, I was not questioning your comments they are valid and I have addressed them. While making changes it occurred to me how invalid_ttl is handled in the controller, will it suffer from similar ttl expiry attack and should rate-limit sending invalid_ttl to controller? Since

Re: [ovs-dev] MPLS and VLAN QinQ patch

2012-05-25 Thread Ben Pfaff
On Fri, May 25, 2012 at 05:49:30PM +0200, ravi.ke...@telekom.com wrote: > I would like to revisit this topic... > > > ofproto-dpif.c > > -- > > > > I think that say, two, dec_mpls_ttl actions in a single flow, > > starting from a TTL of, say, 2, will fail to detect reaching TTL > > 0.

Re: [ovs-dev] MPLS and VLAN QinQ patch

2012-05-25 Thread Ravi.Kerur
I would like to revisit this topic... ofproto-dpif.c -- I think that say, two, dec_mpls_ttl actions in a single flow, starting from a TTL of, say, 2, will fail to detect reaching TTL 0. Also, the existing implementation of dec ttl for IP stop translating actions after reaching TTL

Re: [ovs-dev] [ovs-discuss] kernel crash - openvswitch_mod

2012-05-25 Thread Jesse Gross
On Fri, May 25, 2012 at 3:58 AM, Luiz Ozaki wrote: > On 5/16/12 11:47 PM, Jesse Gross wrote: >> >> On Wed, May 16, 2012 at 7:45 PM, Ben Pfaff  wrote: >>> >>> I would expect that only a host kernel bug (inside or outside the OVS >>> kernel module) would cause a host kernel panic and reboot, so I am

Re: [ovs-dev] [ovs-discuss] kernel crash - openvswitch_mod

2012-05-25 Thread Luiz Ozaki
On 5/16/12 11:47 PM, Jesse Gross wrote: On Wed, May 16, 2012 at 7:45 PM, Ben Pfaff wrote: I would expect that only a host kernel bug (inside or outside the OVS kernel module) would cause a host kernel panic and reboot, so I am surprised at the idea that a bug in Xen tools (in the guest) would c

[ovs-dev] 87% Off TESOL Teaching Certification Course

2012-05-25 Thread TeacherBuys
$79 for a 150-Hour Specialist TESOL/TEFL Course from Global Leadership College ($599 Value) Please go to http://www.teacherbuys.com/nationwide/ for more details. Certificate awarded upon completion of course -150 hours of training from the comfort of your own home or office -Information includ