Re: [ovs-dev] [PATCH 2/2] [RFC] tunnelling: stt: Prototype Implementation

2012-04-19 Thread Simon Horman
On Thu, Apr 19, 2012 at 03:53:35PM -0700, Jesse Gross wrote: > On Wed, Apr 18, 2012 at 9:50 PM, Simon Horman wrote: > > This is a not yet well exercised implementation of STT intended for review, > > I am sure there are numerous areas that need improvement. > > > > In particular: > > - The transmi

Re: [ovs-dev] [PATCH 2/2] [RFC] tunnelling: stt: Prototype Implementation

2012-04-19 Thread Simon Horman
On Tue, Apr 17, 2012 at 07:58:33PM -0700, Jesse Gross wrote: > On Thu, Apr 12, 2012 at 12:36 AM, Simon Horman wrote: > > This is a not yet well exercised implementation of STT intended for review, > > I am sure there are numerous areas that need improvement. > > > > In particular: > > - The transm

Re: [ovs-dev] [PATCH 0/2 v3] [RFC] tunnelling: stt: Prototype Implementation

2012-04-19 Thread Simon Horman
On Thu, Apr 19, 2012 at 05:55:28PM -0700, Jesse Gross wrote: > On Thu, Apr 19, 2012 at 5:13 PM, Simon Horman wrote: > > On Thu, Apr 19, 2012 at 01:29:08PM -0700, Jesse Gross wrote: > >> On Wed, Apr 18, 2012 at 9:50 PM, Simon Horman wrote: > >> >  It seems to me that some changes are needed to the

Re: [ovs-dev] [PATCH 0/2 v3] [RFC] tunnelling: stt: Prototype Implementation

2012-04-19 Thread Jesse Gross
On Thu, Apr 19, 2012 at 5:13 PM, Simon Horman wrote: > On Thu, Apr 19, 2012 at 01:29:08PM -0700, Jesse Gross wrote: >> On Wed, Apr 18, 2012 at 9:50 PM, Simon Horman wrote: >> >  It seems to me that some changes are needed to the tunneling core code, >> >  in particular handle_offloads(), to allow

[ovs-dev] [PATCH 2/3] [RFC] Rename mf_fields as nxm_mf_fields

2012-04-19 Thread Simon Horman
This is to provide symetry with oxm_mf_fields which will be added to hold the fields for OXM which is part of Open Flow 1.2 Signed-off-by: Simon Horman --- lib/meta-flow.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 84b

[ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-19 Thread Simon Horman
This may be used in a similar way to nxm_mf_fields to handle parsing and serialisation of OXM TLVs. Signed-off-by: Simon Horman --- include/openflow/openflow-1.2.h |1 + lib/meta-flow.c | 404 +++ lib/meta-flow.h | 16 ++

[ovs-dev] [PATCH 1/3] [RFC] Add OXM_OF_* definitions

2012-04-19 Thread Simon Horman
These oxm_type definitions values will may be used when parsing serialising OXM TLVs. Signed-off-by: Simon Horman --- include/openflow/openflow-1.2.h | 58 +++ 1 file changed, 58 insertions(+) diff --git a/include/openflow/openflow-1.2.h b/include/openflow/

[ovs-dev] [PATCH 0/3] [RFC] Preliminary OXM support for Open vSwtich

2012-04-19 Thread Simon Horman
Hi, the three patches that comprise this series add oxm_field and OXM TLV definitions to Open vSwtich which may be used as a basis for an implementation of OXM. The code is based heavily on the existing NXM implementation which makes use of the same format with different field and TLV values. OX

Re: [ovs-dev] [PATCH 0/2 v3] [RFC] tunnelling: stt: Prototype Implementation

2012-04-19 Thread Simon Horman
On Thu, Apr 19, 2012 at 01:29:08PM -0700, Jesse Gross wrote: > On Wed, Apr 18, 2012 at 9:50 PM, Simon Horman wrote: > >  It seems to me that some changes are needed to the tunneling core code, > >  in particular handle_offloads(), to allow GSO skbs to be passed > >  unsegmented to STT. Perhaps a n

Re: [ovs-dev] [PATCH 2/2] [RFC] tunnelling: stt: Prototype Implementation

2012-04-19 Thread Jesse Gross
On Wed, Apr 18, 2012 at 9:50 PM, Simon Horman wrote: > This is a not yet well exercised implementation of STT intended for review, > I am sure there are numerous areas that need improvement. > > In particular: > - The transmit path's generation of partial checksums needs to be tested > - The VLAN

Re: [ovs-dev] [vsctl 0/6] make vsctl faster with lots of ports

2012-04-19 Thread Ben Pfaff
On Tue, Apr 17, 2012 at 05:23:05PM -0700, Ben Pfaff wrote: > This series makes ovs-vsctl about 2-4X faster for large numbers of > operations with large numbers of ports. Ethan, thanks for the reviews. I'll push this soon. > Patch 3/6 causes a test failure in test 1002. Some later patch, > proba

Re: [ovs-dev] [PATCH 0/2 v3] [RFC] tunnelling: stt: Prototype Implementation

2012-04-19 Thread Jesse Gross
On Wed, Apr 18, 2012 at 9:50 PM, Simon Horman wrote: >  It seems to me that some changes are needed to the tunneling core code, >  in particular handle_offloads(), to allow GSO skbs to be passed >  unsegmented to STT. Perhaps a new mutable->flags flag is in order? I agree that there definitely ne

[ovs-dev] [PATCH] automake: ofp-errors.[c|inc] are actually inside srcdir

2012-04-19 Thread Ansis Atteka
This patch fixes a build error when OVS is built inside "./_debian" directory. To reproduce this issue run "fakeroot debian/rules binary" or "debuild binary" inside the git root directory. Signed-off-by: Ansis Atteka --- lib/automake.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [ovs-dev] [PATCH] datapath: Use ETH_ALEN instead of VLAN_ETH_ALEN

2012-04-19 Thread Jesse Gross
On Thu, Apr 19, 2012 at 12:38 AM, Simon Horman wrote: > VLAN_ETH_ALEN will be removed in version 3.5 of the Linux kernel. > > Signed-off-by: Simon Horman Also applied, thanks Simon. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailma

Re: [ovs-dev] [PATCH] datapath: Include linux/completion.h

2012-04-19 Thread Jesse Gross
On Thu, Apr 19, 2012 at 12:38 AM, Simon Horman wrote: > This is needed for compilation against Linux 2.6.19 > > Signed-off-by: Simon Horman Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Ich bitte um Ihre Unterstuetzung!!

2012-04-19 Thread william dubem
Sehr geehrter Damen und Herren, Vorname/  Williams Name/   Dubem Nationalitaet/  Sierra Leonean Ich habe die Summe von USD 12 millionen von meinen verstorbenen Eltern geebrt. Meine Eltern wurden Diamanten Haendler. Das Geld wurde von meinen Eltern in der Sicherheitsfirma fuer sicheres Behalten de

[ovs-dev] [PATCH] datapath: Use ETH_ALEN instead of VLAN_ETH_ALEN

2012-04-19 Thread Simon Horman
VLAN_ETH_ALEN will be removed in version 3.5 of the Linux kernel. Signed-off-by: Simon Horman --- datapath/linux/compat/include/linux/if_vlan.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/linux/compat/include/linux/if_vlan.h b/datapath/linux/compat/include/li

[ovs-dev] [PATCH] datapath: Include linux/completion.h

2012-04-19 Thread Simon Horman
This is needed for compilation against Linux 2.6.19 Signed-off-by: Simon Horman --- datapath/genl_exec.c |1 + 1 file changed, 1 insertion(+) diff --git a/datapath/genl_exec.c b/datapath/genl_exec.c index 66c7f94..c963489 100644 --- a/datapath/genl_exec.c +++ b/datapath/genl_exec.c @@ -19,6