I just did a cursory review, but it looked reasonable to me. Thanks.
--Justin
On Mar 12, 2012, at 10:23 AM, Ben Pfaff wrote:
> The Autoconf manual says:
>
> Posix 1003.1-2001 requires that `cd' and `pwd' must update the
> `PWD' environment variable to point to the logical name of the
iPhone/iPad Apps Development - Blackberry/Android Mobile Apps Development
We are China based company explicitly active for iPhone software programming
solutions and Mobile Application Development services as well as wireless
application (WAP) development. We are organized to deliver premium qual
Update port does not check changed MTU for internal port which allows
administrator assign larger MTU compared non-internal port.
Signed-off-by: Pravin B Shelar
---
ofproto/ofproto.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofp
Requested-by: Niklas Andersson
Signed-off-by: Ethan Jackson
---
utilities/ovs-vsctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 48ae56b..0a9b776 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -489
Thanks Ben. So my assumption was wrong that flow matching is similar to LPM.
Any specific reason why its not implemented similar to LPM?
Thanks
Ravi
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Monday, March 12, 2012 2:55 PM
To: Kerur, Ravi
Cc: dev@openvswitch.org
S
On Mon, Mar 12, 2012 at 10:28:15PM +0100, ravi.ke...@telekom.com wrote:
> Hi,
>
> I have programmed 2 vlan flows via
>
> ovs-ofctl add-flow br0
> priority=65535,idle_timeout=5,dl_vlan_pcp=2,actions=strip_vlan,1
>
> ovs-ofctl add-flow br0
> priority=65535,idle_timeout=5,dl_vlan=2,dl_vla
Thanks again Ben for the review. Please see inline
-Original Message-
From: dev-boun...@openvswitch.org [mailto:dev-boun...@openvswitch.org] On
Behalf Of Ben Pfaff
Sent: Friday, March 09, 2012 11:21 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org
Subject: [ovs-dev] MPLS less-important comment
Signed-off-by: Ben Pfaff
---
ofproto/connmgr.c | 23 ---
ofproto/connmgr.h |1 -
2 files changed, 0 insertions(+), 24 deletions(-)
diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c
index 1f5fbed..ed1aac2 100644
--- a/ofproto/connmgr.c
+++ b/ofproto/connmgr.c
@@ -1438,2
Otherwise even controllers that should not receive any packet-ins (via
enable-async-messages=false) still receive the packet-ins that probe for
a controller being up when we're in fail-open.
Bug #9964.
Reported-by: James Schmidt
Signed-off-by: Ben Pfaff
---
ofproto/fail-open.c | 16 ++
Trying to add a new caller for connmgr_send_packet_in(), I wasn't sure
what to put in these members. Investigating, I saw that the function
didn't really need them, so this commit clears that up.
Signed-off-by: Ben Pfaff
---
ofproto/connmgr.c |6 +-
ofproto/ofproto-dpif.c |4 --
Only 'flow->in_port' was used, which was redundant with pin->fmd.in_port.
Signed-off-by: Ben Pfaff
---
ofproto/connmgr.c | 20
ofproto/connmgr.h |4 ++--
ofproto/ofproto-dpif.c |4 ++--
3 files changed, 12 insertions(+), 16 deletions(-)
diff --git a/ofpr
The ofp_packet_in reasons are OFPR_*, not OFPRR_*. (Duh.)
Signed-off-by: Ben Pfaff
---
lib/ofp-util.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/ofp-util.h b/lib/ofp-util.h
index 2172fd6..fd76eac 100644
--- a/lib/ofp-util.h
+++ b/lib/ofp-util.h
@@ -293,7 +293,
Patch 4/5 fixes bug #9964. The rest is minor stuff I noticed along
the way.
Ben Pfaff (5):
ofp-util: Fix typo in comment.
connmgr: Drop 'flow' parameter from connmgr_send_packet_in().
ofproto: connmgr_send_packet_in() doesn't need buffer_id and
total_len.
fail-open: Use connmgr_send_p
Hi,
I have programmed 2 vlan flows via
ovs-ofctl add-flow br0
priority=65535,idle_timeout=5,dl_vlan_pcp=2,actions=strip_vlan,1
ovs-ofctl add-flow br0
priority=65535,idle_timeout=5,dl_vlan=2,dl_vlan_pcp=2,actions=1
When I send vlan packets with vid=2 and vlan_pcp=2, I see packets alway
Thanks Ben for the review. Please see inline for , mostly agreeing to
changes, but some requires inputs/clarifications.
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Friday, March 09, 2012 11:20 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org
Subject: MPLS important comme
Thanks, I pushed this.
On Mon, Mar 12, 2012 at 01:11:13PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
>
> Ethan
>
> On Mon, Mar 12, 2012 at 12:59, Ben Pfaff wrote:
> > ofport_install() should set the MTU that it finds into the ofport
> > before calling set_internal_devs_mtu(), because the
On Fri, Mar 09, 2012 at 02:57:56PM -0800, Pravin B Shelar wrote:
> There is no need to refresh status and stats for existing devices
> if the device mtu is zero as it will be done periodically by
> vswitchd.
>
> Signed-off-by: Pravin B Shelar
The check !iface->cfg->mtu doesn't check for a zero M
Looks good, thanks.
Ethan
On Mon, Mar 12, 2012 at 12:59, Ben Pfaff wrote:
> ofport_install() should set the MTU that it finds into the ofport
> before calling set_internal_devs_mtu(), because the latter function might
> change the MTU and update ofport->mtu and the caller should not incorrectly
ofport_install() should set the MTU that it finds into the ofport
before calling set_internal_devs_mtu(), because the latter function might
change the MTU and update ofport->mtu and the caller should not incorrectly
overwrite its changes.
Signed-off-by: Ben Pfaff
---
Not tested.
ofproto/ofproto
On Fri, Mar 09, 2012 at 02:32:42PM -0800, Pravin B Shelar wrote:
> Internal device mtu does not influence mtu of other internal devices.
> So skip MTU setting completely when internal device mtu is changed.
>
> Signed-off-by: Pravin B Shelar
But won't this change behavior? The internal device M
Thanks everyone, I pushed these two patches.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* Ben Pfaff (b...@nicira.com) wrote:
> On Mon, Mar 12, 2012 at 11:18:58AM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote:
> > > > This adds ability to do:
> > > >
> > > > ./configure --disable-brcompat
> > >
The dh_installinit --error-handler option makes a lot of sense, but after
playing with it for a while I could not figure out a nice way to use it
only for openvswitch-switch without either duplicating the dh_installinit
fragments in postinst and prerm (the actual bug that was reported) or
omitting
On Mon, Mar 12, 2012 at 11:18:58AM -0700, Chris Wright wrote:
> * Ben Pfaff (b...@nicira.com) wrote:
> > On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote:
> > > This adds ability to do:
> > >
> > > ./configure --disable-brcompat
> > >
> > > to disable building userspace and kernel m
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote:
> > This adds ability to do:
> >
> > ./configure --disable-brcompat
> >
> > to disable building userspace and kernel module associated with
> > providing linux bridge compatibility.
> >
> > Sig
Looks good to me as well, thanks.
Ethan
On Mon, Mar 12, 2012 at 11:01, Chris Wright wrote:
> Thanks.
>
> Acked-by: Chris Wright
> ___
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
__
Looks good to me as well, thanks.
Ethan
On Mon, Mar 12, 2012 at 10:59, Chris Wright wrote:
> * Ben Pfaff (b...@nicira.com) wrote:
>> The generated version.py has to go in the srcdir and has to be regenerated
>> based on config.status, which breaks "make distcheck" because it
>> write-protects th
Thanks.
Acked-by: Chris Wright
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
* Ben Pfaff (b...@nicira.com) wrote:
> The generated version.py has to go in the srcdir and has to be regenerated
> based on config.status, which breaks "make distcheck" because it
> write-protects the srcdir. However, the contents of version.py only change
> when the version number changes, so we
On Fri, Mar 09, 2012 at 03:25:01PM -0800, Ben Pfaff wrote:
> On Fri, Mar 09, 2012 at 01:47:45AM +0800, Thomas Goirand wrote:
> > At the end, I did work on the packaging of openvswitch.
>
> I converted your patches to a series of commits and sent them out to
> ovs-dev for review. I believe that yo
On Fri, Mar 09, 2012 at 06:17:07PM -0800, Chris Wright wrote:
> This adds ability to do:
>
> ./configure --disable-brcompat
>
> to disable building userspace and kernel module associated with
> providing linux bridge compatibility.
>
> Signed-off-by: Chris Wright
I've had a little bit of tro
On Mon, Mar 12, 2012 at 10:28:40AM -0700, Ben Pfaff wrote:
> On Mon, Mar 12, 2012 at 10:28:09AM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote:
> > > > * Ben Pfaff (b...@nicira.com) wrote:
> > > > > Without this
Reported-by: Chris Wright
Signed-off-by: Ben Pfaff
---
include/openflow/automake.mk |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/openflow/automake.mk b/include/openflow/automake.mk
index f037a2b..ac7412b 100644
--- a/include/openflow/automake.mk
+++ b/include/
The generated version.py has to go in the srcdir and has to be regenerated
based on config.status, which breaks "make distcheck" because it
write-protects the srcdir. However, the contents of version.py only change
when the version number changes, so we can just "touch" it when it doesn't
really n
On Mon, Mar 12, 2012 at 10:28:09AM -0700, Chris Wright wrote:
> * Ben Pfaff (b...@nicira.com) wrote:
> > On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote:
> > > * Ben Pfaff (b...@nicira.com) wrote:
> > > > Without this change, these tests try to write to /var/run, which fails
> > > > un
* Ben Pfaff (b...@nicira.com) wrote:
> On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > Without this change, these tests try to write to /var/run, which fails
> > > unless "make check" is run as root.
> >
> > Yay! This was breaking for m
On Mon, Mar 12, 2012 at 10:10:15AM -0700, Chris Wright wrote:
> * Ben Pfaff (b...@nicira.com) wrote:
> > Without this change, these tests try to write to /var/run, which fails
> > unless "make check" is run as root.
>
> Yay! This was breaking for me on Friday too.
>
> I'm still hitting this from
The Autoconf manual says:
Posix 1003.1-2001 requires that `cd' and `pwd' must update the
`PWD' environment variable to point to the logical name of the
current directory, but traditional shells do not support this.
This can cause confusion if one shell instance maintains `PWD'
On Mon, Mar 12, 2012 at 10:06:21AM -0700, Justin Pettit wrote:
> Thanks for fixing this; I was running into it this weekend.
Pushed.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Mar 12, 2012 at 02:40:24PM +0900, Simon Horman wrote:
> On Fri, Mar 09, 2012 at 03:45:08PM -0800, Ben Pfaff wrote:
> > Simon, will you review these patches?
>
> sorry for not getting to this earlier as I was on vacation last week.
> I will review the patches now.
I really don't generally
On Mon, Mar 12, 2012 at 03:45:37PM +0900, Simon Horman wrote:
> On Mon, Mar 12, 2012 at 02:40:24PM +0900, Simon Horman wrote:
> > On Fri, Mar 09, 2012 at 03:45:08PM -0800, Ben Pfaff wrote:
> > > Simon, will you review these patches?
> >
> > Hi Ben,
> >
> > sorry for not getting to this earlier as
* Ben Pfaff (b...@nicira.com) wrote:
> Without this change, these tests try to write to /var/run, which fails
> unless "make check" is run as root.
Yay! This was breaking for me on Friday too.
I'm still hitting this from make distcheck (haven't dug into it yet):
mv ovsdb/ovsdb-server.1.tmp ovsd
The autoconf manual says:
`PWD'
Posix 1003.1-2001 requires that `cd' and `pwd' must update the
`PWD' environment variable to point to the logical name of the
current directory, but traditional shells do not support this.
This can cause confusion if one shell instance maintains
Thanks for fixing this; I was running into it this weekend.
It seems like the tests in that directory use both "`pwd`" and "$PWD"--with a
slight greater tendency towards using "$PWD". Is there a reason to prefer
"`pwd`" over "$PWD"? If it works the same, "$PWD" seems like it would be more
eff
Without this change, these tests try to write to /var/run, which fails
unless "make check" is run as root.
Signed-off-by: Ben Pfaff
---
tests/ovs-monitor-ipsec.at |1 +
tests/ovs-xapi-sync.at |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tests/ovs-monitor-ipsec
Thanks, I pushed this to master.
On Fri, Mar 09, 2012 at 06:09:39PM -0800, Gurucharan Shetty wrote:
> On Fri, Mar 9, 2012 at 4:22 PM, Ben Pfaff wrote:
> > Reported-by: Gurucharan Shetty
> > Signed-off-by: Ben Pfaff
> > ---
> > utilities/ovs-pki.in | 7 ++-
> > 1 files changed, 6 inserti
CC: Min Chen
Signed-off-by: Ben Pfaff
---
Min, here is a little documentation for the function that
confused you.
AUTHORS|1 +
ofproto/ofproto-dpif.c | 18 +-
2 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 958d7f5..b
47 matches
Mail list logo
