Re: [ovs-dev] [PATCH 1/2] xenserver: Always update the bridge ID in ovs-xapi-sync.

2012-02-29 Thread Justin Pettit
On Feb 29, 2012, at 8:10 PM, Ethan Jackson wrote: >> This seems fine as a fix for now, but I think that it causes >> ovs-xapi-sync to fetch all of the network records from XAPI on every >> iteration, so I think that we should consider caching the >> xs-network-uuids to bridge-id mapping in the sam

Re: [ovs-dev] [PATCH 1/2] xenserver: Always update the bridge ID in ovs-xapi-sync.

2012-02-29 Thread Ethan Jackson
> This seems fine as a fix for now, but I think that it causes > ovs-xapi-sync to fetch all of the network records from XAPI on every > iteration, so I think that we should consider caching the > xs-network-uuids to bridge-id mapping in the same way that we now cache > the iface-id mapping. I've u

Re: [ovs-dev] [PATCH 1/2] xenserver: Always update the bridge ID in ovs-xapi-sync.

2012-02-29 Thread Justin Pettit
On Feb 29, 2012, at 7:53 PM, Ben Pfaff wrote: > On Wed, Feb 29, 2012 at 07:49:32PM -0800, Ben Pfaff wrote: >> On Wed, Feb 29, 2012 at 07:17:24PM -0800, Ethan Jackson wrote: >>> In some cases we were seeing this column get stale. >>> >>> Bug #9929. >>> Signed-off-by: Ethan Jackson >> >> This see

Re: [ovs-dev] [PATCH 1/2] xenserver: Always update the bridge ID in ovs-xapi-sync.

2012-02-29 Thread Ben Pfaff
On Wed, Feb 29, 2012 at 07:49:32PM -0800, Ben Pfaff wrote: > On Wed, Feb 29, 2012 at 07:17:24PM -0800, Ethan Jackson wrote: > > In some cases we were seeing this column get stale. > > > > Bug #9929. > > Signed-off-by: Ethan Jackson > > This seems fine as a fix for now, but I think that it causes

Re: [ovs-dev] [PATCH 2/2] xenserver: Restart ovs-xapi-sync on kmod reload.

2012-02-29 Thread Ben Pfaff
On Wed, Feb 29, 2012 at 07:17:25PM -0800, Ethan Jackson wrote: > Some users never restart OVS, they just reload the kernel module on > each new version. Since ovs-xapi-sync is a daemon, a restart is > required to use the new code. Therefore, without this patch, users > could unwittingly use stale

Re: [ovs-dev] [PATCH 1/2] xenserver: Always update the bridge ID in ovs-xapi-sync.

2012-02-29 Thread Ben Pfaff
On Wed, Feb 29, 2012 at 07:17:24PM -0800, Ethan Jackson wrote: > In some cases we were seeing this column get stale. > > Bug #9929. > Signed-off-by: Ethan Jackson This seems fine as a fix for now, but I think that it causes ovs-xapi-sync to fetch all of the network records from XAPI on every ite

[ovs-dev] [PATCH 2/2] xenserver: Restart ovs-xapi-sync on kmod reload.

2012-02-29 Thread Ethan Jackson
Some users never restart OVS, they just reload the kernel module on each new version. Since ovs-xapi-sync is a daemon, a restart is required to use the new code. Therefore, without this patch, users could unwittingly use stale versions of ovs-xapi-sync. Bug #9919. Signed-off-by: Ethan Jackson --

[ovs-dev] [PATCH 1/2] xenserver: Always update the bridge ID in ovs-xapi-sync.

2012-02-29 Thread Ethan Jackson
In some cases we were seeing this column get stale. Bug #9929. Signed-off-by: Ethan Jackson --- .../usr_share_openvswitch_scripts_ovs-xapi-sync|5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync b/xenserver/usr_sh

[ovs-dev] [PATCH] netdev-linux: Use get-stats to check status on internal devices.

2012-02-29 Thread Pravin B Shelar
Rather than using ETHTOOL_GDRVINFO to check status, use get-stats from ovs since it is more consistent. Signed-off-by: Pravin B Shelar --- lib/netdev-linux.c | 69 +++- 1 files changed, 52 insertions(+), 17 deletions(-) diff --git a/lib/netdev-l

Re: [ovs-dev] [PATCH v2] netdev-linux: Fix stats for ovs internal device.

2012-02-29 Thread Pravin Shelar
Thanks, I pushed to 1.6 and master. On Wed, Feb 29, 2012 at 2:01 PM, Ben Pfaff wrote: > On Wed, Feb 29, 2012 at 01:59:43PM -0800, Pravin B Shelar wrote: >> Fixed according to comments from Ben. >> >> v1-v2: >>         - Fixed commit msg. >>         - Added comments. >>         - Fixed return type

Re: [ovs-dev] [PATCH v2] netdev-linux: Fix stats for ovs internal device.

2012-02-29 Thread Ben Pfaff
On Wed, Feb 29, 2012 at 01:59:43PM -0800, Pravin B Shelar wrote: > Fixed according to comments from Ben. > > v1-v2: > - Fixed commit msg. > - Added comments. > - Fixed return type of get_stats_via_vport(). > > --8<--cut here-

[ovs-dev] [PATCH v2] netdev-linux: Fix stats for ovs internal device.

2012-02-29 Thread Pravin B Shelar
Fixed according to comments from Ben. v1-v2: - Fixed commit msg. - Added comments. - Fixed return type of get_stats_via_vport(). --8<--cut here-->8- There is no need to retrieve linux system stats for internal devices as all

Re: [ovs-dev] [PATCH] bridge: Drop log message when a QoS record lacks a default queue.

2012-02-29 Thread Ben Pfaff
Thanks, this is now on master and 1.6. On Tue, Feb 28, 2012 at 01:38:23PM -0800, Bryan Fulton wrote: > Yep, looks good to me as well. > > Thanks Ben. > > .:bryan > > On Tue, Feb 28, 2012 at 1:06 PM, Ethan Jackson wrote: > > Looks good, > > > > Ethan > > > > On Tue, Feb 28, 2012 at 12:53, Ben P

Re: [ovs-dev] Patch for MPLS

2012-02-29 Thread Ravi.Kerur
Hi Ben, It's based on commit dd1ba5b3f4425c8eba008d1a93b044da63466812 Author: Justin Pettit Date: Fri Feb 24 10:32:36 2012 -0800 Thanks Ravi -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Wednesday, February 29, 2012 11:07 AM To: Kerur, Ravi Cc: dev@openvswitch.o

Re: [ovs-dev] [PATCH] netdev: Fix stats for ovs internal device.

2012-02-29 Thread Ben Pfaff
On Tue, Feb 28, 2012 at 06:08:56PM -0800, Pravin Shelar wrote: > On Tue, Feb 28, 2012 at 5:09 PM, Ben Pfaff wrote: > > On Fri, Feb 24, 2012 at 04:10:02PM -0800, Pravin B Shelar wrote: > >> There is no need to retrieve linux system stats for internal devices > >> as all relevant stats for virtual d

Re: [ovs-dev] Patch for MPLS

2012-02-29 Thread Ben Pfaff
On Mon, Feb 27, 2012 at 07:00:17PM +0100, ravi.ke...@telekom.com wrote: > Attached patch to support MPLS actions and match based on OF 1.1 > specification. Unit-tests.txt contains unit-tests performed on following > systems I'm starting to review this. But what commit is it based on? I couldn'

Re: [ovs-dev] Q on FLOW_SIG_SIZE and hashing

2012-02-29 Thread Ben Pfaff
On Tue, Feb 21, 2012 at 06:21:02PM +0100, ravi.ke...@telekom.com wrote: > I am facing some issues w.r.t hashing when FLOW_SIG_SIZE > 130. What > I did was to move around members of struct flow such that > FLOW_SIG_SIZE = (112 + FLOW_N_REGS * 4). Note that struct flow is > not packed so depending on