On Wed, Feb 29, 2012 at 07:17:25PM -0800, Ethan Jackson wrote: > Some users never restart OVS, they just reload the kernel module on > each new version. Since ovs-xapi-sync is a daemon, a restart is > required to use the new code. Therefore, without this patch, users > could unwittingly use stale versions of ovs-xapi-sync. > > Bug #9919. > Signed-off-by: Ethan Jackson <et...@nicira.com>
Looks good, except that I would change this: > + if daemon_is_running ovs-xapi-sync; then > + action "Stopping ovs-xapi-sync" stop_daemon ovs-xapi-sync > + fi to just: stop_daemon ovs-xapi-sync because stop_daemon already prints everything that is needed. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev