Re: [ovs-dev] [PATCH v2 2/2] xenserver: Only replace XenServer hosts scripts that we recognize.

2012-01-23 Thread Justin Pettit
On Jan 23, 2012, at 3:53 PM, Ben Pfaff wrote: > +*) > +keep_files=$scripts > +replace_files= > +cat < + > +The original XenServer scripts replaced by this package are not those > +of any supported version of XenServer. On XenServer earlier than The original scripts we

[ovs-dev] my name is mami

2012-01-23 Thread mami
Hello My Dear, Nice to meet you. mamikur...@yahoo.com Nuova grafica e nuove funzionalità! Crea subito Gratis la tua nuova Casella di Posta Katamail ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ofproto-dpif: Revalidate flows after "fdb/flush".

2012-01-23 Thread Ben Pfaff
Thanks, pushed to master, branch-1.4, branch-1.5. On Fri, Jan 20, 2012 at 02:23:40PM -0800, Ethan Jackson wrote: > Looks good to me. > > Ethan > > On Wed, Jan 18, 2012 at 16:09, Ben Pfaff wrote: > > Otherwise bad translations can stick around. > > > > Bug #9253. > > Reported-by: Paul Ingram >

Re: [ovs-dev] [PATCH] ofproto-dpif: Rate-limit all messages output by facet_check_consistency().

2012-01-23 Thread Ben Pfaff
On Mon, Jan 23, 2012 at 02:47:16PM -0800, Ethan Jackson wrote: > > Most of the diff is just indentation changes, so it's easier to > > spot the real changes if you first apply it with "git am" and > > then go in with "gitk" and click the box that says "Ignore space > > change". > > FWIW git diff a

Re: [ovs-dev] [PATCH v2 1/2] xenserver: Synchronize scripts with XenServer 6.0.0.

2012-01-23 Thread Justin Pettit
The changes look reasonable to me. --Justin On Jan 23, 2012, at 3:53 PM, Ben Pfaff wrote: > This commit updates the "vif" and "interface-reconfigure" scripts installed > by Open vSwitch on Citrix XenServer with those in XenServer 6.0.0. > > Signed-off-by: Ben Pfaff > --- > Not tested. > > xe

Re: [ovs-dev] [vlan-maint 1/2] mac-learning: Increase MAC learning timeout to 300 seconds.

2012-01-23 Thread Ben Pfaff
On Mon, Jan 23, 2012 at 02:49:14PM -0800, Justin Pettit wrote: > On Jan 23, 2012, at 2:43 PM, Ben Pfaff wrote: > > > This commit fixes the problem by increasing the MAC learning timeout from > > 60 seconds to 300 seconds. According to my reading, Linux uses a 60-second > > ARP timeout, old versio

[ovs-dev] [PATCH v2 1/2] xenserver: Synchronize scripts with XenServer 6.0.0.

2012-01-23 Thread Ben Pfaff
This commit updates the "vif" and "interface-reconfigure" scripts installed by Open vSwitch on Citrix XenServer with those in XenServer 6.0.0. Signed-off-by: Ben Pfaff --- Not tested. xenserver/etc_xensource_scripts_vif| 40 +++- .../opt_xensource_libexec_Inter

[ovs-dev] [PATCH v2 2/2] xenserver: Only replace XenServer hosts scripts that we recognize.

2012-01-23 Thread Ben Pfaff
Open vSwitch comes with slightly improved versions of upstream Citrix XenSever host scripts. Until now, the Open vSwitch RPMs have always installed its own versions of the scripts over the Citrix versions. This commit changes behavior to replace the scripts only if we recognize the exact versions

Re: [ovs-dev] [PATCH] cfm: Log more aggressively amidst packet loss.

2012-01-23 Thread Ethan Jackson
Thanks, I've merged this. Ethan On Mon, Jan 23, 2012 at 15:17, Ben Pfaff wrote: > On Mon, Jan 23, 2012 at 03:16:00PM -0800, Ethan Jackson wrote: >> > Please add Jacob to AUTHORS. >> > >> > This adds an odd blank line near the end of cfm_run(). >> >> Done. >> >> >> > The current message reports m

Re: [ovs-dev] [PATCH] cfm: Log more aggressively amidst packet loss.

2012-01-23 Thread Ben Pfaff
On Mon, Jan 23, 2012 at 03:16:00PM -0800, Ethan Jackson wrote: > > Please add Jacob to AUTHORS. > > > > This adds an odd blank line near the end of cfm_run(). > > Done. > > > > The current message reports missing sequence numbers, but I think that > > there are at least two other possible issues

Re: [ovs-dev] [PATCH] cfm: Log more aggressively amidst packet loss.

2012-01-23 Thread Ethan Jackson
> Please add Jacob to AUTHORS. > > This adds an odd blank line near the end of cfm_run(). Done. > The current message reports missing sequence numbers, but I think that > there are at least two other possible issues: duplicate sequence > numbers and out-of-order sequence numbers.  It might be a

Re: [ovs-dev] [vlan-maint 2/2] vswitchd: Make the MAC entry aging time configurable.

2012-01-23 Thread Ethan Jackson
s/agin/aging/ It may be worth documenting the allowed range in vswitchd.xml, I don't feel strongly about it though. Looks good, Ethan On Mon, Jan 23, 2012 at 14:43, Ben Pfaff wrote: > NICS-11. > Signed-off-by: Ben Pfaff > --- >  lib/learning-switch.c |    6 -- >  lib/mac-learning.c    |  

Re: [ovs-dev] [vlan-maint 1/2] mac-learning: Increase MAC learning timeout to 300 seconds.

2012-01-23 Thread Justin Pettit
On Jan 23, 2012, at 2:43 PM, Ben Pfaff wrote: > This commit fixes the problem by increasing the MAC learning timeout from > 60 seconds to 300 seconds. According to my reading, Linux uses a 60-second > ARP timeout, old versions of Windows use 2 minutes, and new versions of > Windows use 45 seconds

Re: [ovs-dev] [PATCH] ofproto-dpif: Rate-limit all messages output by facet_check_consistency().

2012-01-23 Thread Ethan Jackson
> Most of the diff is just indentation changes, so it's easier to > spot the real changes if you first apply it with "git am" and > then go in with "gitk" and click the box that says "Ignore space > change". FWIW git diff and git show take the -w option which ignores whitespace. Looks good. Etha

[ovs-dev] [vlan-maint 2/2] vswitchd: Make the MAC entry aging time configurable.

2012-01-23 Thread Ben Pfaff
NICS-11. Signed-off-by: Ben Pfaff --- lib/learning-switch.c |6 -- lib/mac-learning.c| 41 ++--- lib/mac-learning.h| 10 +++--- ofproto/ofproto.c |4 ++-- vswitchd/bridge.c | 14 -- vswitchd/vswitch.xml |6

[ovs-dev] [vlan-maint 0/2] increase MAC learning timeout, make configurable

2012-01-23 Thread Ben Pfaff
These patches are targeted at the vlan-maint branch. They will need to go to master, too, but this is an urgent request from Citrix for a customer support issue. I haven't tested these yet. Ben Pfaff (2): mac-learning: Increase MAC learning timeout to 300 seconds. vswitchd: Make the MAC entr

[ovs-dev] [vlan-maint 1/2] mac-learning: Increase MAC learning timeout to 300 seconds.

2012-01-23 Thread Ben Pfaff
When Cisco (and other?) routers are configured in high-availability modes, they use two different MAC addreses. The router uses MAC 1 only for ARP replies. The router uses MAC 2 for forwarding IP packets to end hosts. When a MAC learning switch is attached to the router, therefore, it will only l

Re: [ovs-dev] [eviction 10/12] ofproto: Move 'used' from ofproto_dpif into ofproto.

2012-01-23 Thread Ethan Jackson
Looks cleaner. Ethan On Fri, Jan 13, 2012 at 16:43, Ben Pfaff wrote: > This will allow the upcoming flow table eviction policy code to determine > which flows will expire soon. > > Signed-off-by: Ben Pfaff > --- >  NEWS                       |    3 +++ >  ofproto/ofproto-dpif.c     |   15 +

Re: [ovs-dev] [eviction 09/12] ofproto: Make ofproto_rule_destroy__() do nothing for a null argument.

2012-01-23 Thread Ethan Jackson
Looks good. Ethan On Fri, Jan 13, 2012 at 16:43, Ben Pfaff wrote: > This is our customary way to implement a "destroy" function.  It allows > a minor simplification in ofoperation_complete(). > > Signed-off-by: Ben Pfaff > --- >  ofproto/ofproto.c |   10 +- >  1 files changed, 5 inserti

Re: [ovs-dev] [eviction 08/12] ofproto: Remove unnecessary assignment from ofoperation_complete().

2012-01-23 Thread Ethan Jackson
Looks good. Ethan On Fri, Jan 13, 2012 at 16:43, Ben Pfaff wrote: > Nothing uses op->victim following this assignment, so it is not > needed. > > Signed-off-by: Ben Pfaff > --- >  ofproto/ofproto.c |    1 - >  1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/ofproto/ofproto.c b

Re: [ovs-dev] [eviction 04/12] timeval: New function time_boot_msec(), factored out of vlog.

2012-01-23 Thread Ethan Jackson
> We had explicit calls to time_init() a long time ago but it was hard > to maintain. Alright. Ethan > > On Mon, Jan 23, 2012 at 01:25:34PM -0800, Ethan Jackson wrote: >> I would think that you would want to explicitly call time_init() from >> main or something.  It probably doesn't matter as ti

Re: [ovs-dev] [eviction 07/12] ofproto: Implement "hidden" and "readonly" OpenFlow tables.

2012-01-23 Thread Ethan Jackson
Looks good. Ethan On Fri, Jan 13, 2012 at 16:43, Ben Pfaff wrote: > A "hidden" table is one that OpenFlow operations affect only if the > table_id is explicitly specified, that is, operations that affect > all tables ignore it. > > A "read-only" table is one that OpenFlow operations are not allo

Re: [ovs-dev] [eviction 04/12] timeval: New function time_boot_msec(), factored out of vlog.

2012-01-23 Thread Ben Pfaff
We had explicit calls to time_init() a long time ago but it was hard to maintain. On Mon, Jan 23, 2012 at 01:25:34PM -0800, Ethan Jackson wrote: > I would think that you would want to explicitly call time_init() from > main or something. It probably doesn't matter as time_msec() will > probably b

Re: [ovs-dev] [eviction 06/12] ofproto: Make ofproto ->construct() function initialize tables.

2012-01-23 Thread Ethan Jackson
Looks cleaner, thanks. Ethan On Fri, Jan 13, 2012 at 16:43, Ben Pfaff wrote: > If the ->construct() function initializes the OpenFlow tables itself, > then it can conveniently do implementation-specific configuration of > those tables afterward.  There isn't any such configuration to do yet; > a

Re: [ovs-dev] [eviction 05/12] ofproto: Encapsulate classifier tables in new "struct oftable".

2012-01-23 Thread Ethan Jackson
> +/* Removes 'old' from its oftable then, if 'new' is nonnull, inserts 'new'. > */ > +static void > +oftable_substitute_rule(struct rule *old, struct rule *new) > +{ > +    oftable_remove_rule(old); > +    if (new) { > +        oftable_replace_rule(new); > +    } > +} Could you do oftable_remove

Re: [ovs-dev] [eviction 04/12] timeval: New function time_boot_msec(), factored out of vlog.

2012-01-23 Thread Ethan Jackson
I would think that you would want to explicitly call time_init() from main or something. It probably doesn't matter as time_msec() will probably be called pretty quickly after startup. Just seems a bit more straightforward to me. Looks good, Ethan On Fri, Jan 13, 2012 at 16:43, Ben Pfaff wrote

[ovs-dev] Very opportunity

2012-01-23 Thread Info Mutui
Have you heard of WAZZUB? WAZZUB, is a Brilliant Concept; It has NEVER Been Done Before ~ Make no mistake. WAZZUB is a multi-billion dollar project. It has been in the making since 2007 with over $2,000,000 already invested. It’s the new Internet Phenomenon; it's here to stay and you are one of

[ovs-dev] hello My Dear,

2012-01-23 Thread esther
hello My Dear, i am miss sarah, i would like to know more about you,please contact me through (sarah44_will...@yahoo.com) fomer to explain myself and send my pics for you to know me.Best regards sarah,___ dev mailing list dev@openvswitch.org http://op