From: Shan Wei
For net part, remove duplicate included head.
Signed-off-by: Shan Wei
---
net/caif/caif_usb.c|1 -
net/ipv4/udp_diag.c|1 -
net/openvswitch/flow.c |1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
While debugging some issues today it became clear that it would be
useful to log when the CFM fault status changes and when packets
are lost. The CFM module logs pretty aggressively when in debug
mode, but this can be chatty and most systems don't operate under
this logging level for extended peri
Users may want to force the network to flush its MAC tables by
manually triggering a topology change event due to some event in
the system.
Signed-off-by: Ethan Jackson
---
lib/stp.c | 44
lib/stp.h |1 +
vswitc
Signed-off-by: Ethan Jackson
---
lib/stp.c | 12 +++-
lib/stp.h |1 +
ofproto/ofproto-dpif.c | 11 ++-
tests/test-stp.c |8 +++-
4 files changed, 29 insertions(+), 3 deletions(-)
diff --git a/lib/stp.c b/lib/stp.c
index 3e9a5b6..1f1
It sounds like your init function isn't getting called, I'd check on
that.
I usually use printk() to debug kernel issues.
On Tue, Jan 17, 2012 at 09:54:17AM +1100, Joseph Glanville wrote:
> Hi Ben,
>
> I first took the original patch and applied it to 1.3.0 with minimal
> changes. This seems to
Thanks, I pushed this.
To expand on Jesse's explanation a little, originally OVS had to steal
hooks used by the Linux bridge. There was no way for OVS to cooperate
with the bridge, so we arranged so that only one or the other could be
loaded. Somewhere in the 2.6.3x series, the Linux network sta
On Mon, Jan 16, 2012 at 02:58:43PM -0800, Jesse Gross wrote:
> On Mon, Jan 16, 2012 at 2:47 PM, Ethan Jackson wrote:
> > Looks good,
> >
> > Are we allowed to load openvswitch_mod and bridge at the same time?
>
> On some kernels we can, on others we prevent module loading.
>
> Should we do actua
On Mon, Jan 16, 2012 at 2:47 PM, Ethan Jackson wrote:
> Looks good,
>
> Are we allowed to load openvswitch_mod and bridge at the same time?
On some kernels we can, on others we prevent module loading.
Should we do actual exclusion of the brcompat module at the kernel level though?
__
Hi Ben,
I first took the original patch and applied it to 1.3.0 with minimal
changes. This seems to apply pretty cleanly but it fails to register
vxlan as a type ( I get netdev unrecognized protocol error ).
Attached is what I have so far, if you can spot any obvious errors
that would be awesome..
Looks good,
Are we allowed to load openvswitch_mod and bridge at the same time?
Ethan
On Mon, Jan 16, 2012 at 14:46, Ben Pfaff wrote:
> brcompat_mod and the Linux bridge module are incompatible, so it doesn't
> make sense to try to load both at the same time. This commit prevents
> ovs-ctl fro
brcompat_mod and the Linux bridge module are incompatible, so it doesn't
make sense to try to load both at the same time. This commit prevents
ovs-ctl from trying.
Signed-off-by: Ben Pfaff
Reported-by: Rogério Vinhal Nunes
Launchpad bug #917309.
---
AUTHORS |1 +
utilities/ovs-
On Mon, Jan 16, 2012 at 02:10:40PM -0800, Ansis Atteka wrote:
> I can alter the postinst behavior from 1.4 and up branches to the following:
>
> > if upgrade-from-pre-1.4-ovs to 1.4+-ovs then
> > throw a warning that kernel module needs to be reloaded so not
> > restarting user space
> > else
>
I can alter the postinst behavior from 1.4 and up branches to the following:
> if upgrade-from-pre-1.4-ovs to 1.4+-ovs then
> throw a warning that kernel module needs to be reloaded so not
> restarting user space
> else
> do only userspace restart and use old kernel module
> fi
See other com
On Sat, Jan 14, 2012 at 10:16 AM, Devendra Naga wrote:
> remove version.h includes in net/openswitch/ as reported by make versioncheck.
>
> Signed-off-by: Devendra Naga
I'm fine with the change (it's just a leftover from the out-of-tree
module), although in general please prefix the subject with
Thank you for the reviews. I pushed this series to master.
On Mon, Jan 16, 2012 at 01:31:04PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Tue, Dec 27, 2011 at 13:23, Ben Pfaff wrote:
> > Without logging of operation groups, it becomes more difficult to debug
> > problems related
Looks good,
Ethan
On Tue, Dec 27, 2011 at 13:23, Ben Pfaff wrote:
> Without logging of operation groups, it becomes more difficult to debug
> problems related to flow setups, since those go through operation groups.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif.c | 14 ++
> 1 fil
Looks good.
Ethan
On Tue, Dec 27, 2011 at 13:23, Ben Pfaff wrote:
> Until now, a "flow put" has represented its parameters in two different
> ways, depending on whether it was coming from dpif_flow_put() or from
> dpif_operate(), and similarly for an "execute" operation. This commit
> adopts th
Looks much cleaner, thank you.
Ethan
On Tue, Dec 27, 2011 at 13:23, Ben Pfaff wrote:
> I'd like to change ->dpif_flow_put() and ->dpif_execute() in the dpif
> provider to take the structures of the same names as parameters, instead of
> passing them discrete parameters, because this seems like a
Thanks, I fixed that up and pushed this.
On Mon, Jan 16, 2012 at 10:47:35AM -0800, Justin Pettit wrote:
> I think you meant to start "\fRgre0\fR" with "\fB". Otherwise, it
> looks good.
>
> --Justin
>
>
> On Jan 16, 2012, at 10:16 AM, Ben Pfaff wrote:
>
> > We've had questions about this a fe
Looks good to me.
On Fri, Jan 13, 2012 at 12:03:30PM -0800, Ethan Jackson wrote:
> Here's a version which incorporates your suggestions.
>
> ---
> As promised, post version 1.4 the default bond_mode is changing to
> active-backup with this commit.
>
> Signed-off-by: Ethan Jackson
> ---
> NEWS
I agree that this is much easier to understand. It looks good to me.
Thank you.
On Fri, Jan 13, 2012 at 11:56:49AM -0800, Ethan Jackson wrote:
> Here's the original version of the patch that I'd written. I had remvoed the
> LACP_CONFIGURED enum because I don't think it's strictly necessary. The
On Mon, Jan 16, 2012 at 11:32:10AM -0800, Ethan Jackson wrote:
> > The code looks OK to me. ?Can you point out the problem more
> > specifically?
>
> Looking over it again, I misread the code. The existing code is correct.
>
> In ofproto_dpif_self_check() you say 'argc' is OVS_UNUSED even though
Commit 34edeccfd8d (xenserver: Remove support for XenServer versions older
than 5.6 FP1.) stopped verifying the md5sums of the XenServer-owned host
scripts that the Open vSwitch RPM replaces. This commit restores that
behavior, as a small guard against future changes.
Signed-off-by: Ben Pfaff
--
This commit updates the "vif" and "interface-reconfigure" scripts installed
by Open vSwitch on Citrix XenServer with those in XenServer 6.0.0.
Signed-off-by: Ben Pfaff
---
Not yet tested.
xenserver/etc_xensource_scripts_vif| 40 +++-
.../opt_xensource_libexec_I
Title: AUNZData Version 5.0
View this email as WebpageAUNZData version 5.0
Attention: All existing AU & NZData customers will receive 75% off normal pricing for upgrade...Simply call us today to redeem this limited time offer:+61 (7) 31235934 (AU)+64 (9) 801-0023 (NZ)You will get all
> The code looks OK to me. Can you point out the problem more
> specifically?
Looking over it again, I misread the code. The existing code is correct.
In ofproto_dpif_self_check() you say 'argc' is OVS_UNUSED even though
you use it.
Otherwise looks good,
Ethan
>
>> It may be worth printing t
On Fri, Jan 13, 2012 at 04:01:49PM -0800, Ethan Jackson wrote:
> Looks like this will be pretty useful.
>
> In facet_check_consistency()
> Is facet_revalidate the appropriate coverage counter to increment?
No. Removed.
> When rule != facet->rule we don't initialize the dynamic string.
Ouch. T
List available: US businesses
- 4 million emails
Price until Friday: $99
CLICK HERE TO ORDER
File
Available for download in excel format
Some of the business
categories
I think you meant to start "\fRgre0\fR" with "\fB". Otherwise, it looks good.
--Justin
On Jan 16, 2012, at 10:16 AM, Ben Pfaff wrote:
> We've had questions about this a few times.
>
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-vsctl.8.in |6 ++
> 1 files changed, 6 insertions(+),
I don't think we've made any subtle or surprising changes. Let us
know if you have questions.
On Mon, Jan 16, 2012 at 07:05:46PM +1100, Joseph Glanville wrote:
> Hi Ben
>
> All, good. I'm in the process of porting the patchset labeled v2 (
> http://openvswitch.org/pipermail/dev/2011-October/0122
On Fri, Jan 13, 2012 at 11:40:50AM -0800, Ansis Atteka wrote:
> This will make Debian upgrade consistent with Xenserver
> and RH where user must manually run force-reload-kmod
> command after the upgrade.
>
> Issue: 9128
>
> Signed-off-by: Ansis Atteka
> Reported-by: Michael Kruze
I'm not sure
We've had questions about this a few times.
Signed-off-by: Ben Pfaff
---
utilities/ovs-vsctl.8.in |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in
index d24af14..bfc84cc 100644
--- a/utilities/ovs-vsctl.8.in
+++ b/u
EURO MILLONES LOTTERIA (DE BILBAO) Y APUESTAS S.A.
OFFIZIELLE GEWINNBENACHRITIGUNG
Hi Ben
All, good. I'm in the process of porting the patchset labeled v2 (
http://openvswitch.org/pipermail/dev/2011-October/012207.html.
As far as I can see some stuff has moved around to accomodate inclusion in
mainline and many variables have been namespaced with ovs_ etc.
Is there anything spec
34 matches
Mail list logo
