On Fri, Jan 13, 2012 at 11:40:50AM -0800, Ansis Atteka wrote: > This will make Debian upgrade consistent with Xenserver > and RH where user must manually run force-reload-kmod > command after the upgrade. > > Issue: 9128 > > Signed-off-by: Ansis Atteka <aatt...@nicira.com> > Reported-by: Michael Kruze <mkr...@nicira.com>
I'm not sure that I support this change. The warning seems too severe. Userspace should be able to cooperate with newer and older kernel modules (since 1.4), so restarting or loading the new kernel module isn't strictly necessary. Furthermore, if only userspace is being upgraded, there is no advantage to running "force-reload-kmod" over the less risky "restart". The warning also should mention rebooting as an alternative, I think. In general I think we'd prefer to restart OVS automatically whenever the new package is installed, except when that is not going to work because we are upgrading from a pre-1.4 version. Looking at the issue you cited, the problem was an upgrade from a 1.3 version of OVS to a later version. It would make sense to me, in that case, to print this kind of warning and avoid restarting OVS. You could use "dpkg --compare-versions" to figure out when it is appropriate. I'm not sure that the warning is appropriate in all cases where $2 is nonnull. Did you think about all the cases listed for "postinst" here: http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-mscriptsinstact (I'm not saying that the behavior is wrong, I'm trying to make sure that you thought about it.) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
